From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BC5BA0583; Thu, 19 Mar 2020 09:11:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EB79F1C069; Thu, 19 Mar 2020 09:11:12 +0100 (CET) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by dpdk.org (Postfix) with ESMTP id E06341C068 for ; Thu, 19 Mar 2020 09:11:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584605471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7a/puPQ5dCRoOMdob12CuEtadj9Bwj4S+ACwqPjrNn0=; b=apNSxar1KEYGMGVzltJ48/uN4SctjwBiLLgDO7e9FDUj9SjxYh5GUl6fMX0oAYA689cs7n VAIzQJG17EQPLJI3k0bPvhTCheGJY7yJ+co1xUeDTUwl10IAfazeC67JgpsAovyU921DNx WtZzyWj4tUZJfScL62jbB58+EO3Kl+k= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-260-bfuele5TO7ytZS3Gb8IgQg-1; Thu, 19 Mar 2020 04:11:05 -0400 X-MC-Unique: bfuele5TO7ytZS3Gb8IgQg-1 Received: by mail-ua1-f70.google.com with SMTP id 16so365834uag.13 for ; Thu, 19 Mar 2020 01:11:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rYXdK899wNKZssgly81IlcfdNpempVA58bPhA1aXCLk=; b=DvHt+xd5jzMIQUsT2tH2eLWOHQsDslVBpoMKlEx/CigJTyUg5FkjRGLQNDW6ICU1Wf QLQ8l6DQ65Bpe10IeKUyRNRd3hoxfGSs9W4FgV12Kykyua4/0QVwEr4n5OyPPCoeeEF5 Gi7OJKCKXPWIuWf9UQO3lIKulbxVssyVBgXsex+/RBmeoeJNwJkhH6Rch+ycDJOidQ2M az8XY+kxDk1LM4tN+Yj6KvPB4uqE0qITnuQ4bsXyY8m8l3IeVUmYFhAsfcyGllkDEKql wii78Whxf3a0E2E8tA5gtKdv7CirG9C9D3dYt6dIU2uVWNbkdFrMbfwoWHNjkOwKGHUF U7lg== X-Gm-Message-State: ANhLgQ0Nn49YdDhQjrt4AlY3RMhaW40pzt0E0aqbGz5j4/xw4Zh0AIY8 0Y5pxieKFo3m0vSkxftlyMYkXhxWeQuZl3jGrmsamKZOQe0WsC9f3PgwdAp1NpgSwqsn4p1DGKU u6GByb0Avzh8yAfOg4Rk= X-Received: by 2002:a67:69d8:: with SMTP id e207mr1121346vsc.141.1584605465345; Thu, 19 Mar 2020 01:11:05 -0700 (PDT) X-Google-Smtp-Source: ADFU+vutLVl6wtxOkuFcFNrFt/bX2ZbZwANKIz3R3KXVw81iZd0szNI63zY1Zt1kkwQZHpeeWMLQAqR8GYRYZNcJ/Gk= X-Received: by 2002:a67:69d8:: with SMTP id e207mr1121325vsc.141.1584605464999; Thu, 19 Mar 2020 01:11:04 -0700 (PDT) MIME-Version: 1.0 References: <20200316112951.35428-1-bruce.richardson@intel.com> <7bb3246f-2331-0cd0-d589-19324787fb16@linux.vnet.ibm.com> In-Reply-To: <7bb3246f-2331-0cd0-d589-19324787fb16@linux.vnet.ibm.com> From: David Marchand Date: Thu, 19 Mar 2020 09:10:54 +0100 Message-ID: To: David Christensen Cc: dev , David Wilder , "Burakov, Anatoly" , Jerin Jacob Kollanukkaran X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] pci: fix unneeded includes in public header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Mar 16, 2020 at 8:08 PM David Christensen wrote: > On 3/16/20 10:49 AM, David Christensen wrote: > > > >> The rte_pci.h file includes more header files than are actually needed= , > >> which means that all users of it also include those headers. This patc= h > >> removes the unneeded headers - adding them elsewhere where other > >> components > >> were requiring them but not including them directly. > >> > >> Fixes: c752998b5e2e ("pci: introduce library and driver") > >> Cc: gaetan.rivet@6wind.com > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Bruce Richardson > > > > Patch is generating build errors with meson on my POWER system, though = I > > don't see how they're POWER specific: > > There's a pending patch to enable Travis for POWER systems: > > http://patches.dpdk.org/patch/65986/ > > Any reason it hasn't been accepted yet? Looks like it would have caught > this problem. The reason is that this series has a change in the IOVA detection code. I have a lot of things to look at, so any help in reviews is appreciated. --=20 David Marchand