From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73A5343C38; Tue, 5 Mar 2024 14:28:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3230141148; Tue, 5 Mar 2024 14:28:30 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 798DA40270 for ; Tue, 5 Mar 2024 14:28:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709645308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1BnOYXt1hmrfMVdgXcvshoi4C9RVfx+EY2j6gMMOMyU=; b=JxmnsBuXYCJEaHrN1DPkDuiflcd7THM440eVrjpM7L5M7hgIdchX8cK/RTkQcIK4KFKQPm 7p1N+JeU0oT4z2paWjCtuNWFPZy3p9nzxjkjL8gE8mJACLsPnlbN8AkUq5A0mkDObaDSyG gf2PmoOpz0/wjfkg02MLon0lwkONXJQ= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-131-W__Nr5zuOIqijLTiZ2QE3g-1; Tue, 05 Mar 2024 08:28:27 -0500 X-MC-Unique: W__Nr5zuOIqijLTiZ2QE3g-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5131eb8137aso4813059e87.3 for ; Tue, 05 Mar 2024 05:28:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709645305; x=1710250105; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1BnOYXt1hmrfMVdgXcvshoi4C9RVfx+EY2j6gMMOMyU=; b=SLjf8839LXJzm+eI52TJvZMhWQUVN0IVvTKRwbrHZCxFTHa1977oe5vUORA0I4we+9 26SPVfGmO88igXNmUdT79sp8xjF3oR42KqxlSVG5+m4tbjcg0eCO5cjVh0+px5I9K0Zm sSSp/q+K8jND2zoZLTdj80O1p/Tx2I6I2TW3gmE2T/yoIRcAVvtOnN3orPai9ScRmJNv uEp5BbgDJyC+kghxKFiP8XyeRv3ZGOpjkfGw1PmBKBgOf788P6ItyJExoWVo76C7zT7h T4UdPhmOqHwakAAQ1nrbAqJR6fvqZW/70gyMAnQy+14KhXV0PXzOtcf9CoYKxGzvWS4J EBiw== X-Gm-Message-State: AOJu0Yz9O+P2cdW2dH4myYihTuDalGAUw/xXp2iTLSAWFi0KBKtkelwo Ql3/EDCBeG/LbQWKEXyIhKpTq+vyU3p6j2T6qd2R4b8B6M2dOcWyZ+kJsaco3ish9lZjc/oL9ve bAVaPBCtrid54B+M2rZ0IPDIQVGyPpGw/9HUJ+Sv5zQy78260b+kXUpVuv+ViOtn999IO/AhXY8 nd7Q15+ZdtluphJVBwQEihkQA= X-Received: by 2002:a05:6512:39cd:b0:513:46cc:8966 with SMTP id k13-20020a05651239cd00b0051346cc8966mr1802539lfu.2.1709645304832; Tue, 05 Mar 2024 05:28:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IEc8XLEElItqgnvVJiY42Jn/trqn9SLgHu10gaKZWff9CWNuJAN2YjDkrUiioUL7JyObiCbnjVCHKaAQE25x8k= X-Received: by 2002:a05:6512:39cd:b0:513:46cc:8966 with SMTP id k13-20020a05651239cd00b0051346cc8966mr1802517lfu.2.1709645304491; Tue, 05 Mar 2024 05:28:24 -0800 (PST) MIME-Version: 1.0 References: <20240305091326.2697724-1-david.marchand@redhat.com> In-Reply-To: <20240305091326.2697724-1-david.marchand@redhat.com> From: David Marchand Date: Tue, 5 Mar 2024 14:28:13 +0100 Message-ID: Subject: Re: [PATCH] vhost: fix vring addr update with vDPA To: dev@dpdk.org Cc: ssimma@nvidia.com, Maxime Coquelin , Chenbo Xia , Eelco Chaudron X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 5, 2024 at 10:13=E2=80=AFAM David Marchand wrote: > > For vDPA devices, vq are not locked once the device has been configured > at runtime. > > On the other hand, we need to hold the vq lock to evaluate vq->access_ok, > invalidate vring addresses and translate them. > > Move vring address update earlier and, when vDPA is configured, skip part= s > which expect lock to be taken. > > Bugzilla ID: 1394 > Fixes: 741dc052eaf9 ("vhost: annotate virtqueue access checks") > > Signed-off-by: David Marchand Recheck-request: iol-testing --=20 David Marchand