From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6090A09D3; Thu, 12 Nov 2020 09:58:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 34618593A; Thu, 12 Nov 2020 09:58:07 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id C40DF4CA6 for ; Thu, 12 Nov 2020 09:58:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605171483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=StiiJQhz0gthsv5C7A7FFdosriZls7mKFW13MASY9UY=; b=OUFxAutpHKcjRT4z27V8kHyZez5A/PHNx3LpYk6r4UoX9z6Nq8W8BwL0NBXbs+44kFjWmu 1E68r0fgz3E0tGoj5dFj0WG8dVcr4eLZKMXnLVe3dsJIKyW5VZqFsDT1QWwdKCkrudM/lH 73AP8vx57AwERCpG0Qru6wWXv0EsGUQ= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-397-etuSBIpGNHSwj2aF7HW2cw-1; Thu, 12 Nov 2020 03:57:59 -0500 X-MC-Unique: etuSBIpGNHSwj2aF7HW2cw-1 Received: by mail-vs1-f71.google.com with SMTP id f23so1493473vsh.7 for ; Thu, 12 Nov 2020 00:57:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=StiiJQhz0gthsv5C7A7FFdosriZls7mKFW13MASY9UY=; b=cEiv3O5yUScW923cxeihGsdbPODje42l7Nm+unwhsF2CtO43ERzP6fkeoDdyWw5zwZ wwCzsMSIEIHZnPLFTtlkMUu+NSbnhZWberNHN3EcWM4211sUVuRRovUef560xkwpyqFr Yuc+cILFN/2rVPPH5DOhomMXF2isdrjY+g3r/wbZcwC0Bh7/aHQE0GREAeBWM/nIqm/v Jdca0PCXP8Nr3Ghh6gTv8mAZYA8Td+udmiXxrRU3VvSytLE+gktGLsztY8Yv4RNl1wg9 vNveviRzPbPWAauJpjxuhNl0XFy5hchoDuzPnK41WLNPE2Gm8IBmZTMQFl4ezk7volOO Hq1A== X-Gm-Message-State: AOAM533B/4MGUbF1FOPYXtpIVl4WDGH5TpHiTndulK4a0BcAP5OtHKkE ZleDu8HliaH8NbznqzOsAVjut21zu7z+M7yNnYVYQqIelzyIwgGhI6781+4bJNG+KO6LgIl7e2+ MIDWy6aQK1V/LaMamRbo= X-Received: by 2002:a67:f8c5:: with SMTP id c5mr18835436vsp.18.1605171478920; Thu, 12 Nov 2020 00:57:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJy5YBKa4NRLfbzeX7xerGgM2inJ+qhWNTKRi0M+UR9z7YKMbTv0neelM272QQSHDsNL1cKvzszwvn71i4ahtYE= X-Received: by 2002:a67:f8c5:: with SMTP id c5mr18835430vsp.18.1605171478692; Thu, 12 Nov 2020 00:57:58 -0800 (PST) MIME-Version: 1.0 References: <20201111154007.13426-1-yong.liu@intel.com> In-Reply-To: From: David Marchand Date: Thu, 12 Nov 2020 09:57:47 +0100 Message-ID: To: Marvin Liu , Maxime Coquelin Cc: "Xia, Chenbo" , dev , "Richardson, Bruce" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/virtio: enable packet data prefetch on x86 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 12, 2020 at 9:48 AM Maxime Coquelin wrote: > On 11/11/20 4:40 PM, Marvin Liu wrote: > > Data prefetch instruction can preload data into cpu=E2=80=99s hierarchi= cal > > cache before data access. Virtio datapath utilized this feature for > > data access acceleration. As config RTE_PMD_PACKET_PREFETCH was > > discarded, now packet data prefetch is enabled based on architecture. > > > > Signed-off-by: Marvin Liu > > > > diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqu= eue.h > > index 42c4c9882..0196290a5 100644 > > --- a/drivers/net/virtio/virtqueue.h > > +++ b/drivers/net/virtio/virtqueue.h > > @@ -106,7 +106,7 @@ virtqueue_store_flags_packed(struct vring_packed_de= sc *dp, > > dp->flags =3D flags; > > } > > } > > -#ifdef RTE_PMD_PACKET_PREFETCH > > +#if defined(RTE_ARCH_X86) > > #define rte_packet_prefetch(p) rte_prefetch1(p) > > #else > > #define rte_packet_prefetch(p) do {} while(0) > > > > Thanks for catching this issue. > I agree it should be re-enabled by default, and not only on X86, not > only on Virtio PMD. > > AFAICS, prefetch was enabled for all platforms before the switch to > Meson, so I see it as an involuntary change that needs to be reverted. Yes and this will also solve https://patchwork.dpdk.org/patch/83468/. Thanks. --=20 David Marchand