From: David Marchand <david.marchand@redhat.com>
To: Conor Walsh <conor.walsh@intel.com>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
"Ruifeng Wang (Arm Technology China)" <ruifeng.wang@arm.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
dev <dev@dpdk.org>,
paulis.gributs@intel.com
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: remove useless reloads in FIB main loop
Date: Tue, 6 Jul 2021 13:29:37 +0200 [thread overview]
Message-ID: <CAJFAV8zxiLQj0O2hw=hcnQ15bEFg5hbZ6P4tomqyjmCMOfTncQ@mail.gmail.com> (raw)
In-Reply-To: <20210705170546.1002806-1-conor.walsh@intel.com>
On Mon, Jul 5, 2021 at 7:06 PM Conor Walsh <conor.walsh@intel.com> wrote:
>
> This patch aligns the l3fwd FIB code with the changes made to LPM in
> commit 74fb854a3de6 ("examples/l3fwd: remove useless reloads in LPM
> main loop").
> This change ensures the compiler knows that the lcore config variables
> are constant values and the compiler will then optimize the code
> accordingly.
em can undergo the same change too.
Can you send a followup patch and I would take them both for rc1?
Thanks.
>
> Signed-off-by: Conor Walsh <conor.walsh@intel.com>
--
David Marchand
next prev parent reply other threads:[~2021-07-06 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 17:05 Conor Walsh
2021-07-05 17:32 ` Ananyev, Konstantin
2021-07-06 1:38 ` Ruifeng Wang
2021-07-06 11:29 ` David Marchand [this message]
2021-07-06 11:55 ` Walsh, Conor
2021-07-07 9:57 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zxiLQj0O2hw=hcnQ15bEFg5hbZ6P4tomqyjmCMOfTncQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=conor.walsh@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=paulis.gributs@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).