From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96F82A04C9; Mon, 14 Sep 2020 10:37:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 089171C0CD; Mon, 14 Sep 2020 10:37:05 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id A3B921BE95 for ; Mon, 14 Sep 2020 10:37:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600072623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8JNO8UL35miS6pz6Nn+V62QPu07JkZFwRMYmfp5SEA4=; b=i93nXruOxRHnIpN5FeCiF/Il88GFzga5mFktTQVBiDKeIX7y/Xl1e91tAtAD9QLjnAllVZ 2tjxStZl98fi0CeGkPkxuvfPGSzKRaqm+CwDiThdNqn7rjegr0/dDM8ljt80qpwUwj6Pqs szoVI/IZPLw6o5+ow8ro97qbpch7Gi4= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-448-ygw3xGoFPdqJyf8a9iyhng-1; Mon, 14 Sep 2020 04:37:00 -0400 X-MC-Unique: ygw3xGoFPdqJyf8a9iyhng-1 Received: by mail-ua1-f69.google.com with SMTP id y6so1276477uay.15 for ; Mon, 14 Sep 2020 01:37:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8JNO8UL35miS6pz6Nn+V62QPu07JkZFwRMYmfp5SEA4=; b=Pk9jH8SoPRGncqfdrgEcJ45IpsMNRcGM7U+OB3GDCwH2fVrkI0byl1VJbFlrnzlmqL lxsuLu2v+xCZWjzyX4x6pNsYBN3eNXFYGYp9E8YJIKpKXoq5Dril66YmqCNKXp97q3aX t+I05XdZOfkqKnyBuGMFXxVJcL4zAxRdEZbKZVoJkz99L/xvF7Mvbg8l5VTtF7N8u+dw QcUbfwX9U8YyFw0zt093+y5XibT+/zSZvGIz0IurKhUzZndjw8aMpQ3of1Mk7SU9KltI CYlkv6rYWI4fe3kKoCnhDoe86EwCFPm0r7jBjsBMwSwJQ/Muy3PvA1bYHABxUiXVBxmx WnXg== X-Gm-Message-State: AOAM533PwtpEy6vvcEW6E7YtkPNkG9h3sjhrFSgpUFrZDKvREiENIjeE WPKcZ3EnvnLFaBfM/FB/2b3ry+AqAYLKZiX6ePLXwWg7BUf7fadVowJchYbY6rLuQw3/2QH2hCM lqvAclifjfQjzzpVA8IY= X-Received: by 2002:a05:6102:204b:: with SMTP id q11mr6610174vsr.40.1600072619820; Mon, 14 Sep 2020 01:36:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzqpN9Znu/0SHY12mD2eT5m1xnZrBuwmobrux5wo1ln/1JL456Ua2FKnY+FQjNXtERros/o/8jAo2Jklgo3dxs= X-Received: by 2002:a05:6102:204b:: with SMTP id q11mr6610165vsr.40.1600072619599; Mon, 14 Sep 2020 01:36:59 -0700 (PDT) MIME-Version: 1.0 References: <20200724124503.96282-1-harry.van.haaren@intel.com> <20200724134506.11959-1-harry.van.haaren@intel.com> <20200724134506.11959-2-harry.van.haaren@intel.com> In-Reply-To: <20200724134506.11959-2-harry.van.haaren@intel.com> From: David Marchand Date: Mon, 14 Sep 2020 10:36:48 +0200 Message-ID: To: Harry van Haaren Cc: dev , Igor Romanov , Honnappa Nagarahalli , "Yigit, Ferruh" , nd , Aaron Conole , Lukasz Wojciechowski , Phil Yang Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0.003 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 2/2] test/service: fix race condition on stopping lcore X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jul 24, 2020 at 3:44 PM Harry van Haaren wrote: > > This commit fixes a potential race condition in the tests > where the lcore running a service would increment a counter > that was already reset by the test-suite thread. The resulting > race-condition incremented value could cause CI failures, as > indicated by DPDK's CI. > > This patch fixes the race-condition by making use of the > added rte_service_lcore_active() API, which indicates when > a service-core is no longer in the service-core polling loop. > > The unit test makes use of the above function to detect when > all statistics increments are done in the service-core thread, > and then the unit test continues finalizing and checking state. > > Fixes: f28f3594ded2 ("service: add attribute API") > > Reported-by: David Marchand > Signed-off-by: Harry van Haaren > Reviewed-by: Phil Yang > Reviewed-by: Honnappa Nagarahalli There is still a compilation issue reported by the Intel CI. http://mails.dpdk.org/archives/test-report/2020-July/146535.html Please fix. -- David Marchand