From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 16CD42B89 for ; Thu, 2 May 2019 14:32:53 +0200 (CEST) Received: by mail-vs1-f68.google.com with SMTP id j184so1223219vsd.11 for ; Thu, 02 May 2019 05:32:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t/OGxO/CU38BLdSYp6D05tDNMWLEJ8Cq38n+NCKUB7E=; b=rvA+AOuK68WL+UyNM+0wInuJma+/LDGJr6901AvDGhLKXBq0dwfts3TdIoumg7k6WT 5Ew33oKnjvWMsrj54ZwkYc2bX8qrbsrVRQ360QII8iV5YZIFalvDWRAz80cVRLtKcXZd 1ma3SjD6vh2SYPiPk57w660J7PDAWvGXDIV0pGBaKmmSXoJBYn/Jv6Ml22TnMqH43pvz 4/xtZjGm3qjx4Q6+0V9mTyVkfBzKJT6DN7/Gee8gEYu5hchBAE0C/lTpuxfauCOA7I8i o+MYbi9WMdUgLlpOKSsAo5Exo3OlfcHX44L01qmjdaVXFkg3ww4mv0fOO1ygm0gLm0Dq MJ9w== X-Gm-Message-State: APjAAAVrT9TPOd+F/n2/sPSY6FsCnIWHmjfMJWb6DZO3ovdf45Ol8lFR W8/h0h4s2VwiRQAHt4rrIm9hwJoosJmVN5AfSK2QBQ== X-Google-Smtp-Source: APXvYqwvpvh4Q2HAvWkcIRQq0qA/vmXUCz/u3v4ld7r+BqwraSa4vQXb8t2k9WFkqfQZAGPACV3mYLxPp3Yh9IYhd4g= X-Received: by 2002:a67:fa95:: with SMTP id f21mr1748747vsq.180.1556800372498; Thu, 02 May 2019 05:32:52 -0700 (PDT) MIME-Version: 1.0 References: <20190501195014.2938-1-bruce.richardson@intel.com> <8175150.iIoqqa2Iee@xps> In-Reply-To: <8175150.iIoqqa2Iee@xps> From: David Marchand Date: Thu, 2 May 2019 14:32:41 +0200 Message-ID: To: Thomas Monjalon Cc: Bruce Richardson , dev , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 May 2019 12:32:53 -0000 On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon wrote: > 01/05/2019 21:50, Bruce Richardson: > > This set of changes fixes warnings seen when compiling DPDK on Fedora 30. > > In most cases these warnings appear to be false positives, which means we > > have the option to just disable the warning. Because the changes required > > to the code to silence the warnings are fairly small I've chosen in all > cases > > to change the code rather than disable the warnings, but I'm open to > doing > > the opposite if it's felt it's a better solution. [One thing I didn't > like > > about disabling the warnings is that the disabling flags are not > supported > > by clang, so adding them involves compiler checks :-(] > > > > NOTE: this set does not cover all warnings with GCC9, but it does cover > > those seen when building with meson. There is still one warning disable > > flag needed when building with make, which will need a follow-on set to > > fix. > > > > Bruce Richardson (4): > > net/ixgbe: fix warning with GCC 9 on Fedora 30 > > bus/fslmc: fix printf of null pointer > > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30 > > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30 > > Cc: stable@dpdk.org > > Applied, thanks > > I had a comment on patch 2, and the bigger problem is -Waddress-of-packed-member. The quicker solution for now is to downgrade it to warning only so that we can fix the parts later rather than globally disable it. -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id CD5D4A0AC5 for ; Thu, 2 May 2019 14:32:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2377D5B26; Thu, 2 May 2019 14:32:54 +0200 (CEST) Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 16CD42B89 for ; Thu, 2 May 2019 14:32:53 +0200 (CEST) Received: by mail-vs1-f68.google.com with SMTP id j184so1223219vsd.11 for ; Thu, 02 May 2019 05:32:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t/OGxO/CU38BLdSYp6D05tDNMWLEJ8Cq38n+NCKUB7E=; b=rvA+AOuK68WL+UyNM+0wInuJma+/LDGJr6901AvDGhLKXBq0dwfts3TdIoumg7k6WT 5Ew33oKnjvWMsrj54ZwkYc2bX8qrbsrVRQ360QII8iV5YZIFalvDWRAz80cVRLtKcXZd 1ma3SjD6vh2SYPiPk57w660J7PDAWvGXDIV0pGBaKmmSXoJBYn/Jv6Ml22TnMqH43pvz 4/xtZjGm3qjx4Q6+0V9mTyVkfBzKJT6DN7/Gee8gEYu5hchBAE0C/lTpuxfauCOA7I8i o+MYbi9WMdUgLlpOKSsAo5Exo3OlfcHX44L01qmjdaVXFkg3ww4mv0fOO1ygm0gLm0Dq MJ9w== X-Gm-Message-State: APjAAAVrT9TPOd+F/n2/sPSY6FsCnIWHmjfMJWb6DZO3ovdf45Ol8lFR W8/h0h4s2VwiRQAHt4rrIm9hwJoosJmVN5AfSK2QBQ== X-Google-Smtp-Source: APXvYqwvpvh4Q2HAvWkcIRQq0qA/vmXUCz/u3v4ld7r+BqwraSa4vQXb8t2k9WFkqfQZAGPACV3mYLxPp3Yh9IYhd4g= X-Received: by 2002:a67:fa95:: with SMTP id f21mr1748747vsq.180.1556800372498; Thu, 02 May 2019 05:32:52 -0700 (PDT) MIME-Version: 1.0 References: <20190501195014.2938-1-bruce.richardson@intel.com> <8175150.iIoqqa2Iee@xps> In-Reply-To: <8175150.iIoqqa2Iee@xps> From: David Marchand Date: Thu, 2 May 2019 14:32:41 +0200 Message-ID: To: Thomas Monjalon Cc: Bruce Richardson , dev , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502123241.nJCN1ZMFkY83PNwOg4-amj-r4cber6OJfLv_9cYxPTI@z> On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon wrote: > 01/05/2019 21:50, Bruce Richardson: > > This set of changes fixes warnings seen when compiling DPDK on Fedora 30. > > In most cases these warnings appear to be false positives, which means we > > have the option to just disable the warning. Because the changes required > > to the code to silence the warnings are fairly small I've chosen in all > cases > > to change the code rather than disable the warnings, but I'm open to > doing > > the opposite if it's felt it's a better solution. [One thing I didn't > like > > about disabling the warnings is that the disabling flags are not > supported > > by clang, so adding them involves compiler checks :-(] > > > > NOTE: this set does not cover all warnings with GCC9, but it does cover > > those seen when building with meson. There is still one warning disable > > flag needed when building with make, which will need a follow-on set to > > fix. > > > > Bruce Richardson (4): > > net/ixgbe: fix warning with GCC 9 on Fedora 30 > > bus/fslmc: fix printf of null pointer > > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30 > > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30 > > Cc: stable@dpdk.org > > Applied, thanks > > I had a comment on patch 2, and the bigger problem is -Waddress-of-packed-member. The quicker solution for now is to downgrade it to warning only so that we can fix the parts later rather than globally disable it. -- David Marchand