DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Zhichao Zeng <zhichaox.zeng@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org,
	 Jaroslaw Ilgiewicz <jaroslaw.ilgiewicz@intel.com>,
	Ian Stokes <ian.stokes@intel.com>,
	 Bruce Richardson <bruce.richardson@intel.com>,
	 Midde Ajijur Rehaman <ajijurx.rehaman.midde@intel.com>,
	 Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [PATCH] net/i40e/base: fix the debug print format
Date: Tue, 14 Jan 2025 14:14:31 +0100	[thread overview]
Message-ID: <CAJFAV8zyPGZmq_pCyEuXZ0OOsuuV7J9=bd6HgRNUqH+9SoZfSw@mail.gmail.com> (raw)
In-Reply-To: <20250114100010.207536-1-zhichaox.zeng@intel.com>

On Tue, Jan 14, 2025 at 10:44 AM Zhichao Zeng <zhichaox.zeng@intel.com> wrote:
>
> This patch modifies format specifier in debug prints to match to the
> change of time variables from 64 bit to 32 bit.

I am missing something... this is reverting a valid change.

If anything needs to be changed.. PRIu32 should be used in the four
hunks this patch touches.

>
> Fixes: d980a401b137 ("net/i40e/base: add NVM acquire with custom timeout")
> Fixes: ba90329a5eb3 ("net/i40e/base: fix invalid log format characters")

And in this case, I think you want to point at:
Fixes: cb593a832630 ("net/i40e/base: reduce size of time variables")

> Cc: stable@dpdk.org
>
> Signed-off-by: Jaroslaw Ilgiewicz <jaroslaw.ilgiewicz@intel.com>
> Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>


-- 
David Marchand


  reply	other threads:[~2025-01-14 13:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-14 10:00 Zhichao Zeng
2025-01-14 13:14 ` David Marchand [this message]
2025-01-15  2:26   ` Zeng, ZhichaoX
2025-01-15  7:44 ` [PATCH v2] " Jaroslaw Ilgiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8zyPGZmq_pCyEuXZ0OOsuuV7J9=bd6HgRNUqH+9SoZfSw@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=ajijurx.rehaman.midde@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ian.stokes@intel.com \
    --cc=jaroslaw.ilgiewicz@intel.com \
    --cc=stable@dpdk.org \
    --cc=zhichaox.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).