From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) by dpdk.org (Postfix) with ESMTP id E25034CA7 for ; Wed, 10 Apr 2019 10:26:39 +0200 (CEST) Received: by mail-vs1-f45.google.com with SMTP id d8so874673vsp.2 for ; Wed, 10 Apr 2019 01:26:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/Or8PrttJZQt2WNLLqCb7u+/Ii3WYAWPHide1Ip7qbI=; b=XLIKELVPpGB+pqhROOxZZDobKILz05pSFByx+fJO4UqA8hUxyiR8uidGM2/aqg0nl3 rjjAaZufaLr5NkTTxfww0UAyApIOrSb2pLos9ygiyX5dBCw3v9U2KOMrb/ib0mr9uIvn iYcxnZrlC8nv72pjfDOnQtsQ1kk2pNacF9AT2oU+tj6aRbL5TGKrYyOGBwVwe/1B1t1h T0fU90naXKoHw0pgvAbURQEQ6RNEI384yUWoDVN/E12TrIodCXbegimhaJSfHdhdrnNK dfaJFfcHJmXA1znrrrVJOfwTG7YD2yF0crcmIxHw08EwRNa9zUC0BiEi/siy0B+9Z4jO poEQ== X-Gm-Message-State: APjAAAXYRXlMh10smgxy9GFchcDu5nHETzgGm1LG8Zw48BLG94J5fb8n GJRB6s21xj7wWALVoE0gpaE+OuRgttPtIBoXgIaSww== X-Google-Smtp-Source: APXvYqxr8G9dt+HBNBJgbTfPucktlKbHuXlfAlKlmndEhSCzF2v8jY6Jz4xUQPm26TBQXE0cnItnfe6GDgdZO/LkTTQ= X-Received: by 2002:a67:f588:: with SMTP id i8mr19748944vso.91.1554884799135; Wed, 10 Apr 2019 01:26:39 -0700 (PDT) MIME-Version: 1.0 References: <20190410072532.17182-1-vattunuru@marvell.com> In-Reply-To: <20190410072532.17182-1-vattunuru@marvell.com> From: David Marchand Date: Wed, 10 Apr 2019 10:26:28 +0200 Message-ID: To: Vamsi Attunuru Cc: dev , Michael Santana , Aaron Conole Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v1 1/1] app/test: fix --socket-mem option in eal flag autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2019 08:26:40 -0000 On Wed, Apr 10, 2019 at 9:26 AM Vamsi Attunuru wrote: > "argv2[]" positive test case fails with RTE_MAX_NUMA_NODES=1 config > because of "--socket-mem=0,0,0,0" option, which passes memory sizes > for multiple sockets. This patch fixes the issue by passing memory > size for node 0 alone. > How about modifying the test so that it also validates the format is consistent with the RTE_MAX_NUMA_NODES value ? -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BC1A8A0096 for ; Wed, 10 Apr 2019 10:26:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 530D74CA9; Wed, 10 Apr 2019 10:26:41 +0200 (CEST) Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) by dpdk.org (Postfix) with ESMTP id E25034CA7 for ; Wed, 10 Apr 2019 10:26:39 +0200 (CEST) Received: by mail-vs1-f45.google.com with SMTP id d8so874673vsp.2 for ; Wed, 10 Apr 2019 01:26:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/Or8PrttJZQt2WNLLqCb7u+/Ii3WYAWPHide1Ip7qbI=; b=XLIKELVPpGB+pqhROOxZZDobKILz05pSFByx+fJO4UqA8hUxyiR8uidGM2/aqg0nl3 rjjAaZufaLr5NkTTxfww0UAyApIOrSb2pLos9ygiyX5dBCw3v9U2KOMrb/ib0mr9uIvn iYcxnZrlC8nv72pjfDOnQtsQ1kk2pNacF9AT2oU+tj6aRbL5TGKrYyOGBwVwe/1B1t1h T0fU90naXKoHw0pgvAbURQEQ6RNEI384yUWoDVN/E12TrIodCXbegimhaJSfHdhdrnNK dfaJFfcHJmXA1znrrrVJOfwTG7YD2yF0crcmIxHw08EwRNa9zUC0BiEi/siy0B+9Z4jO poEQ== X-Gm-Message-State: APjAAAXYRXlMh10smgxy9GFchcDu5nHETzgGm1LG8Zw48BLG94J5fb8n GJRB6s21xj7wWALVoE0gpaE+OuRgttPtIBoXgIaSww== X-Google-Smtp-Source: APXvYqxr8G9dt+HBNBJgbTfPucktlKbHuXlfAlKlmndEhSCzF2v8jY6Jz4xUQPm26TBQXE0cnItnfe6GDgdZO/LkTTQ= X-Received: by 2002:a67:f588:: with SMTP id i8mr19748944vso.91.1554884799135; Wed, 10 Apr 2019 01:26:39 -0700 (PDT) MIME-Version: 1.0 References: <20190410072532.17182-1-vattunuru@marvell.com> In-Reply-To: <20190410072532.17182-1-vattunuru@marvell.com> From: David Marchand Date: Wed, 10 Apr 2019 10:26:28 +0200 Message-ID: To: Vamsi Attunuru Cc: dev , Michael Santana , Aaron Conole Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v1 1/1] app/test: fix --socket-mem option in eal flag autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190410082628.GFLS45TgxdhyV2YH66VmaRpRSOdAALVzdP1wESEKPZk@z> On Wed, Apr 10, 2019 at 9:26 AM Vamsi Attunuru wrote: > "argv2[]" positive test case fails with RTE_MAX_NUMA_NODES=1 config > because of "--socket-mem=0,0,0,0" option, which passes memory sizes > for multiple sockets. This patch fixes the issue by passing memory > size for node 0 alone. > How about modifying the test so that it also validates the format is consistent with the RTE_MAX_NUMA_NODES value ? -- David Marchand