From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36860A052A; Tue, 26 Jan 2021 13:50:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3381141488; Tue, 26 Jan 2021 13:50:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 209D4141481 for ; Tue, 26 Jan 2021 13:50:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611665454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=07CCdBmSi/l0oXUsY2UpkdPgSgMC2CunigcIRMZ0jm0=; b=BsSkHRN9CD1NpK84Bde2FK89iHte7nFTLB4Ym1gapqjJM+QtVyzWM9PT07xP+sGLPKWY4l QiLvRqU3J/iRGZCC+geHzl1fg7xuvUOemRsk2kwxGJILAwA/r8tBUN+aMlMOHg9AsEApaU baafpknZl1ezL20vMSWUIxU90u/tcHs= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-298-LvEeNmL9PxSEf_N7laWemw-1; Tue, 26 Jan 2021 07:50:52 -0500 X-MC-Unique: LvEeNmL9PxSEf_N7laWemw-1 Received: by mail-ua1-f69.google.com with SMTP id z4so6109095uan.8 for ; Tue, 26 Jan 2021 04:50:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=07CCdBmSi/l0oXUsY2UpkdPgSgMC2CunigcIRMZ0jm0=; b=dLZWQbSpVeVWAy/4qj2esKNOssFOyku2hBwziIcg6EdVoIMvuHGyrjvGuRDPkicp9d /Hv41dOMImofFlO7Bn+YR+3PS6kN6m0Ww3xHbbGWs0A/MbIL7yEzsEKVwJTCE5XQb7YH Fs5FNsSaKe4hu0+DlkF/X7z/UaWgUSWI1TTu/1V4SHBI3M7GjLuwD+PrUb5/noKMkNK4 jVQKg25FIMjPc62VuCJsGfSzX4iHSWSm/8sKzZzfonWu+HRBYpCmN0ovH8H0jJXApNBT m25dzcodQ1zmFmCYVS76V21igxTcBzIusI1z9mMqxCtqDPkZvn0D0Ss02hTRxUzEZTmC 2Qjg== X-Gm-Message-State: AOAM533JRISbWCi8ZD9AOL7/HTcxbndkgm+Ivy3s1h6XIOax4GI4/42M 4cffb6B6w+6cwHaCgBWy/kkSGJmIncy9GUFM5UK247MzodY7LH/p9szCun0x8GlacCOWcL2eH6c wmbH24Seu0g9yH00Uhhg= X-Received: by 2002:a1f:cec1:: with SMTP id e184mr3994146vkg.17.1611665452136; Tue, 26 Jan 2021 04:50:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJwUUOoa6ILuHpLoY092ahkOKj7PIcET1Ia6RG+WQEi8GLHy4727XuRZYSVNZivJN8Sg5xN/+Fi3i6mEE1pNTLk= X-Received: by 2002:a1f:cec1:: with SMTP id e184mr3994141vkg.17.1611665451916; Tue, 26 Jan 2021 04:50:51 -0800 (PST) MIME-Version: 1.0 References: <20210126101639.250481-1-maxime.coquelin@redhat.com> <20210126101639.250481-3-maxime.coquelin@redhat.com> In-Reply-To: <20210126101639.250481-3-maxime.coquelin@redhat.com> From: David Marchand Date: Tue, 26 Jan 2021 13:50:41 +0100 Message-ID: To: Maxime Coquelin , Ray Kinsella Cc: dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 02/44] bus/vdev: add driver IOVA VA mode requirement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 26, 2021 at 11:16 AM Maxime Coquelin wrote: > > This patch adds driver flag in vdev bus driver so that > vdev drivers can require VA IOVA mode to be used, which > for example the case of Virtio-user PMD. > > The patch implements the .get_iommu_class() callback, that > is called before devices probing to determine the IOVA mode > to be used, and adds a check right before the device is > probed to ensure compatible IOVA mode has been selected. > > It also adds a ABI exception rule to accommodate with an > update on the driver registration API > > Signed-off-by: Maxime Coquelin > Signed-off-by: David Marchand > --- > devtools/libabigail.abignore | 2 ++ > drivers/bus/vdev/rte_bus_vdev.h | 4 ++++ > drivers/bus/vdev/vdev.c | 29 +++++++++++++++++++++++++++++ > 3 files changed, 35 insertions(+) > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > index 1dc84fa74b..170304c876 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -11,6 +11,8 @@ > ; Explicit ignore for driver-only ABI > [suppress_type] > name = eth_dev_ops > +[suppress_function] > + name_regexp = rte_vdev_(|un)register > > ; Ignore fields inserted in cacheline boundary of rte_cryptodev > [suppress_type] Ray, Are you okay with this exception? Thanks. -- David Marchand