From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAAB7A0C47; Tue, 5 Oct 2021 12:04:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC4394129A; Tue, 5 Oct 2021 12:04:44 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 8C23A41262 for ; Tue, 5 Oct 2021 12:04:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633428282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8n108x1bVCWrmNgAJmM+fm8dRGyDGjCHCBaDCGXWpAA=; b=DmI+GXo2h40RSFkPetPbKrNhd7zKbLqosFQxRzvLf2OtrZP8g44rDOuPpoLUNrprYghk3Y hmsDEowi1YPrRL7HajWujqcK/bYfqonIHGh9j1QjHOxt8/vE726RLpm5OHS5bBkqcvz+6o Wciz4xtFaz7/5aTxK0A2DMYT5LYwHBU= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-213-9DvbssUAONenFZdvfpzwsA-1; Tue, 05 Oct 2021 06:04:39 -0400 X-MC-Unique: 9DvbssUAONenFZdvfpzwsA-1 Received: by mail-lf1-f69.google.com with SMTP id r14-20020ac25c0e000000b003fc149ed50eso16478043lfp.11 for ; Tue, 05 Oct 2021 03:04:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8n108x1bVCWrmNgAJmM+fm8dRGyDGjCHCBaDCGXWpAA=; b=LMYKKaEZninDRABdT7awUON4iZpA6n5FOz13UyBSnk042Bw69xmEc9+0pdi2GvPf2x +OKjF55j8epPp3E+6TCrkTdJpM/cQtz8YSaaxn2nskpi4GCtKR2qqUPGXZotPaIRAz5X mrnXLYFvVd9Tq4bMXehvSqfGXNpJ4DcgRcA+YtpexP+TMYjfh0g6gF4gWBlNuSkIEtpN cZeRjzu6EjDhCGNrIXX9ERSVtkdnayossij5ZFCArtiPJHwq8F37PVEPWddhWxi5LwDR x82mdO7/gpQDwfIOvoWOipq1BWEWQriK9PEwHFMayS9LX6Zcs/07yZTh8Hr2rO5d31Gr EInw== X-Gm-Message-State: AOAM532FsC6uwXJwheOGuuLiK/XbPw1MtNxG4d7IDq+RP6WeEGGGDxOo Je7sd1SI21I6+SL7QAx8nnsy06b7Uzd4oPc40vIF8enmi497AoCgW/oc9NCn34TrtNFx1MLGLIg IwPFQsFtsJuiieZNdVHc= X-Received: by 2002:a2e:8584:: with SMTP id b4mr22156188lji.477.1633428277676; Tue, 05 Oct 2021 03:04:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHt7eewna+CptzQ95TAExAn5vLdYiIjzpwKj6vQ88wD5LPLBOaTO9pc3VjaREZgPkck0+qhfn2BtluS9mKzig= X-Received: by 2002:a2e:8584:: with SMTP id b4mr22156143lji.477.1633428277445; Tue, 05 Oct 2021 03:04:37 -0700 (PDT) MIME-Version: 1.0 References: <20211001140255.5726-1-konstantin.ananyev@intel.com> <20211004135603.20593-1-konstantin.ananyev@intel.com> <20211004135603.20593-8-konstantin.ananyev@intel.com> In-Reply-To: <20211004135603.20593-8-konstantin.ananyev@intel.com> From: David Marchand Date: Tue, 5 Oct 2021 12:04:26 +0200 Message-ID: To: Konstantin Ananyev Cc: dev , Xiaoyun Li , Anoob Joseph , Jerin Jacob Kollanukkaran , Nithin Dabilpuram , Ankur Dwivedi , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Ajit Khaparde , Somnath Kotur , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , "Wang, Haiyue" , John Daley , Hyong Youb Kim , Qi Zhang , Xiao Wang , "humin (Q)" , Yisen Zhuang , oulijun , Beilei Xing , Jingjing Wu , Qiming Yang , Matan Azrad , Slava Ovsiienko , Stephen Hemminger , Long Li , heinrich.kuhn@corigine.com, Kiran Kumar Kokkilagadda , Andrew Rybchenko , Maciej Czekaj , Jiawen Wu , Jian Wang , Maxime Coquelin , "Xia, Chenbo" , Thomas Monjalon , "Yigit, Ferruh" , Ray Kinsella , "Jayatheerthan, Jay" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 7/7] ethdev: hide eth dev related structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 4, 2021 at 3:59 PM Konstantin Ananyev wrote: > > Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related > data into private header (ethdev_driver.h). > Few minor changes to keep DPDK building after that. This change is going to hurt a lot of people :-). But this is a necessary move. $ git grep-all -lw rte_eth_devices |grep -v \\.patch$ ANS/ans/ans_main.c BESS/core/drivers/pmd.cc dma_ip_drivers/QDMA/DPDK/drivers/net/qdma/qdma_xdebug.c dma_ip_drivers/QDMA/DPDK/drivers/net/qdma/rte_pmd_qdma.c dma_ip_drivers/QDMA/DPDK/examples/qdma_testapp/pcierw.c dma_ip_drivers/QDMA/DPDK/examples/qdma_testapp/testapp.c FD.io-VPP/src/plugins/dpdk/device/format.c lagopus/src/dataplane/dpdk/dpdk_io.c OVS/lib/netdev-dpdk.c packet-journey/app/kni.c pktgen-dpdk/app/pktgen-port-cfg.c pktgen-dpdk/app/pktgen-port-cfg.h pktgen-dpdk/app/pktgen-stats.c Trex/src/dpdk_funcs.c Trex/src/drivers/trex_i40e_fdir.c Trex/src/drivers/trex_ixgbe_fdir.c TungstenFabric-vRouter/gdb/vr_dpdk.gdb I did not check all projects for their uses of rte_eth_devices, but I did the job for OVS. If you have cycles to review... https://patchwork.ozlabs.org/project/openvswitch/patch/20210907082343.16370-1-david.marchand@redhat.com/ One nit: > > Signed-off-by: Konstantin Ananyev > --- > doc/guides/rel_notes/release_21_11.rst | 6 + > drivers/common/octeontx2/otx2_sec_idev.c | 2 +- > drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 2 +- > drivers/net/cxgbe/base/adapter.h | 2 +- > drivers/net/dpaa2/dpaa2_ptp.c | 2 +- > drivers/net/netvsc/hn_var.h | 1 + > lib/ethdev/ethdev_driver.h | 149 ++++++++++++++++++ > lib/ethdev/rte_ethdev_core.h | 143 ----------------- > lib/ethdev/version.map | 2 +- > lib/eventdev/rte_event_eth_rx_adapter.c | 2 +- > lib/eventdev/rte_event_eth_tx_adapter.c | 2 +- > lib/eventdev/rte_eventdev.c | 2 +- > lib/metrics/rte_metrics_telemetry.c | 2 +- > 13 files changed, 165 insertions(+), 152 deletions(-) > > diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst > index 6055551443..2944149943 100644 > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guides/rel_notes/release_21_11.rst > @@ -228,6 +228,12 @@ ABI Changes > to user, it still counts as an ABI change, as ``eth_rx_queue_count_t`` > is used by public inline function ``rte_eth_rx_queue_count``. > > +* ethdev: Made ``rte_eth_dev``, ``rte_eth_dev_data``, ``rte_eth_rxtx_callback`` > + private data structures. ``rte_eth_devices[]`` can't be accessible directly accessed* > + by user any more. While it is an ABI breakage, this change is intended > + to be transparent for both users (no changes in user app is required) and > + PMD developers (no changes in PMD is required). > + > > Known Issues > ------------ -- David Marchand