DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Michael Baum <michaelba@nvidia.com>
Cc: dev <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>,
	 Raslan Darawsheh <rasland@nvidia.com>,
	dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx4: fix device detach
Date: Thu, 14 Jan 2021 11:41:17 +0100
Message-ID: <CAJFAV8zyxbHNAjJxNRhem=WXtRkDC_7bq0RHxOL8NHmeik7qYg@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8z2+n5AWT83qhUXDizOKOV0UjvB=0x2816Ka3YL1BvCbA@mail.gmail.com>

On Thu, Jan 14, 2021 at 9:32 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Wed, Jan 13, 2021 at 5:29 PM Michael Baum <michaelba@nvidia.com> wrote:
> >
> > When mlx4 device is probed, 2 different ethdev ports may be created for
> > the 2 physical ports of the device.
> >
> > Wrongly, when the device is removed, the created ports are not released.
> >
> > Close and release the ethdev ports in remove process.
> >
>
> Missing a reference to bug 488.
>
> > Fixes: 7fae69eeff13 ("mlx4: new poll mode driver")
>
> Odd that it never worked, but if Matan acked, I guess this is ok.
>
> > Cc: stable@dpdk.org
> >
> > Reported-by: David Marchand <david.marchand@redhat.com>
> > Signed-off-by: Michael Baum <michaelba@nvidia.com>
> > Acked-by: Matan Azrad <matan@nvidia.com>

Forgot to add my tag..
Tested-by: David Marchand <david.marchand@redhat.com>

Thanks for fixing.


-- 
David Marchand


  reply	other threads:[~2021-01-14 10:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13 16:28 [dpdk-dev] [PATCH 0/2] net/mlx4: fix PCI probe and remove functions Michael Baum
2021-01-13 16:28 ` [dpdk-dev] [PATCH 1/2] net/mlx4: fix device detach Michael Baum
2021-01-14  8:32   ` David Marchand
2021-01-14 10:41     ` David Marchand [this message]
2021-01-20  8:14   ` [dpdk-dev] [PATCH v2 0/2] net/mlx4: fix PCI probe and remove functions Michael Baum
2021-01-20  8:14     ` [dpdk-dev] [PATCH v2 1/2] net/mlx4: fix device detach Michael Baum
2021-01-20  8:14     ` [dpdk-dev] [PATCH v2 2/2] net/mlx4: fix PCI probe error flow Michael Baum
2021-01-21 13:45     ` [dpdk-dev] [PATCH v2 0/2] net/mlx4: fix PCI probe and remove functions Raslan Darawsheh
2021-01-13 16:28 ` [dpdk-dev] [PATCH 2/2] net/mlx4: fix PCI probe error flow Michael Baum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8zyxbHNAjJxNRhem=WXtRkDC_7bq0RHxOL8NHmeik7qYg@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=michaelba@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git