From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DD08A0A02; Thu, 14 Jan 2021 11:41:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A720F1410F2; Thu, 14 Jan 2021 11:41:31 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id B84651410F1 for ; Thu, 14 Jan 2021 11:41:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610620890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GDoLWkFiUnsNMjC9+wXxeYvbZWBz9Ph4YG3GVey4g2c=; b=SIzlexWsgZxmzzkcxhKfLT8BqzdmRjVbCsvYsWOHg7n14pfbj3E7+HMgC3aEdxKNI2USnf fVuP7M88M5Q/7bD8PL0/HzzIZjpX/to2jDOSn2cq2lGi1gPxz+YIZ1PAT+q9bUX3AdE1U5 IqU0EkGL9MyR3yIv0nqGtxt2qNUykKw= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-264-J4iMnLm7Pa-fzVqcIlg7IA-1; Thu, 14 Jan 2021 05:41:28 -0500 X-MC-Unique: J4iMnLm7Pa-fzVqcIlg7IA-1 Received: by mail-vk1-f198.google.com with SMTP id c69so2165221vke.14 for ; Thu, 14 Jan 2021 02:41:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GDoLWkFiUnsNMjC9+wXxeYvbZWBz9Ph4YG3GVey4g2c=; b=XX/d5kJGUTQl4HqsO11jE1SzAcxthPlHYjChbQKJdafUXsjK2S5k052uLNiPKjfvm/ q/WE4c8ii5W9yI90VbTOdmsk0Bx31mXRvWzmT+JZR7jZrovov22pdynmVsWQBusIKBHu d47KoBFHEG1LvNVuK0Z9XH1sj1h0aaIPYB+/nCAHgsdD/TZtmmiSjnJoQedLrRLLnSnU 2CbwpMUZ8/+fcIxW7KnSxk1Tkm2c+Ql9wq0jzkArX7HeFfEzw6Zz/s58kM95MhbohAC9 wuzv5xUXNmzJc64u/SRnazfQ4le/sHy2eEshPSY/CSGyCLf/s6iDrc9E5gOEEQ1UC9GD Qseg== X-Gm-Message-State: AOAM530lavBqbz8iMlqxznwPfVyWaADTaXVoejAHDh4izPnv9WYD0ow9 +9QK+ykuXUNlGXX2oIF6fuqXRHFHELF0hkmjz7wm7/GhwA1ZnANfWVGGRme7CpQEbWHQZ3SrOFc EUYn5Jp/OgrkLiQS+iaw= X-Received: by 2002:a05:6102:21cd:: with SMTP id r13mr5856268vsg.5.1610620888356; Thu, 14 Jan 2021 02:41:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQXwTqgXQmCgyDzlnxsJEaopFg4mXfgsZtWxma0/8r7UJ+leCLAOwyxl9ZBM2kEc54SStD7V8EeNy/6z2odVs= X-Received: by 2002:a05:6102:21cd:: with SMTP id r13mr5856255vsg.5.1610620888132; Thu, 14 Jan 2021 02:41:28 -0800 (PST) MIME-Version: 1.0 References: <1610555333-18961-1-git-send-email-michaelba@nvidia.com> <1610555333-18961-2-git-send-email-michaelba@nvidia.com> In-Reply-To: From: David Marchand Date: Thu, 14 Jan 2021 11:41:17 +0100 Message-ID: To: Michael Baum Cc: dev , Matan Azrad , Raslan Darawsheh , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx4: fix device detach X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 14, 2021 at 9:32 AM David Marchand wrote: > > On Wed, Jan 13, 2021 at 5:29 PM Michael Baum wrote: > > > > When mlx4 device is probed, 2 different ethdev ports may be created for > > the 2 physical ports of the device. > > > > Wrongly, when the device is removed, the created ports are not released. > > > > Close and release the ethdev ports in remove process. > > > > Missing a reference to bug 488. > > > Fixes: 7fae69eeff13 ("mlx4: new poll mode driver") > > Odd that it never worked, but if Matan acked, I guess this is ok. > > > Cc: stable@dpdk.org > > > > Reported-by: David Marchand > > Signed-off-by: Michael Baum > > Acked-by: Matan Azrad Forgot to add my tag.. Tested-by: David Marchand Thanks for fixing. -- David Marchand