From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mk@semihalf.com>
Received: from mail-ua0-f193.google.com (mail-ua0-f193.google.com
 [209.85.217.193]) by dpdk.org (Postfix) with ESMTP id 3B6091D968
 for <dev@dpdk.org>; Mon, 11 Jun 2018 08:24:44 +0200 (CEST)
Received: by mail-ua0-f193.google.com with SMTP id s13-v6so9325111uad.2
 for <dev@dpdk.org>; Sun, 10 Jun 2018 23:24:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=semihalf-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=43TZyYtQdi1u3zPV3vbd5uvjFID3R4VJ9ke2zmH/Apk=;
 b=pJozDSHL44hRT1r4GpE329Ptsp5pRQ0KeXVs5rCbPNXPmeD4o2CrtgZVKplZyiL5rv
 b1S9T8TAa1fFb+/sVG/+StGxFxifdhHTPJ7hcSpAlXQZ0rKHXIUIkZAifIRKH99sZMW1
 QzzCRowbY64uJP0kbt02QrPc5sl31uCy9FzzgRCZmTvOF/suj4hrT0f3Ajnh3FBFUF1f
 N618o0INFZCgM7o8p7n8P9h6+A9BU/RwyJ6OfswRNjkjVfsufxFce41y2fGk9ejv58v1
 dhlKmeh+wRCPVUB+bVF9dY5vOF3/ULIWG5f/YDz82opgrZdaj2nauru29nAR4slmjL+m
 bMiA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=43TZyYtQdi1u3zPV3vbd5uvjFID3R4VJ9ke2zmH/Apk=;
 b=G9Owtq2nCFpetF8t2evojur6Svp4SR9LqicIBQGvbReUHjxu/vGbOg6GT8FBU+vMIL
 IQKve8xwMnjFViDl59nWOEa4FhRbVhCccHrPcAzg1eWtOJMctKkSJNAKolfixaT574kS
 FPfMH7KHBoeIHPJ+UGLdTiBpRYswQSpTGpcTHSM0Zyso5/Zm0pThTYOPO6158ST+om5o
 82KuZJVksMzS/xcG0NfXnD75kHVcCUnMo1N0lDfakoSKiEiZjR2ZLYkfRX7bO18OsYhY
 dmN/3rUPv0TXuHGRHmtvseZ2adZIW4+UiGA30vJ7m+3JlbbE4fzB7sQ3KhVRZb0REIrX
 jlYQ==
X-Gm-Message-State: APt69E0XEtzC5sOgA7vl02xvJKnIqSBgCeM4RBi5aivtt2I90ZVsjUeY
 iicQGcX88xULQoPK7E/TtnMkvaAqnzM8tHWL8j1+Ag==
X-Google-Smtp-Source: ADUXVKKtOC8ESbbGt4IZo/bky3B3cgTN8o80aLdGV+BYnjTOjeynTMBGH2c9XZFI46CrYJ/6LudxL2ljdDgt+zvPhvE=
X-Received: by 2002:ab0:1b22:: with SMTP id
 d34-v6mr10506777uai.176.1528698283620; 
 Sun, 10 Jun 2018 23:24:43 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a67:62c7:0:0:0:0:0 with HTTP; Sun, 10 Jun 2018 23:24:43
 -0700 (PDT)
In-Reply-To: <c9926ff9-a04d-be8c-e88b-347fb541d536@intel.com>
References: <20180607094322.14312-1-mk@semihalf.com>
 <20180607094322.14312-10-mk@semihalf.com>
 <c9926ff9-a04d-be8c-e88b-347fb541d536@intel.com>
From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= <mk@semihalf.com>
Date: Mon, 11 Jun 2018 08:24:43 +0200
Message-ID: <CAJMMOfMp8o-Ze=VkA3-ym=DYyoKjdoEa7EPQN4Bb7SzeL-ZZrQ@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Marcin Wojtas <mw@semihalf.com>, Guy Tzalik <gtzalik@amazon.com>, 
 Evgeny Schemeilin <evgenys@amazon.com>, Thomas Monjalon <thomas@monjalon.net>,
 dev@dpdk.org, "Matushevsky, Alexander" <matua@amazon.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v3 10/27] net/ena: add lrte_timer dependency
 for linking
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jun 2018 06:24:44 -0000

2018-06-08 21:17 GMT+02:00 Ferruh Yigit <ferruh.yigit@intel.com>:
> On 6/7/2018 10:43 AM, Michal Krawczyk wrote:
>> ENA PMD is required to use librte_timer. The appropriate depndency must
>> be added ifin case the DPDK will be built as shared library.
>>
>> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
>> ---
>>  drivers/net/ena/Makefile | 1 +
>>  mk/rte.app.mk            | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile
>> index 43339f3b9..ff9ce315b 100644
>> --- a/drivers/net/ena/Makefile
>> +++ b/drivers/net/ena/Makefile
>> @@ -58,5 +58,6 @@ CFLAGS += $(INCLUDES)
>>  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
>>  LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
>>  LDLIBS += -lrte_bus_pci
>> +LDLIBS += -lrte_timer
>>
>>  include $(RTE_SDK)/mk/rte.lib.mk
>> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
>> index 1e32c83e7..c70bc254e 100644
>> --- a/mk/rte.app.mk
>> +++ b/mk/rte.app.mk
>> @@ -60,6 +60,7 @@ endif
>>
>>  _LDLIBS-y += --whole-archive
>>
>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          += -lrte_timer
>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_CFGFILE)        += -lrte_cfgfile
>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_HASH)           += -lrte_hash
>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMBER)         += -lrte_member
>
> Instead of being separate patch, this should be part of the patch that starts
> using rte_timer library.
> I guess that is next patch (11/27), if you confirm I can squash this to next
> patch while merging.
>

Ok, that's fine to squash it with that patch.