From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4644A046B; Thu, 9 Jan 2020 16:26:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E3461DE89; Thu, 9 Jan 2020 16:26:47 +0100 (CET) Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by dpdk.org (Postfix) with ESMTP id 484681DE79 for ; Thu, 9 Jan 2020 16:26:45 +0100 (CET) Received: by mail-ed1-f66.google.com with SMTP id c26so5914642eds.8 for ; Thu, 09 Jan 2020 07:26:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+oKEa1RP6Ygo+G9Cz5+XEUxIAozNRloF6Ipa5SykPZ8=; b=1DrtoATWSQZC2E8mZtyjxRpDAGWSeMxml1KCi9/hOyKGqu4+Erb8mKNc79giDpvSJQ oU5K5g3L6MQi/jwuzTWh7TXOo2C5azCv2v9Scweck9gV2Y9UXKUnsM7STSFw2QTUlJP4 kAri6jKVyqYPMcv1NkSaXmrwW9F2eA/dtvmLsqufFn3O5B8fM20mPfp+F/qd9ZIbuLex qRQx/TZMNPp5Zl5o79xejD9U/SZdMacVq3bQqVhWZxEcNqAsDKD9lBk2WtTO7cZjioxP 6jz6P/rgA3ijRILwD9BurPnTfvM0PKU6SDQqufEUBtYaEjDhuMq9gbgHnmNM5Uivv2nI bRqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+oKEa1RP6Ygo+G9Cz5+XEUxIAozNRloF6Ipa5SykPZ8=; b=SqjncM1D7l712GXdPxqh743yIzQDlx5plYwAktex6NrH9HjCMBfjyA1J5aJGoMQ5J/ kv5yGyTeSCYV+wJLJ9KUdW46EdjAdVvhNZyDsH8WufDBQspxYh8c1OozK56jMZ8gT0Is YclfDceTb/vCVt3Vtv+8dtqDdPuquoaO/JEdjuVY1AjL1gduoKOFPVYInLTYiChy1pG2 WdI8Hbf4akLJpetbau+PadulYZXhp0Fj+R0poS91/Q9IpMxR1IJvL+mt23QTTJQ1AQQZ t1C2RuI64U/+JI0fLhNGMaa48aPODmGTqd+PQFzjF4sAILSQ+H/8j+00EWQQAehPVYBv Zcmg== X-Gm-Message-State: APjAAAWkGs4M9pFKZ/pCbEkh/TcTUPEc7gJmg/sdjQw33T5CUNaRT4j8 yPYq3kv6QiW59ucDJeUYvYBUroMWPUYyZ4XRB22NR4d+gHk= X-Google-Smtp-Source: APXvYqynwBCtKRl9Ag8AbBrDzLA7zfZxjS2ikeuH9HSLx9fMlrSpar6EGXSZPbME0olHym3G+9sgXfiB0kwAvpK966o= X-Received: by 2002:a17:906:c78b:: with SMTP id cw11mr11334835ejb.262.1578583604933; Thu, 09 Jan 2020 07:26:44 -0800 (PST) MIME-Version: 1.0 References: <20191213133216.23572-1-mk@semihalf.com> <20191213133216.23572-2-mk@semihalf.com> <20191213083420.31f2b7c8@hermes.lan> <54235c88-57e1-bb2e-4067-c39a47e9d7f6@intel.com> In-Reply-To: <54235c88-57e1-bb2e-4067-c39a47e9d7f6@intel.com> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Thu, 9 Jan 2020 16:26:33 +0100 Message-ID: To: Ferruh Yigit Cc: Stephen Hemminger , dev@dpdk.org, "Tzalik, Guy" , Marcin Wojtas , "Matushevsky, Alexander" , mba , "Chauskin, Igor" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/2] net/ena: upgrade HAL for new HW features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" czw., 9 sty 2020 o 15:27 Ferruh Yigit napisa=C5=82= (a): > > On 12/13/2019 8:01 PM, Micha=C5=82 Krawczyk wrote: > > pt., 13 gru 2019 o 17:34 Stephen Hemminger > > napisa=C5=82(a): > >> > >> On Fri, 13 Dec 2019 14:32:15 +0100 > >> Michal Krawczyk wrote: > >> > >>> This version of the HAL allows to use the latest HW features, like > >>> rx offsets. > >>> > >>> Driver was adjusted to the new version to fix the build. > >>> > >>> Signed-off-by: Michal Krawczyk > >>> Signed-off-by: Maciej Bielski > >> > >> You are mixing multiple changes into one patch. > >> This makes it harder to review (find the real bits) and also > >> harder for bisection. > >> > >> It makes sense to fix whitespace and related stuff in one > >> patch if you are fixing one function and the nearby code > >> already needed work. But please avoid larger scale change > >> put together. > >> > >> In your patch I see: > >> - remove unnecessary whitespace > >> - drop unnecessary inline > >> - add missing newline in log messages > >> - check for NULL pointer > >> > >> If possible could you preserve the per-commit updates for base > >> code, rather than one lump diff. > > > > Hi Stephen, > > > > We are not developing HAL (ena_com) on our own. We are getting it from = the > > Amazon team and we don't have history of it's development. Tha's why we= are > > upstreaming a diff between two versions of the ena_com. > > > > Moreover this HAL is common for Linux kernel driver, FreeBSD kernel dri= ver > > and Windows kernel driver. Because of that, we are trying to avoid to > > modify it on our side unless it's really necessary (for example, if > > compilation fails on for the DPDK). > > Hi Micha=C5=82, > > Overall this is the common situation for most of the base code, that is w= hy we > are a little more flexible on them and not enforcing the coding conventio= n etc.. > > But as a high level rule, still please try to split the base code drop to > logical pieces as much as possible, and I am aware that this requires add= itional > effort. > I will proceed with this patchset, but please bare in mind this for next = time. > Hi Ferruh, Sure, I will keep that in mind and during next release I will try to split = it. Thanks, Michal