From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8779FA0562; Fri, 3 Apr 2020 13:31:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AAA061BFEF; Fri, 3 Apr 2020 13:31:56 +0200 (CEST) Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by dpdk.org (Postfix) with ESMTP id AFF521BFDC for ; Fri, 3 Apr 2020 13:31:55 +0200 (CEST) Received: by mail-ed1-f68.google.com with SMTP id w26so8859298edu.7 for ; Fri, 03 Apr 2020 04:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=YLEfVCmjNELcKSMk3FJKqiV2UV0XgtVhJAm8/p6N334=; b=N1qMbxFB5QGS7zG4IW94z0Ot/evghVNpxPYP0N9/9m6J3Er6nNjVakYwP0NG3wMfhj fJoNXigxMtIMOlDDqoj9QIovdlXcbrjVqY/mLYsl7K+ydTyBHIgFs9DxBqL9vLnWCJAX cHYmZOv3O153YB8JZ6cANOg0jP8ERlVkkVQIr8MtvSGjFzZeKeSohR/2CtQkQDY7Kuvd bTTEgyovlISYcj/JL/B6FoXQw12iDv7DimMZxAYMqtVEzVwUwP5ozqrIqCRVX14nQWSz Ep71DyNp2g0OB2mj+S68GpJOvHysKp+7ATB8koEZi8YD8dtx4VTWIjKyMTjWqom6ili6 lhpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YLEfVCmjNELcKSMk3FJKqiV2UV0XgtVhJAm8/p6N334=; b=o1wOxh5KJoVTDMFMG/qAy/5wCQm+9CYlWiFNpqxEXZcup8t8MnCxAJm++w5i1cQG3x Kblwqv1SHXfZcYcOMY7oOxnmvH+N8BhdlmNpw+/HIg8c7cnNPVr9QEbxyfHgiWOsWwbu Vzdvb0cXSuD0uy/5noUV0+HV2NCCmXWbIhNCTgYqh6u/Kn6fOMkAcqMqn3Rp8f4cE4Ca OfiTnTx4KnL1Di/yee+PYOPrB3izLhy1YrE7eE/TyPWHi/NYfOqTkG2Lr5G8kTxLU2zL asVG3R4SFVIUZa9KS97GxZrzpND/II0RW+gawHQA+zUBEb3MaMGSwHKiAw+rb3k4HCAx Uugg== X-Gm-Message-State: AGi0PuZBF3FyTFgnJoYklZJjW58WrPEjKQv4FFzBMN1mtiO6LH2Fyks2 YfMY+gJpjDx3uSzVgq1mxAZKSE3DVcUV8RFcSpkIFw== X-Google-Smtp-Source: APiQypJ8JrNv8vsYLyQNaVX0GFWLEAZ0pOa1bZAeW3Hku5gyie2Eaz8AlBann5nmt1lrHW0Notfu2DCXYFgUHVRP4Eg= X-Received: by 2002:a17:906:b802:: with SMTP id dv2mr8099902ejb.92.1585913515368; Fri, 03 Apr 2020 04:31:55 -0700 (PDT) MIME-Version: 1.0 References: <20200401142127.13715-1-mk@semihalf.com> <20200401142127.13715-11-mk@semihalf.com> <076d48e7-436a-aeaa-f436-5beab02c1e9d@intel.com> In-Reply-To: <076d48e7-436a-aeaa-f436-5beab02c1e9d@intel.com> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Fri, 3 Apr 2020 13:31:43 +0200 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Marcin Wojtas , Maciej Bielski , "Tzalik, Guy" , "Schmeilin, Evgeny" , "Chauskin, Igor" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 10/29] net/ena/base: add error logs when preparing Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" czw., 2 kwi 2020 o 14:53 Ferruh Yigit napisa=C5=82= (a): > > On 4/1/2020 3:21 PM, Michal Krawczyk wrote: > > To make the debugging easier, the error logs were added in the Tx path. > > > > Signed-off-by: Michal Krawczyk > > Reviewed-by: Igor Chauskin > > Reviewed-by: Guy Tzalik > > --- > > drivers/net/ena/base/ena_eth_com.c | 24 +++++++++++++++++++----- > > 1 file changed, 19 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/net/ena/base/ena_eth_com.c b/drivers/net/ena/base/= ena_eth_com.c > > index aabc294fb7..747450fec5 100644 > > --- a/drivers/net/ena/base/ena_eth_com.c > > +++ b/drivers/net/ena/base/ena_eth_com.c > > @@ -148,8 +148,10 @@ static int ena_com_close_bounce_buffer(struct ena_= com_io_sq *io_sq) > > if (pkt_ctrl->idx) { > > rc =3D ena_com_write_bounce_buffer_to_dev(io_sq, > > pkt_ctrl->curr_bo= unce_buf); > > - if (unlikely(rc)) > > + if (unlikely(rc)) { > > + ena_trc_err("failed to write bounce buffer to dev= ice\n"); > > Is 'ena_trc_err()' for datapath? > ena_trc_err() is being used in both control and datapath. > DPDK has two types of logs, > - for control path, dynamic logging, whose logging level can be dynamical= ly changed > - for data path, a compile time controlled logging, this is to prevent > performance loss in data path. For ena these flags are > CONFIG_RTE_LIBRTE_ENA_DEBUG_RX=3Dn > CONFIG_RTE_LIBRTE_ENA_DEBUG_TX=3Dn > CONFIG_RTE_LIBRTE_ENA_DEBUG_TX_FREE=3Dn > > > I can see ena also has 'RTE_LIBRTE_ENA_COM_DEBUG' compile to flag, which > controls above 'ena_trc_err' variants. If this is control path, what do y= ou > think removing the compile time flag and convert these 'COM' logs to dyna= mic > logging? I agree with you that it would be great if we would use dynamic logging for control path - I must talk with engineers responsible for ena_com to raise that issue and, hopefully, it'll be possible to adjust that in the future. I suggest to postpone that kind of change for the next release, as making ena_com changes is a bit time consuming.