Re: [dpdk-dev] [PATCH v3 22/22] net/ena: update version to v2.3.0

["Michał Krawczyk" <mk@semihalf.com>]

pt., 7 maj 2021 o 18:50 Ferruh Yigit <ferruh.yigit@intel.com> napisał(a):
>
> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> > This version update contains:
> >   * memcpy mapping to the dpdk-optimized version.
> >   * ena_com (HAL) update to the latest version.
> >   * Bug fixes for the large LLQ headers and devargs parsing.
> >   * Mbuf RSS hash presence indication.
> >   * Bug fix for the default ring size.
> >   * Various fixes for SMP mode (although ENA is not fully MP aware, yet).
> >
>
> There is another patch (09/22) updates "update generation date and commit", not
> sure what it is but it looks like base code generation date, does it make sense
> to squash that patch to this one?
>

In general I try to avoid mixing ena_com (HAL) and core driver commits
whenever it's possible. But it could make sense to squash them, as
they're interconnected. I will change that in the v4.

The 09/22 patch (with the generation date) helps to identify the exact
HAL version which is used for the current driver as it may vary
depending on the platform and is used for the debugging purposes.

> > Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> > ---
> > v3:
> > * Fix typo in the commit log (double "the")
> >
> >  doc/guides/rel_notes/release_21_05.rst | 13 +++++++++++++
> >  drivers/net/ena/ena_ethdev.c           |  4 ++--
> >  2 files changed, 15 insertions(+), 2 deletions(-)
> >
> > diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst
> > index 30dec1c1d1..8cf9afa050 100644
> > --- a/doc/guides/rel_notes/release_21_05.rst
> > +++ b/doc/guides/rel_notes/release_21_05.rst
> > @@ -287,6 +287,19 @@ New Features
> >    * Added support for crypto adapter forward mode in octeontx2 event and crypto
> >      device driver.
> >
> > +* **Updated Amazon ENA PMD.**
> > +
> > +  The new driver version (v2.3.0) introduces bug fixes and improvements,
> > +  including:
> > +
> > +  * Changed memcpy mapping to the dpdk-optimized version.
> > +  * Updated ena_com (HAL) to the latest version.
> > +  * Fixed bugs when requesting large LLQ headers using the devargs.
> > +  * Added indication of the RSS hash presence in the mbuf.
> > +  * Fixed bug when the default ring size was set.
> > +  * Add multiple fixes for the SMP mode (although ENA is not fully MP aware,
> > +    yet).
> > +
> >
>
> Instead of a separate patch for release updates, can you please distribute the
> items here to the patch that introduces it?
>
> >  Removed Items
> >  -------------
> > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
> > index c5d8e7d43e..e1e086f31e 100644
> > --- a/drivers/net/ena/ena_ethdev.c
> > +++ b/drivers/net/ena/ena_ethdev.c
> > @@ -27,8 +27,8 @@
> >  #include <ena_eth_io_defs.h>
> >
> >  #define DRV_MODULE_VER_MAJOR 2
> > -#define DRV_MODULE_VER_MINOR 2
> > -#define DRV_MODULE_VER_SUBMINOR      1
> > +#define DRV_MODULE_VER_MINOR 3
> > +#define DRV_MODULE_VER_SUBMINOR      0
> >
> >  #define ENA_IO_TXQ_IDX(q)    (2 * (q))
> >  #define ENA_IO_RXQ_IDX(q)    (2 * (q) + 1)
> >
>