Re: [dpdk-dev] [PATCH v2 4/5] net/ena: fix Tx sq free space assessment

["Michał Krawczyk" <mk@semihalf.com>]

pt., 29 sty 2021 o 13:07 Ferruh Yigit <ferruh.yigit@intel.com> napisał(a):
>
> On 1/26/2021 6:32 PM, Michal Krawczyk wrote:
> > From: Igor Chauskin <igorch@amazon.com>
> >
> > Before starting transmission of Tx burst, the driver checked the
> > available space in the sq and limited the number of packets for
> > transmission accordingly.
> > The calculation was incorrect for fragmented packets and potentially had
> > significantly limited the length of Tx bursts.
> >
> > This patch removes the assessment and pushes packets to the sq as long
> > as the burst is not exhausted and space is available in the sq.
> >
> > Correct evaluation of the required space isn't possible before the burst
> > because it depends on the number of segments of each packet.
> > This patch adds per-packet space evaluation for each packet before
> > attempting to process it. In case there is not enough queue space, the
> > burst will just stop without error.
> >
> > Signed-off-by: Igor Chauskin <igorch@amazon.com>
> > Reviewed-by: Michal Krawczyk <mk@semihalf.com>
>
> Hi Michal, Igor,
>
> Can you please provide fixes line for the patch, and I assume you want it to be
> backported?
>

Hi Ferruh,

thanks for the note! I'll update missing fixlines in v3 for both patch 4 and 5.

Thanks,
Michal