From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB0B1A0C4B; Wed, 14 Jul 2021 12:02:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A9314014E; Wed, 14 Jul 2021 12:02:45 +0200 (CEST) Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by mails.dpdk.org (Postfix) with ESMTP id D0EDD40140 for ; Wed, 14 Jul 2021 12:02:43 +0200 (CEST) Received: by mail-il1-f178.google.com with SMTP id a11so1003526ilf.2 for ; Wed, 14 Jul 2021 03:02:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=YM45/5fpIOXMlWesnvdBMm0npKQZpzAY799JOfJLp6w=; b=aZFwbkZcl/wjGE2hGQ98aLUOU6ukBNCAtHdR+rXztY5YxI9zaqSCnhtPxWV2gmhFLF Asx0zMO22ytuInv2Fc57rFmyir5xfPNKMFGmpwv6vFNAVFuOy9mTbNfwNDDQeryLO7aQ J4e2Gu+w1nDo88oKhFDlh5I+jXQ/u3bkjybZNW+GQAsgWt2d1gsVcXbbr4a5VCFH+teQ KALDr96Eqvs+Jjovwh+bX5dQWYOecotURpAXyFIiNCXdJYTA8dqyG6Mo4EzMxHrNsu6c Uuey+AcjIfVRIYI/v2nud03c7nvygb93AJV+JAb2s0o9duySExe08jf9lq/SrOBJK98a TdmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YM45/5fpIOXMlWesnvdBMm0npKQZpzAY799JOfJLp6w=; b=fklr5xR4sFw0oJTeojmdpGHj0aHtogGrzK2x/yFsTGqJNvaO1peMXvAtxQirLlBYQ6 hI54MydWgDG8ezaKYo4AJyW0qwUAZbICv5dPNqjrTENhOQDwpQnc3mVSfNUaevrBTtPD EczM0uQArLckxbsBAkXsbUXqdOlA8diz3vnBWkxEaEweWVJiYc7V8q8LeawGApPi701/ xjOF+wYEt4+Ms8+vLmzyGALMgVaQnsSR+ZXweaLaALf4ldGt/yburpCQ6MM+vA8l7ACX V0cUClQK0gAGkbubNEKjGL4ESovgwYqN3HB3MCHSbV7AW3n06hDyGdb5lucwBwdrE3jw Uhsw== X-Gm-Message-State: AOAM532XYY88c6H4a1TGgdv1biBgeMrylqzrUFUjnFCz+c1Orr/qKvAH 4AP3kBr43b5Y3Efxp3bYCNzjciZ8jHfWwevKiA0xTQ== X-Google-Smtp-Source: ABdhPJz0KSzY1FItpmeMApNPygaNHqYSZP+GW9KczOnlsVEMSNyqOuIO+ClNGDekOUJdcsGy3mT0ySdhv27WL51k18Y= X-Received: by 2002:a05:6e02:12e1:: with SMTP id l1mr6062547iln.0.1626256963205; Wed, 14 Jul 2021 03:02:43 -0700 (PDT) MIME-Version: 1.0 References: <20210712170153.11508-1-ghalem.boudour@6wind.com> In-Reply-To: <20210712170153.11508-1-ghalem.boudour@6wind.com> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Wed, 14 Jul 2021 12:02:32 +0200 Message-ID: To: Ghalem Boudour Cc: Marcin Wojtas , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , dev , Olivier Matz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/ena: enable multi segment in Tx offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" pon., 12 lip 2021 o 19:03 Ghalem Boudour napisa= =C5=82(a): > > The DPDK ENA driver does not provide multi-segment tx offload capability. > Let's add DEV_TX_OFFLOAD_MULTI_SEGS to ports offload capability by defaul= t. > Hi Ghalem, This patch enables announcement of the DEV_TX_OFFLOAD_MULTI_SEGS capability, but still the application may not request this offload. As ENA PMD currently assumes all the mbufs may have multiple segments (and we don't have fast-path for the other cases), I suggest overwriting this flag in the ena_dev_configure(), similar to what we're doing with the DEV_RX_OFFLOAD_RSS_HASH flag. Best regards, Michal > This flag in not listed in doc/guides/nics/features/default.ini, so > ena.ini does not need to be updated. > > Signed-off-by: Ghalem Boudour > Reviewed-by: Olivier Matz > --- > drivers/net/ena/ena_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index dfe68279fa7b..a8422ee425ce 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -2055,6 +2055,7 @@ static int ena_infos_get(struct rte_eth_dev *dev, > DEV_RX_OFFLOAD_TCP_CKSUM; > > rx_feat |=3D DEV_RX_OFFLOAD_JUMBO_FRAME; > + tx_feat |=3D DEV_TX_OFFLOAD_MULTI_SEGS; > > /* Inform framework about available features */ > dev_info->rx_offload_capa =3D rx_feat; > -- > 2.28.0 >