Re: [dpdk-dev] [PATCH 17/29] net/ena: add support for large LLQ headers

["Michał Krawczyk" <mk@semihalf.com>]

pt., 27 mar 2020 o 12:21 Andrew Rybchenko <arybchenko@solarflare.com>
napisał(a):
>
> On 3/27/20 1:18 PM, Michal Krawczyk wrote:
> > If the device supports larger LLQ (Low Latency Queue) headers, the user
> > can activate them by enabling CONFIG_RTE_LIBRTE_ENA_LARGE_LLQ_HEADERS
> > flag in the configuration file.
> >
> > If the device isn't supporting this feature, the default value will be
> > used.
> >
> > Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> > Reviewed-by: Igor Chauskin <igorch@amazon.com>
> > Reviewed-by: Guy Tzalik <gtzalik@amazon.com>
> > ---
> >  config/common_base           |  1 +
> >  doc/guides/nics/ena.rst      |  5 +++++
> >  drivers/net/ena/ena_ethdev.c | 33 ++++++++++++++++++++++++++++++---
> >  3 files changed, 36 insertions(+), 3 deletions(-)
> >
> > diff --git a/config/common_base b/config/common_base
> > index c31175f9d6..31f508b3cc 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -266,6 +266,7 @@ CONFIG_RTE_LIBRTE_ENA_DEBUG_RX=n
> >  CONFIG_RTE_LIBRTE_ENA_DEBUG_TX=n
> >  CONFIG_RTE_LIBRTE_ENA_DEBUG_TX_FREE=n
> >  CONFIG_RTE_LIBRTE_ENA_COM_DEBUG=n
> > +CONFIG_RTE_LIBRTE_ENA_LARGE_LLQ_HEADERS=n
>
> Consider to use device arguments (run-time) to control it.
> Build time is bad and you have no it in meson build.
> As far as I can see it is control path only and should
> not be a problem at all.

Thanks for the advice - I'll change that in the v2 version (it is
going to be upstreamed soon).