From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A03C9A0562; Tue, 31 Mar 2020 11:42:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7517E1BFC5; Tue, 31 Mar 2020 11:42:40 +0200 (CEST) Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by dpdk.org (Postfix) with ESMTP id 44F482BCE for ; Tue, 31 Mar 2020 11:42:39 +0200 (CEST) Received: by mail-ed1-f67.google.com with SMTP id v1so24295289edq.8 for ; Tue, 31 Mar 2020 02:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=bC2RWtbJdiWfsI/W6RoPeZSH9+/IhUPiZ9pynr15AaE=; b=e66ORMIfCQ5QSkVHHUPUP5k0cvoolf/tLUgSBXMk85NvX2DHBbh4LMvWvn2Kk3NrHG WpjvZGD62qjIAs3ruJfYkSewEpeksresTGoe1FF/Yjjy3pMYmqsXjgXICBaPy4OtSB3/ ErMAYvf1cQGFQwQEGInOPGyx81FPQVSpqlP4YSQsgTEgN9bdtiMP2ebKMReLESe0he6a 8qqfgWFH/Os+fZeB1uywXRtFxDe3pVyTIMn/2lwmnM7UygVB+I8TnT7/Yl3B/ea6GdRr 3YRipT1PBmAzn+acvEs4gbxYo+p4DlapsLHqrmu9cGb6XzA89Kn6o0V2aUPcAbtU8zJ8 yWPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=bC2RWtbJdiWfsI/W6RoPeZSH9+/IhUPiZ9pynr15AaE=; b=PrdFTDF+SHdwv6sLL6MmMpri6WM1eTfgxyGxi2bpgas2d0BgfnKzgwK+8ivXYEswFH Pijq4SEyoycIOguQQmyw6L4C0wrOtOL154eUnkgFYB3w5a13BxK6BszlylffhiMMMNED uGWqXHh0buGO2Sdrn7yHkEzDqSYJZlGSN7z9sgkFErA4fqnz44A40jK5w4AjBF6irFtv Rdjs79z1i/1UZkUxu/kV+ZVjSgpLmtBLMKywvXDMrKNpTO1tqcbjENkuBpFVACwdT2/7 6Mso7Q9QoyilA3ogxWXpTAILXGjZjPNAZWnOv3UYKVYUfWMsSF9xbWbMYt3Ex5WAKSIB Xk8g== X-Gm-Message-State: ANhLgQ0PH6CdS5Rmz/QmbvWcxaitlJ5LKLRihKyN59a30zRQOk5mm3vK 6lifv8dM/AunRX2vB1/VlOZITykZxig+7NfsO8Jk1g== X-Google-Smtp-Source: ADFU+vt/WAspbnHx3Fm94yy7GbNBcABVf1CYbasEOGWU1mikDYZvSZ7tdsIhu+pIe+Od3NmDbrU/I5mztzeeJ9bhI4k= X-Received: by 2002:a17:906:4e16:: with SMTP id z22mr14914006eju.363.1585647759015; Tue, 31 Mar 2020 02:42:39 -0700 (PDT) MIME-Version: 1.0 References: <20200327101823.12646-1-mk@semihalf.com> <20200327101823.12646-18-mk@semihalf.com> <6a73a10f-6733-95d6-d11e-9422838ca7f8@solarflare.com> In-Reply-To: <6a73a10f-6733-95d6-d11e-9422838ca7f8@solarflare.com> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Tue, 31 Mar 2020 11:42:27 +0200 Message-ID: To: Andrew Rybchenko Cc: dev@dpdk.org, Marcin Wojtas , Maciej Bielski , "Tzalik, Guy" , "Schmeilin, Evgeny" , "Chauskin, Igor" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 17/29] net/ena: add support for large LLQ headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" pt., 27 mar 2020 o 12:21 Andrew Rybchenko napisa=C5=82(a): > > On 3/27/20 1:18 PM, Michal Krawczyk wrote: > > If the device supports larger LLQ (Low Latency Queue) headers, the user > > can activate them by enabling CONFIG_RTE_LIBRTE_ENA_LARGE_LLQ_HEADERS > > flag in the configuration file. > > > > If the device isn't supporting this feature, the default value will be > > used. > > > > Signed-off-by: Michal Krawczyk > > Reviewed-by: Igor Chauskin > > Reviewed-by: Guy Tzalik > > --- > > config/common_base | 1 + > > doc/guides/nics/ena.rst | 5 +++++ > > drivers/net/ena/ena_ethdev.c | 33 ++++++++++++++++++++++++++++++--- > > 3 files changed, 36 insertions(+), 3 deletions(-) > > > > diff --git a/config/common_base b/config/common_base > > index c31175f9d6..31f508b3cc 100644 > > --- a/config/common_base > > +++ b/config/common_base > > @@ -266,6 +266,7 @@ CONFIG_RTE_LIBRTE_ENA_DEBUG_RX=3Dn > > CONFIG_RTE_LIBRTE_ENA_DEBUG_TX=3Dn > > CONFIG_RTE_LIBRTE_ENA_DEBUG_TX_FREE=3Dn > > CONFIG_RTE_LIBRTE_ENA_COM_DEBUG=3Dn > > +CONFIG_RTE_LIBRTE_ENA_LARGE_LLQ_HEADERS=3Dn > > Consider to use device arguments (run-time) to control it. > Build time is bad and you have no it in meson build. > As far as I can see it is control path only and should > not be a problem at all. Thanks for the advice - I'll change that in the v2 version (it is going to be upstreamed soon).