From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CF35A034F; Mon, 11 Oct 2021 08:49:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2F7A40E0F; Mon, 11 Oct 2021 08:49:56 +0200 (CEST) Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) by mails.dpdk.org (Postfix) with ESMTP id 9869A40E0F for ; Mon, 11 Oct 2021 08:49:55 +0200 (CEST) Received: by mail-vk1-f175.google.com with SMTP id j38so4821152vkd.10 for ; Sun, 10 Oct 2021 23:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=J+4GBgRVEnye7NmOpbDcv6HjDTe/0MxDC4hno9CXHrI=; b=jUUz9nBBS99TOim6v80bUlrYUphY7vSrK3uoa+feQzpPNbst44F4FSqzz9gkhwgVOi swNWOmX2bjk+H4PvCaUbGLB7rwf7qOxlE5H5d+iOk/eitD8F7LRP9clNhrklI6kQ0wDT hGFgapeofBjqyG375cRT83aUDZv0SbXII2RBnld6Xu4N3sbE2mSAsgBZzoD4Ru7LjqO1 Lok6lUvNaQh9QFRhmzOzxRqYFObv6B1oBcSNrLyxNcCFfpOXBVGNkWJxFE2FpTHsZBML cr/NPjRbdITyJZmPL0CRSHtmQd+/nKCBIGmYWRo+dE5XLLtV+nl0DsKmILtOPL33SlFp xrsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=J+4GBgRVEnye7NmOpbDcv6HjDTe/0MxDC4hno9CXHrI=; b=VdNSCcNPmeiuAT/SYq9QLWN9nekcWoobBtAtoc4cEaJIiaOzrLMSgW9/Ou1NZs/jJM k1+KCRHonM6l8Fs7+5+K1JL+uoQf1nPhiR6NRbg7lQcyj8kALV5poPK/JwgYxD0Wy0v4 yx6+1RuSUFS15YMpYSrt92WLmQFueU88jXt/mlF8ozOFIN6N3zmPZHas1KkrLkLn9rKR nYwJ5ej3iaxEMZxVP6x8+lMzqwuw5qKJBMLz3f2t27vVY9v8JgvKEkDcN1NHzrfxyO0M zPOBLBDmN8DWSi2XjRMatxw6EHEseFYAR7MCIjzWSkLSpDXc9b9rxIrKch3zvKYz5SLD Yx+Q== X-Gm-Message-State: AOAM533yxxzcA5dxUxP87V/6n2nfFCayGDSIi/Dsev5RLGI1+P7My8Ik AcrXLANDkFmfafUa/IIdiCJTT/9nTuYxB18zX62wrA== X-Google-Smtp-Source: ABdhPJx6vM49x271b9Uvn4ZDbdgPdR3D7TaPTnz/7qPDqtJ/kXCTXvbyEecHEwmF+i2cuOvSQK0xEFUoIoawRMBewG4= X-Received: by 2002:a1f:bf86:: with SMTP id p128mr4738785vkf.23.1633934995039; Sun, 10 Oct 2021 23:49:55 -0700 (PDT) MIME-Version: 1.0 References: <20211004172702.3461360-1-ferruh.yigit@intel.com> In-Reply-To: <20211004172702.3461360-1-ferruh.yigit@intel.com> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Mon, 11 Oct 2021 08:49:33 +0200 Message-ID: To: Ferruh Yigit Cc: Marcin Wojtas , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/ena: remove useless address check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" pon., 4 pa=C5=BA 2021 o 19:27 Ferruh Yigit napisa= =C5=82(a): > > Reported by "gcc (GCC) 12.0.0 20211003 (experimental)": > > ./drivers/net/ena/ena_rss.c: In function =E2=80=98ena_rss_reta_query=E2= =80=99: > ./drivers/net/ena/ena_rss.c:140:66: > error: the comparison will always evaluate as =E2=80=98false=E2= =80=99 for the > pointer operand in =E2=80=98reta_conf + 136=E2=80=99 must not be = NULL > [-Werror=3Daddress] > 140 | (reta_size > RTE_RETA_GROUP_SIZE && ((reta_conf + 1) =3D=3D NULL= ))) > | ^~ > > Fixing it by removing useless check. > > Signed-off-by: Ferruh Yigit Acked-by: Michal Krawczyk > --- > Not clear about the intention of the check, removing it in this patch to > trigger the discussion. It looks like this condition was unneeded from the beginning and is in general invalid and comes from some misunderstanding. I'm ok with removing this as it was dead code anyway. > --- > drivers/net/ena/ena_rss.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ena/ena_rss.c b/drivers/net/ena/ena_rss.c > index 88afe13da04d..152098410fa2 100644 > --- a/drivers/net/ena/ena_rss.c > +++ b/drivers/net/ena/ena_rss.c > @@ -136,8 +136,7 @@ int ena_rss_reta_query(struct rte_eth_dev *dev, > int reta_conf_idx; > int reta_idx; > > - if (reta_size =3D=3D 0 || reta_conf =3D=3D NULL || > - (reta_size > RTE_RETA_GROUP_SIZE && ((reta_conf + 1) =3D=3D N= ULL))) > + if (reta_size =3D=3D 0 || reta_conf =3D=3D NULL) > return -EINVAL; > > if (!(dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_RSS_HA= SH)) { > -- > 2.31.1 >