From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 194F1A0562; Fri, 3 Apr 2020 14:30:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 76D391C114; Fri, 3 Apr 2020 14:30:41 +0200 (CEST) Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by dpdk.org (Postfix) with ESMTP id AC7FE1C0C4 for ; Fri, 3 Apr 2020 14:30:39 +0200 (CEST) Received: by mail-ed1-f67.google.com with SMTP id o1so9096258edv.1 for ; Fri, 03 Apr 2020 05:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=JYmjI5mcu7bsX3KqfrCWUSBn54y7zKnb6V/UG4GYYfs=; b=g8rT4qzyMul+mpBTUUqiLEtWhvYzwjWkw/V9uEJkqhUQI5yXY1Ywkgnmmnz6MKWQ5x N619LhxwW+163Meztqds8wWjr8PJChpR0vEbVgfvyq8/bgGRsr8hsJlhdnKutMZvbLl4 y8fqCzxCyUBelv7SBq2YEQKr1igTj4D8obmacd8cBqF9rR1+VMjqM7xHrFT6vzywI1z9 GGGXnVxmVDrw3J2mrEDBp/MR0siISmWkunUpBOjRDu8a91xImJZDqnJhSAtHQyZDA9Rd hOqzN1Suvf76nrBqlFJYF1GN4gsKfemCO9gPgx4hSnYygX3++p46aE9Lpx/+cGdDwYle i5DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=JYmjI5mcu7bsX3KqfrCWUSBn54y7zKnb6V/UG4GYYfs=; b=bsW1iCnN6vT/Gi1P6nBczH0IiFonynMnsseg4wQ3+QM0tJV9iugg3OQ6sRfc2ep8En nv8KFXREXIpK36b9zSsJyAq0tvpqY33KWjanQE71Yizfftb/ZI8dzxQtVNk4u9RPh2g8 emBKYkCZGxZZujq5pNNAA4+QbE/6AEmL0m2k1Rcoz4KDqu/RNRj/fLJNm9IgeVZqrWMi v4IXezSlBLM+IPsV0RprPQUYHHM6X7odr6r97rJJi75so8QANBWpkgFLVqHvp3HrMW12 oAGNMBKQ1plu0woT97BDWPsDaNzPCTep0zzjwsDE6mIw02mbw5XtBw6t1yFhAletKeoY 4TxQ== X-Gm-Message-State: AGi0PuZ6lM6Q4XcYFVv1WhCidWUv94SMIUlmbFhMgEIPsoZmSZfQcEny wY6MpGy7WA/XqW5kr51mUwtXOq+yYWp+K59p1sSj7g== X-Google-Smtp-Source: APiQypJJ/n3bNvXSn7y4zsmy4MIgkGLuaSLf2mQMkkrO2szJK+CeVsbau6+PldM1BgH0AkcProOjAb9nRbvawi2lPVM= X-Received: by 2002:a17:906:164f:: with SMTP id n15mr7774543ejd.322.1585917039278; Fri, 03 Apr 2020 05:30:39 -0700 (PDT) MIME-Version: 1.0 References: <20200401142127.13715-1-mk@semihalf.com> <20200401142127.13715-20-mk@semihalf.com> In-Reply-To: From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Fri, 3 Apr 2020 14:30:27 +0200 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Marcin Wojtas , Maciej Bielski , "Tzalik, Guy" , "Schmeilin, Evgeny" , "Chauskin, Igor" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 19/29] net/ena: add Tx drops statistic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" czw., 2 kwi 2020 o 15:05 Ferruh Yigit napisa=C5=82= (a): > > On 4/1/2020 3:21 PM, Michal Krawczyk wrote: > > ENA device can report in the AENQ handler amount of Tx packets that wer= e > > dropped and not sent. > > > > This statistic is showing global value for the device and because > > rte_eth_stats is missing field that could indicate this value (it > > isn't the Tx error), it is being presented as a extended statistic. > > What is the reason of Tx drop if it is not error? > It's connected with the device architecture (I'm sorry - I don't know the details). > > > > As the current design of extended statistics prevents tx_drops from > > being an atomic variable and both tx_drops and rx_drops are only update= d > > from the AENQ handler, both were set as non-atomic for the alignment. > > > > Signed-off-by: Michal Krawczyk > > Reviewed-by: Igor Chauskin > > Reviewed-by: Guy Tzalik > > <...> >