From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BD40A0C40; Thu, 29 Jul 2021 09:33:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F250140687; Thu, 29 Jul 2021 09:33:07 +0200 (CEST) Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by mails.dpdk.org (Postfix) with ESMTP id 533D440041 for ; Thu, 29 Jul 2021 09:33:06 +0200 (CEST) Received: by mail-io1-f46.google.com with SMTP id y200so5839470iof.1 for ; Thu, 29 Jul 2021 00:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=JJ9S53Vg3TEb+YxBmykxhFHlQQ+Y9nNom6u/D3khUNA=; b=QP61oNUmJnNdhRvOtt+xKdwBvEFZP3ExSgBfMb1iItVh86oKSZ0WIKaXESt5OrMzmZ cRTsxaGaqHtaIf5m2+2iF6pg6BU424EP+HcaJN72M7FAW/jHNn+MkA9kdqZX79/7MAD5 4R+XViqhYelnpxyM/E6X/AVOq7qaIizNFcQyqkPus3tVhSvqU/OiZD1ZpXHLNx8IlCbI y76cmcFKoRE7HVmeD3QjYcW/QzPV+Ul7GjQgWyFPnRuPqlPO1pw2equHihZXs9FwUOZh SmBK5MYYX57lgho6VNKO+vl5lj9L2hRWcjFIF5TnurTrPhhkKZZmo370CQSHhlZdfFB5 FX3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=JJ9S53Vg3TEb+YxBmykxhFHlQQ+Y9nNom6u/D3khUNA=; b=Zowi+XEuB4jusL9PZbltKZ6RjP2+V732CJt72MO/x/iv5ZYEeXdGdxBrYMjGUnjm8X Qx6uTlxPlzCwaoh2sRThYr/9JUPCd8i8CTQSpNKozyVwCnXdwaa9A8aVR8mJWZCQ9oIp 7niDU+l2Dca9NMqMTLGWUk25hKd5gpgVRxG39GDs513VGBxAlEToX23IcuF0Yik3bHAz AsAYGKRXGZu/vRbBm7t9RrhofXYyjC21i+YKOPM0vLMrzRbwYauCrMu6iwILjeKSPPHM LCyNqP8voV0/Nl6d9T+i0PEYfnuhfpwMHKVbl8UrK2dlneOp83HYPnSS4AswNUH115fY BmaA== X-Gm-Message-State: AOAM533YkjYke8LtUT59hipfB5hOmLk5qZojFxpbnWJR3C1BcuKJWtTJ +WMzeDXfCtq0qLJBgnv0IASvtX9j1946n+++PDrPog== X-Google-Smtp-Source: ABdhPJwC6LZ9bwZPyzz4aADlhvJ3DrG+XU6A9qe3+YbDD7zVW7p94L0p4/ECgmLbtz+j5bIFgO31/45cpmODni5GnWg= X-Received: by 2002:a6b:6310:: with SMTP id p16mr2970313iog.148.1627543985640; Thu, 29 Jul 2021 00:33:05 -0700 (PDT) MIME-Version: 1.0 References: <20210712170153.11508-1-ghalem.boudour@6wind.com> In-Reply-To: From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Thu, 29 Jul 2021 09:32:54 +0200 Message-ID: To: Olivier Matz Cc: Ghalem Boudour , Marcin Wojtas , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/ena: enable multi segment in Tx offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" czw., 29 lip 2021 o 09:26 Olivier Matz napisa=C5= =82(a): > > Hi Micha=C5=82, > > On Thu, Jul 29, 2021 at 08:40:00AM +0200, Micha=C5=82 Krawczyk wrote: > > =C5=9Br., 28 lip 2021 o 16:27 Olivier Matz nap= isa=C5=82(a): > > > > > > Hi Micha=C5=82, > > > > > > On Wed, Jul 14, 2021 at 12:02:32PM +0200, Micha=C5=82 Krawczyk wrote: > > > > pon., 12 lip 2021 o 19:03 Ghalem Boudour = napisa=C5=82(a): > > > > > > > > > > The DPDK ENA driver does not provide multi-segment tx offload cap= ability. > > > > > Let's add DEV_TX_OFFLOAD_MULTI_SEGS to ports offload capability b= y default. > > > > > > > > > > > > > Hi Ghalem, > > > > > > > > This patch enables announcement of the DEV_TX_OFFLOAD_MULTI_SEGS > > > > capability, but still the application may not request this offload. > > > > > > > > As ENA PMD currently assumes all the mbufs may have multiple segmen= ts > > > > (and we don't have fast-path for the other cases), I suggest > > > > overwriting this flag in the ena_dev_configure(), similar to what > > > > we're doing with the DEV_RX_OFFLOAD_RSS_HASH flag. > > > > > > To give some more context, our application currently checks if the > > > driver supports multi-segments by checking its capabilities, and asks > > > for the feature if it is advertised. > > > > > > When dealing with drivers that do not advertise this capability, our = app > > > linearizes the segmented mbufs before sending them to the driver. > > > > > > I think this is the proper way to use the API: if the driver supports= to > > > handle multisegmented mbufs, it should advertise the capability. > > > > > > Regards, > > > Olivier > > > > > > > Hi Olivier, > > > > I agree we should advertise it. However, after advertising this > > option, the application should ask PMD to use this feature if I > > understand the offload API correctly. > > Yes > > > I was thinking about the PMD behavior if this option won't be > > requested by the application - it would be the same as for the > > multisegment setup, that's why I suggested to also override this > > feature at the configuration step. > > > > With the RSS hash feature we're doing exactly the same - first we're > > advertising that it's available, and then (if RSS was enabled), we're > > setting this offload as enabled, even though the application didn't > > request it explicitly. > > I have no strong opinion here. If there is no behavior change when the > option is set or unset by the application, I think both options are > acceptable: either return what the application asked for, or return the > option always set (as you do for hash). > > > Anyway, I won't be holding push of this patch as we're close to rc3. > > @Ghalem, please add the fixline and Cc the dpdk@stable.org in the > > commit log, so we will have this commit backported. > > Ghalem is currently off, I'll take care of it. > > The multiseg Tx feature is there since the beginning, so the Fixes > line will be: > Fixes: 1173fca25af9 ("ena: add polling-mode driver") > Ack > I can also add the flag in ena_dev_configure(), if you feel it is more > consistent. Please let me know. > Please add it, so it will be more consistent and verbose. Thanks, Michal