From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73C02A00C2; Wed, 23 Feb 2022 18:47:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4653A40E5A; Wed, 23 Feb 2022 18:47:40 +0100 (CET) Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) by mails.dpdk.org (Postfix) with ESMTP id BE7F440DF6 for ; Wed, 23 Feb 2022 18:47:39 +0100 (CET) Received: by mail-qv1-f48.google.com with SMTP id bu6so9631852qvb.10 for ; Wed, 23 Feb 2022 09:47:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Q9UJOnqeAoUBYFM6yJwFaCs40iNZOV7GMP0MtD9ENZs=; b=0GOIwVpIGG0xCjCuq50pMGrhvfYYRCvCPEh248huendZixu+zfDX2VfvKzNchdAEyr hyx795Hq9betWdEzyBfqewe3Vo25OeTPr4oZVMfxCHUCdl13WVYvVEQDcLgy1k/ftV/d eM+IzUgvM3fAtFP8tzZsQ2HT4qY1z3UrsG/7bvmBT1HFpHiMiNpCRut4CoQct5+ybUN4 I3d8IEstdFyQXezVFQwiXhoP/FPJVlGUNfbsu2jzEN+O3/O43OVfVCbnAx4Dte67KPur dkdoLB9fipDDVXglHVJpBCozJqRUH4cIj3xPmw1TX4fmNrrM0cmFCait+hPkcCRKXTeQ esUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Q9UJOnqeAoUBYFM6yJwFaCs40iNZOV7GMP0MtD9ENZs=; b=6ptCoJ5NR00kJtdzeWMiljgEYOvq5RZ18Q+xYp0qIa7ei7zIXvkosCfI2mCND4CkNj BAs7eqEFhAn0XAv3cVrqC5XkaUha/mwffEhqk0W5l7vqvBgDuPe40MFSlHprTxA3oJJi aKdh2KvMeLp51cVCUEp5AGSPhkRHltoKS7k/4WCY+vMD6TNvKkFlPzXTv0jsMZdSef2U VwUs2e8buKAaYvFkTyBXZtywbONKcUKRBKkwnvUJfVwiQRMZui3DI/S3RcS9CLWhQg89 eh6srSaqjoc016J4WfhFO9h+yIqWEbBHJQhyuQLr/e0DMH/q8X0piXlyOu3LOvNB4orh WDYA== X-Gm-Message-State: AOAM533vc9gJy6/beU3/5ApHoBZSZAtA1xdABUrpsfW+1QiZHGfRZ9iu bSosPLOVaTXhaGeGxixKqSfbE3r8e+FpsOvL+BLk8g== X-Google-Smtp-Source: ABdhPJzfDr4SFK+ddRLkL/NOcwRwLBkGeuNwSfLXUSB7R9UaLrefwdUClgO4fuIBkdRA2cP28Ax3OnS4TRUtuowZUzw= X-Received: by 2002:a05:6214:300a:b0:430:c41:3d92 with SMTP id ke10-20020a056214300a00b004300c413d92mr402003qvb.53.1645638459214; Wed, 23 Feb 2022 09:47:39 -0800 (PST) MIME-Version: 1.0 References: <20220222181146.28882-1-mk@semihalf.com> <20220223121944.24156-1-mk@semihalf.com> <20220223121944.24156-5-mk@semihalf.com> In-Reply-To: From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Wed, 23 Feb 2022 18:47:28 +0100 Message-ID: Subject: Re: [PATCH v3 04/21] net/ena: remove unused offloads variables To: Ferruh Yigit Cc: dev , "Brandes, Shai" , upstream@semihalf.com, Artur Rojek , Dawid Gorecki , Igor Chauskin , Kevin Traynor , Luca Boccassi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org =C5=9Br., 23 lut 2022 o 18:25 Ferruh Yigit napisa= =C5=82(a): > > On 2/23/2022 12:19 PM, Michal Krawczyk wrote: > > Those variables are being set, but never read. As they seem to be > > leftover from the old offloads API and don't have any purpose right > > now, they are simply being removed. > > > > It can be good to add fixes tag, both for > - document in which commit old offload flags because useless > - backport the change to LTS, I can see the changes don't do > much but backporting them can help to reduce future conflicts > for future fixes (cc'ed LTS maintainers for comment) > Good note - I'm ok with adding the fixline. Thanks! > If agreed please send the fixes line, I can amend it in next-net. Fixes: a4996bd89c42 ("ethdev: new Rx/Tx offloads API") Cc: stable@dpdk.org > > > Signed-off-by: Michal Krawczyk > > Reviewed-by: Artur Rojek > > Reviewed-by: Dawid Gorecki > > Reviewed-by: Igor Chauskin > > Reviewed-by: Shai Brandes > > --- > > drivers/net/ena/ena_ethdev.c | 3 --- > > drivers/net/ena/ena_ethdev.h | 5 ----- > > 2 files changed, 8 deletions(-) > > > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.= c > > index 2de2dcf12f..de5fdb8f1d 100644 > > --- a/drivers/net/ena/ena_ethdev.c > > +++ b/drivers/net/ena/ena_ethdev.c > > @@ -2015,9 +2015,6 @@ static int ena_dev_configure(struct rte_eth_dev *= dev) > > */ > > adapter->tx_cleanup_stall_delay =3D adapter->missing_tx_completio= n_to / 2; > > > > - adapter->tx_selected_offloads =3D dev->data->dev_conf.txmode.offl= oads; > > - adapter->rx_selected_offloads =3D dev->data->dev_conf.rxmode.offl= oads; > > - > > return 0; > > } > > > > diff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.= h > > index f47ba3fb02..4dfa604d51 100644 > > --- a/drivers/net/ena/ena_ethdev.h > > +++ b/drivers/net/ena/ena_ethdev.h > > @@ -278,11 +278,6 @@ struct ena_adapter { > > struct ena_driver_stats *drv_stats; > > enum ena_adapter_state state; > > > > - uint64_t tx_supported_offloads; > > - uint64_t tx_selected_offloads; > > - uint64_t rx_supported_offloads; > > - uint64_t rx_selected_offloads; > > - > > bool link_status; > > > > enum ena_regs_reset_reason_types reset_reason; > >