From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f195.google.com (mail-ua0-f195.google.com [209.85.217.195]) by dpdk.org (Postfix) with ESMTP id 5A21A3572 for ; Mon, 18 Jun 2018 08:04:44 +0200 (CEST) Received: by mail-ua0-f195.google.com with SMTP id f30-v6so9948160uab.11 for ; Sun, 17 Jun 2018 23:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=HY+N4gkCtttKIVWOGwCEvS8fipV5rvX2Fh+wUjPiFVA=; b=hQ8nMyWdDiGGhRYoYiSFf71Vu8dH6y1gFbsZB2OOKCHts+oA21yu2NXswmb8tY4nSR L9xNXZrLd+ZtWqEo610OwXLnPe0EI8AI2xp1msnjn9/2RgosxOJnaB8IGXTrNpahX+HQ /nkIsy7fgz/H8WJpl3kKLN6X4FPXRvxtTTZ4s9LieZgr9wfox5VVpsVBxX8S3GRVUjBh QtAuO3xQ3ypKYCZdxvkltm85NUIykzhpFClCYKbX2W58ODXCAK6LEhJ+qW/X6zjSVX66 4+NKG/5yAAgIxu/GtoC+Km7xwteR0/WdyfJba6TVidam8qQawMTfqoFna3gIcGzWh07k 2Wkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=HY+N4gkCtttKIVWOGwCEvS8fipV5rvX2Fh+wUjPiFVA=; b=lJ0gWGc2bGjXzgoeO55mxvhsF3CS1TSAxiZgIoPcDBQRWi0jNo0yXSp98GhJHF/B3j P+f128puwUlVKn32bfROUWOUc6kcg3H5LBy7D98Ga71Wl+KP0kfLrTMvpN+HeVDbFI2k nWll3R0sD8SY0pZIIWTotr7dDSmxlZlGjH1xfWqJbwCN3uK9Z+QVQVOWaVBELSmOfhFf zLmQ6ZQ7WJnttM+1gV0M7WWP1Tp7YITNB83n9YwDcmGWvFrIHDKcPNTQxiJ31gpbbS6e 4MQNqbZ5c9q7KtPtvR/l2yIvdUG667nw5MS/BraaS/Inqq4fJFlgGzEZdvsLaaGEXC8d W7JA== X-Gm-Message-State: APt69E0Kt6ia7Z3a1I22VhdKs0gGRLv18vy8i9kszqFKiE8fJ/a/o+cm PDVqO7N/0y6VYOy/2l3lYO2fC2WvoPO/28Qk/azcsg== X-Google-Smtp-Source: ADUXVKIYW/XbyXGvmpjLmR9Ju0GF8Qk9Gz0L1dyzT7OKMDId6fU39/P1Zujf37iii2P2k+Q6IJAla2jCM/EGgluV3Go= X-Received: by 2002:ab0:51c7:: with SMTP id h7-v6mr7048770uaa.77.1529301883624; Sun, 17 Jun 2018 23:04:43 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a67:62c7:0:0:0:0:0 with HTTP; Sun, 17 Jun 2018 23:04:43 -0700 (PDT) In-Reply-To: <3540745.n2F2IE3GfD@xps> References: <20180607094322.14312-1-mk@semihalf.com> <20180607094322.14312-10-mk@semihalf.com> <3540745.n2F2IE3GfD@xps> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Mon, 18 Jun 2018 08:04:43 +0200 Message-ID: To: Thomas Monjalon Cc: dev@dpdk.org, Marcin Wojtas , Guy Tzalik , Evgeny Schemeilin , "Matushevsky, Alexander" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 10/27] net/ena: add lrte_timer dependency for linking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 06:04:44 -0000 2018-06-18 0:37 GMT+02:00 Thomas Monjalon : > 07/06/2018 11:43, Michal Krawczyk: >> ENA PMD is required to use librte_timer. The appropriate depndency must >> be added ifin case the DPDK will be built as shared library. >> >> Signed-off-by: Michal Krawczyk >> --- >> drivers/net/ena/Makefile | 1 + >> mk/rte.app.mk | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile >> index 43339f3b9..ff9ce315b 100644 >> --- a/drivers/net/ena/Makefile >> +++ b/drivers/net/ena/Makefile >> @@ -58,5 +58,6 @@ CFLAGS += $(INCLUDES) >> LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring >> LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs >> LDLIBS += -lrte_bus_pci >> +LDLIBS += -lrte_timer >> >> include $(RTE_SDK)/mk/rte.lib.mk >> diff --git a/mk/rte.app.mk b/mk/rte.app.mk >> index 1e32c83e7..c70bc254e 100644 >> --- a/mk/rte.app.mk >> +++ b/mk/rte.app.mk >> @@ -60,6 +60,7 @@ endif >> >> _LDLIBS-y += --whole-archive >> >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) += -lrte_timer > > Why is it added in rte.app.mk? It is already there, few lines below. I think that's because it wasn't present on the version I was preparing the patch (18.02) and I didn't notice that it was added meantime when I was rebasing this patch. This patch is already merged to dpdk-next-net. Should I add a patch that is reverting this change there?