From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6871DA04DD; Fri, 23 Oct 2020 14:56:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E3A3CA94B; Fri, 23 Oct 2020 14:56:22 +0200 (CEST) Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) by dpdk.org (Postfix) with ESMTP id 551EFA945 for ; Fri, 23 Oct 2020 14:56:21 +0200 (CEST) Received: by mail-ej1-f65.google.com with SMTP id gs25so2266218ejb.1 for ; Fri, 23 Oct 2020 05:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=f30Il5AYlG5O8cdDEpEaiRaz0lTebPwgdFAkmmb3siU=; b=KcAPoAtX+CsrK9Ol1r7C7GnYFM5v/7fDWN2KOieOaCJ2QEwLDJJ3mvabjQNKdVeJlx 9DBgCSEqulDKokzqz7mmJXDoHcbM1NEnbwn3sPHQgcmsmkTc6PEEA+P9Til4gGmxruIM UKAIyWOj6Ndv+E8El9IZ3hdxTi6NVMPxA+IQNgLraqGMQ9k5ExnZ5M0W1iENL4jU1lnH 7mPkVLb6giNbmddASSMmSGubbjqjTRIum35N9OE1lfwkdSdjja9hOXErhi0htoPYv7k+ ScPOtytV4RUNuE2aJXuq/6tD7QtBYNGEkwIG/+QFVPyVRwm8cji2emqZNlBhgTwsC5Vi b18g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=f30Il5AYlG5O8cdDEpEaiRaz0lTebPwgdFAkmmb3siU=; b=kTG7N6tuImLsMnZYEyvIcHubVZH1ZS5fm8BJQB9Lw83VsEGy7sR/SdDmNwepFmeSKb eEG59kquW3iN9zGvdtxLFfAiEUg/RbZGvutB97jSbFw3gPVOvDnTK8TC2ZV7kOhZaxsS 0VtfXGiepLQFJHzYOHWuqJ31+91rvglgr3KNgMu2hSNEfmezN4wVCulpl3X6ybP0Xvr5 p3fzcKPI+hJEH04EM4ZeRNOQB/e5MgmCKi2FTkyOpf6tsrotRL8P2yw6U0M+vsSFje9e soI0/dYsY4PEbOMLIOVXRb5YKRhVXFT9qTm+YRxE0H0zWOOaNQQeg/lVwiAOzlHuURZJ U2/g== X-Gm-Message-State: AOAM530pWZm/+jCN5Gd1enQ3LSK2i59PCXsWVoQdMyi96nCZ0FGEODcE YTJbRsdMsyMU7Lb0IOgOpG0gJyfmVi9vlXX+wTpEOQ== X-Google-Smtp-Source: ABdhPJztSFJSeNWVUgThlkhbfTlUvGVNF/HMcWbmdgIJb8zhytee4i+06eohCyn5j1E/jfzbnpXIDrRKjs70ku0rV2Y= X-Received: by 2002:a17:906:2ad3:: with SMTP id m19mr1749893eje.81.1603457779933; Fri, 23 Oct 2020 05:56:19 -0700 (PDT) MIME-Version: 1.0 References: <20201023084352.30034-1-david.marchand@redhat.com> In-Reply-To: <20201023084352.30034-1-david.marchand@redhat.com> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Fri, 23 Oct 2020 14:56:08 +0200 Message-ID: To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, Marcin Wojtas , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Rafal Kozik , Stephen Hemminger Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/ena: remove unused macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" pt., 23 pa=C5=BA 2020 o 10:44 David Marchand na= pisa=C5=82(a): > > This assert macro is not called anymore. > This also fixes an invalid reference to RTE_LOGTYPE_ERR that does not > exist. > > Fixes: 3adcba9a8987 ("net/ena: update HAL to the newer version") > Fixes: 6f1c9df9e9cc ("net/ena: use dynamic log type for debug logging") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Acked-by: Michal Krawczyk > --- > drivers/net/ena/base/ena_plat_dpdk.h | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/drivers/net/ena/base/ena_plat_dpdk.h b/drivers/net/ena/base/= ena_plat_dpdk.h > index ae4fd8f868..a6782f3732 100644 > --- a/drivers/net/ena/base/ena_plat_dpdk.h > +++ b/drivers/net/ena/base/ena_plat_dpdk.h > @@ -73,19 +73,6 @@ typedef uint64_t dma_addr_t; > (rte_get_timer_cycles() * US_PER_S / rte_get_timer_hz()) > > extern int ena_logtype_com; > -#if RTE_LOG_DP_LEVEL >=3D RTE_LOG_DEBUG > -#define ENA_ASSERT(cond, format, arg...) \ > - do { \ > - if (unlikely(!(cond))) { \ > - rte_log(RTE_LOGTYPE_ERR, ena_logtype_com, \ > - format, ##arg); \ > - rte_panic("line %d\tassert \"" #cond "\"" \ > - "failed\n", __LINE__); \ > - } \ > - } while (0) > -#else > -#define ENA_ASSERT(cond, format, arg...) do {} while (0) > -#endif > > #define ENA_MAX_T(type, x, y) RTE_MAX((type)(x), (type)(y)) > #define ENA_MAX32(x, y) ENA_MAX_T(uint32_t, (x), (y)) > -- > 2.23.0 >