From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 873E2A04F1; Fri, 13 Dec 2019 21:02:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 861691C0C5; Fri, 13 Dec 2019 21:02:06 +0100 (CET) Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by dpdk.org (Postfix) with ESMTP id A28FD1C0C3 for ; Fri, 13 Dec 2019 21:02:05 +0100 (CET) Received: by mail-ed1-f67.google.com with SMTP id cm12so67825edb.11 for ; Fri, 13 Dec 2019 12:02:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wFG10gbgmfJ4WJN8NGN8q1ovLNU5nBDN/P/cxRXic8I=; b=Q3flf9r6XpOVlL/WoFQSIx9l2w2I7EvgmmlF5tNw5wac57EklyAxiyqkPlQLoMLwBl EBi7VuYn2KO7DhIlALEH1GACK5b5BR00BPKcOQN4v8UUENi6Ew7GrqKp77/eR6A2MslO 7Hmfc2OjW4fRTabjA12CvPQQPVRuX4um4D2uyRDlRzyU/TYrNtPqPdigbTuiJkC24yai 4xE4hWAwchS8iMg+sxKlE/sGDZIBbOCSUK1Q+NIzqQ14mSf95mScT5g7B+W6E1PrlJMV frvN/W4uYRht+isceNMYr2anrAj7PWmdelLR/WdkGYiw19Ln9UoqEqKVgkicRj+3LYD3 M80w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wFG10gbgmfJ4WJN8NGN8q1ovLNU5nBDN/P/cxRXic8I=; b=ugQRLk+DEeDZQU2s+3LhGURU4LLIkByGlpHMQwT121lqlEB9giH9+jw++nZzYKLaW/ LpmYWiGsRqdi37C9N4UH7E+EduIrhs5eOd5olSPaofCxZcwgK+0xy8fTv+Sw4ExPQDsY /gONZzUhnParuKQsfnVAaQ3VHIMaSfPMWyv/5sqoKLxt3TfFWRp6ZYhlIuxxpBoBTOWF RN+1v1S7vj0ojeDdoozj8mMgkavTrYwH/eKw1o69IRQNmYu1PvBoLGts+6tlr1tgM+Vl 8Z4fzRFp4e5MSEBQwMc9Z6omZQOsifc2NeY0Hs8BsBMUrZINk8unb920bgBdiQNcPhE2 Xb+Q== X-Gm-Message-State: APjAAAU2ibfrcX04QC0eUhrdmjkBU62I+5LIsKDju6KUCZH2vdi8+dN/ nvaCciVyPlFLp3mlJ+bA0hCnxciy1+vf2RN5BO2jPg== X-Google-Smtp-Source: APXvYqzA/OFuoMq/L4IZm6a+ltyg38CxTOyc8IAM7Q8m9ArI0LPI7h38Up80aAdUtyG++sCIqQcUtpu56BYYtL78Gwg= X-Received: by 2002:aa7:c507:: with SMTP id o7mr17548653edq.282.1576267325240; Fri, 13 Dec 2019 12:02:05 -0800 (PST) MIME-Version: 1.0 References: <20191213133216.23572-1-mk@semihalf.com> <20191213133216.23572-2-mk@semihalf.com> <20191213083420.31f2b7c8@hermes.lan> In-Reply-To: <20191213083420.31f2b7c8@hermes.lan> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Fri, 13 Dec 2019 21:01:53 +0100 Message-ID: To: Stephen Hemminger Cc: dev@dpdk.org, "Tzalik, Guy" , Marcin Wojtas , "Matushevsky, Alexander" , mba , "Chauskin, Igor" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/2] net/ena: upgrade HAL for new HW features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" pt., 13 gru 2019 o 17:34 Stephen Hemminger napisa=C5=82(a): > > On Fri, 13 Dec 2019 14:32:15 +0100 > Michal Krawczyk wrote: > > > This version of the HAL allows to use the latest HW features, like > > rx offsets. > > > > Driver was adjusted to the new version to fix the build. > > > > Signed-off-by: Michal Krawczyk > > Signed-off-by: Maciej Bielski > > You are mixing multiple changes into one patch. > This makes it harder to review (find the real bits) and also > harder for bisection. > > It makes sense to fix whitespace and related stuff in one > patch if you are fixing one function and the nearby code > already needed work. But please avoid larger scale change > put together. > > In your patch I see: > - remove unnecessary whitespace > - drop unnecessary inline > - add missing newline in log messages > - check for NULL pointer > > If possible could you preserve the per-commit updates for base > code, rather than one lump diff. Hi Stephen, We are not developing HAL (ena_com) on our own. We are getting it from the Amazon team and we don't have history of it's development. Tha's why we are upstreaming a diff between two versions of the ena_com. Moreover this HAL is common for Linux kernel driver, FreeBSD kernel driver and Windows kernel driver. Because of that, we are trying to avoid to modify it on our side unless it's really necessary (for example, if compilation fails on for the DPDK). In fact, we are doing changes to the PMD and our platform file (ena_plat_dpdk.h which is a glue) in this patch, but that is required in order to do not have patch which is not compiling. Both the PMD code and the glue code can be changed without affecting other platforms. Thanks, Michal