From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E2DCA0562; Fri, 3 Apr 2020 14:16:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 79C331C0B4; Fri, 3 Apr 2020 14:16:05 +0200 (CEST) Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by dpdk.org (Postfix) with ESMTP id 08EE11C08E for ; Fri, 3 Apr 2020 14:16:04 +0200 (CEST) Received: by mail-ed1-f67.google.com with SMTP id c7so1289301edl.2 for ; Fri, 03 Apr 2020 05:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wxMfBLHGa6lC49VS1A24mJTSYTpMt2KcCmUZRBYeSkM=; b=mXxJvUUvcoAvqO3P5B+6I5a7gig4vH6FzBpIwS12pmBdAKvCEqpBShys3qyfq5XWF+ Xe7a/8hhE3mContcE5bbtboDaaHwF45iDPudbXgxgUI+o6eA1dgb61oMj/jvEmuhqLVr g4HDA7jsW5oB+qnLWP4xfbo8V/diGT2HE+/EM5bH9NA+9TP5hUQdGdQsL6GdXfDZDasD DjQO6XulurnV8PMZkf/kda+oQMh5g/k6IoQO+PKeQOPFUypAICRemP3SEfWPGxWeMjOV 9MmMhssvOyy/cf+euq+a4KBXxDsZfhjHhuFxuTNDaYZt2m9uQ8KryedE3wJyLVoa0HRO xRYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wxMfBLHGa6lC49VS1A24mJTSYTpMt2KcCmUZRBYeSkM=; b=boK64ckV7U6bNMiygvQ36YEVF+H9Ojvpmb09+hLHjqL/D/MtD6QyX2B5+n5KD1VXbx FAI4BQGKnsoSVGRmdP4SECGkCjIWLLugREqwZ9YHrIjK0n9goOi0yvm5o3iUPGBRrDlr VEi3enbE/2e1q2LtlgfFlhM2b5D9qKMaZguV7RVJrzCNOMvKuJYFxD5FcxBW4ILncMHH DYgcj/7ub8qCFQ880XEugS0OyHIi24xR89ft/uLliWHqSvZJszFMsD9RY3NPZlf+0BF6 tsJOlGmpSLQBTGfdQ23mHnNTvE/JyPtZXzvUGE/O9T6FsA2CqbDioLzmJbrJKmT2k1nF 15aw== X-Gm-Message-State: AGi0PubVt/5j2kSlhfJJc9UaCBjOAVKbhzgRuOadaAjIlr2bhml0Zwpt KddyxPFKtbBLpot8hl2lR0mWW6B45KgjSHrZvzekEw== X-Google-Smtp-Source: APiQypLN62IZraeKiO9tMvMAayyPzVwf1DdjxVDm6hYi5m1obDMTU0k+ZoBMuneemtOA3BSRLBWuck2aCI9KPPW/vB0= X-Received: by 2002:a17:906:b802:: with SMTP id dv2mr8295287ejb.92.1585916163688; Fri, 03 Apr 2020 05:16:03 -0700 (PDT) MIME-Version: 1.0 References: <20200401142127.13715-1-mk@semihalf.com> <20200401142127.13715-18-mk@semihalf.com> In-Reply-To: From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Fri, 3 Apr 2020 14:15:52 +0200 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Marcin Wojtas , Maciej Bielski , "Tzalik, Guy" , "Schmeilin, Evgeny" , "Chauskin, Igor" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 17/29] net/ena: add support for large LLQ headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" czw., 2 kwi 2020 o 15:02 Ferruh Yigit napisa=C5=82= (a): > > On 4/1/2020 3:21 PM, Michal Krawczyk wrote: > > If the device supports larger LLQ (Low Latency Queue) headers, the user > > can activate them by enabling CONFIG_RTE_LIBRTE_ENA_LARGE_LLQ_HEADERS > > flag in the configuration file. > > > > If the device isn't supporting this feature, the default value will be > > used. > > > > Signed-off-by: Michal Krawczyk > > Reviewed-by: Igor Chauskin > > Reviewed-by: Guy Tzalik > > --- > > v2: > > * Use devargs instead of compilation options > > > > doc/guides/nics/ena.rst | 8 +++ > > drivers/net/ena/ena_ethdev.c | 110 +++++++++++++++++++++++++++++++++-- > > drivers/net/ena/ena_ethdev.h | 2 + > > 3 files changed, 114 insertions(+), 6 deletions(-) > > > > diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst > > index bbf27f235a..d5081e91e5 100644 > > --- a/doc/guides/nics/ena.rst > > +++ b/doc/guides/nics/ena.rst > > @@ -95,6 +95,14 @@ Configuration information > > * **CONFIG_RTE_LIBRTE_ENA_COM_DEBUG** (default n): Enables or disab= les debug > > logging of low level tx/rx logic in ena_com(base) within the ENA = PMD driver. > > > > +**Runtime Configuration Parameters** > > + > > + * **large_llq_hdr** (default 0) > > + > > + Enables or disables usage of large LLQ headers. This option will = have > > + effect only if the device also supports large LLQ headers. Otherw= ise, the > > + default value will be used. > > Again, better to describe what 'LLQ' is, and you may want to describe wha= t is > the usage/benefit of enabling large LLQ headers, up to you. Sure, I will do that in v3. Moreover, the commit log needs an update, as it's currently describing static configuration, while we're using devargs now (introduced in v2).