From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C6D7A2EDB for ; Tue, 1 Oct 2019 20:43:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9435D4C9D; Tue, 1 Oct 2019 20:43:50 +0200 (CEST) Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by dpdk.org (Postfix) with ESMTP id 40E314C8E for ; Tue, 1 Oct 2019 20:43:49 +0200 (CEST) Received: by mail-qk1-f172.google.com with SMTP id u184so12301651qkd.4 for ; Tue, 01 Oct 2019 11:43:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=5BiIwsB6lBoiKFYuzyhESu9+DCTPuaj8NvEQHKIck6k=; b=VortWraNB6WYDWFmLOrN6KRYFtG2TQy8lv2mJzS7jA0o5pRPJqAUz79sAjSqUUfEww S/c+ja+O6C7Ygj/ZIYc3jrapSSHDmEwJRSgThH1VLaZ1mEhH0AUOq71of28udr68F0CF aCRf5bfRt1ZUTBueGa1Z72q4mA96kLt0Ozg6sbUnJIk8UFqBI8d2L0rEbP5OUb4QoKIf RomY0goLoJLZfTv2Ns9GAH51Jwt5VHLAetnG2AV0CjGdUApBRmlVQM2ynSUxCRfXCl4x tIykUSKpo44MZzEHE0zAvkpJRLv0lvEqzDC8Pi+mwasmwo6n8guN/s3hONMEzkq/CsDq s4pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=5BiIwsB6lBoiKFYuzyhESu9+DCTPuaj8NvEQHKIck6k=; b=RPo+1jFPdQnFuN41ifwqBopZwjv3xErkd2y0GbRNxEIHp7HI3NYiyHAimKEpiXC3hK ZHn8RX/BREeO4kLFa27TerzlTNCqO8MckNw0+AGpcHEKq8JAAFLWe/K9bOLtzplEGHqQ CIdff9qJPgXE/ykjRsacUd3p5THAcEa28/IgAbcAsZxhkqP0CE6CPyagUvFMUQdUef6r hKqleJKFydHIkOE0HoGFt4vSVALbmQcpa/E5e+MOaDo0bOXRuc5PPIHQufr8rPKnvce4 FU/uzxYPVV4ZAK4x9j1edXsOO0figxroRa8SKagENJYk7ddQA8i0EA1OJd8Hn3KDFhzi os1Q== X-Gm-Message-State: APjAAAXIFSQl48z+TSfbo3sFiOQfOaotYFEb781Why55XF5Qi6bHs6ig 8i9ZpQxVTYEYWPvbnp79uwi7HF10v+PnF7LQYsH6Gwz4t7M= X-Google-Smtp-Source: APXvYqwa2e5r/MgL789pzaey+GyPXqONRmxzWuuT9Hdq5AO+b8v1RFQmTCLeVIZXMIREPGK+1AFU+Pe2Bl4a8i8ubFU= X-Received: by 2002:a37:a106:: with SMTP id k6mr7429406qke.158.1569955428358; Tue, 01 Oct 2019 11:43:48 -0700 (PDT) MIME-Version: 1.0 From: Geetha Anandakrishnan Date: Tue, 1 Oct 2019 11:43:37 -0700 Message-ID: To: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] Qn on vlan filtering for promiscuous ports VMXNET3 driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi All, I am experimenting DPDK with VMXNET3. I see that the vmxnet3 driver code does not set vlan filtering if port is in promiscuous mode. I modified the vmxnet3 code to skip the check for promiscuous port, code below. But it does not seem like filtering works with this change, when port is in prom. mode. Does the firmware not look at the vlan table if port is in promiscuous mode. Any help is appreciated. Thanks!! /* Enable/disable filter on vlan */ static int vmxnet3_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vid, int on) { struct vmxnet3_hw *hw = dev->data->dev_private; struct Vmxnet3_RxFilterConf *rxConf = &hw->shared->devRead.rxFilterConf; uint32_t *vf_table = rxConf->vfTable; /* save state for restore */ if (on) VMXNET3_SET_VFTABLE_ENTRY(hw->shadow_vfta, vid); else VMXNET3_CLEAR_VFTABLE_ENTRY(hw->shadow_vfta, vid); *#if 0* * /* don't change active filter if in promiscuous mode */* * if (rxConf->rxMode & VMXNET3_RXM_PROMISC)* * return 0;* *#endif* /* set in hardware */ if (on) VMXNET3_SET_VFTABLE_ENTRY(vf_table, vid); else VMXNET3_CLEAR_VFTABLE_ENTRY(vf_table, vid); VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_UPDATE_VLAN_FILTERS); return 0; } -- A.Geetha "Everything is Possible. The impossible only takes a little longer"