From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6BDB243DEE; Wed, 3 Apr 2024 18:09:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B947940649; Wed, 3 Apr 2024 18:09:41 +0200 (CEST) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by mails.dpdk.org (Postfix) with ESMTP id 1017140144 for ; Wed, 3 Apr 2024 16:59:21 +0200 (CEST) Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2d23114b19dso89103201fa.3 for ; Wed, 03 Apr 2024 07:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; t=1712156360; x=1712761160; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=52M9gXT9/aXMFUgQBibMoZ+YviVB77cwjZHCfX0ZzRA=; b=FxrSIYSmKUSjZ+ozQv+2Q0IQh9MrkL6jtpyfUdDEqnzTUjgpx0o95lO/5Atj1U//UZ VBQJiVXxFZ5Z/25sUyTMpu8q9peXVYlNI1Go7ZKx3Z1mIR0HPQka3mFxS3+i81kdP/9s CPXPYeqcQ74PTiLO7CnWUfAyk4Oa50VrnM+PRqFb/wFUGYX53wklunJxvregmzt2h7jz SJIZsWBV400V8xJtKv9lYF8Y9a+APnejISWig1yLY7XIQR4STJUq6WHqXJ79xqhRA8lw HL/z6KakKJF0zImplDROQA2HdaBCV7bTrWny+V+bOY2WvERzNVoXRURS4SZcdPX+jr3e DI/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712156360; x=1712761160; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=52M9gXT9/aXMFUgQBibMoZ+YviVB77cwjZHCfX0ZzRA=; b=Qm4HhrOfPK4lbZbgJr9wkb4KDXqRyX07133bhvqUsjNoZ0E5s/5hiuciDX+zgEOVyx 0f9ODXzpnB80p9WNbu/pU09eu5925lcxrTyGp9JixbOfPu8eGltdXNC7MQyyiQY8Ejfl CdCgi8SRH3LRVSMPbdJFAA/oi/SDN3U8fXF0fsOIK8q6TPkIxjv3UAZTl4tz14sBbFOi DccePfyiCR/NxbhUVMw3qjzDEIEwIZD/X24uP1fM+ylV/8mp1T4WuphGp6ZURAGDUdpt /1sZva3QyyjpRVrm9NQlBpvW0NkQJIcyZl/8y5ub3h0EYMttqRXaB2sR3g2l1tYi3S92 XtYA== X-Forwarded-Encrypted: i=1; AJvYcCV5qG8naRHY+CPCpJUl+kFf+NjOsw4u1JByQVuy264YqkvsNOQ4tnu60RVb64quX8q6z8Dk2bmfWsJMkk0= X-Gm-Message-State: AOJu0YyA8MlWjf1JM2KVIj3tgsF3cVYUe0M+kRLE6WnroMLhYZ6aUr9X 0aUee+dVP5FNrLvKNruPaTHzYJzyT2GAIlUb8+mL6i3kP/HqFcFAt/m6LfIVNDqwiysIHfMpiW2 9DM+OrcyphNy/aq0zcFFQcProBgaMpugKYmFR X-Google-Smtp-Source: AGHT+IHkqwLDmMwisBUlYqly3IY+Jed4wbbtMynXDwFYS2NfXCme5W8JAX2D2RnLewOdSpC3yj+z5cR0FhDtpe9fyd4= X-Received: by 2002:a2e:a281:0:b0:2d7:21f:90ef with SMTP id k1-20020a2ea281000000b002d7021f90efmr10381544lja.1.1712156360386; Wed, 03 Apr 2024 07:59:20 -0700 (PDT) MIME-Version: 1.0 References: <20240326235909.25276-1-mpazdan@arista.com> <20240403135953.7209-1-mpazdan@arista.com> <1924573.MyG8hOvIyE@thomas> In-Reply-To: <1924573.MyG8hOvIyE@thomas> From: Marek Pazdan Date: Wed, 3 Apr 2024 16:59:08 +0200 Message-ID: Subject: Re: [PATCH] lib: add get/set link settings interface To: Thomas Monjalon Cc: Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org Content-Type: multipart/alternative; boundary="000000000000a9d37b061532774c" X-Mailman-Approved-At: Wed, 03 Apr 2024 18:09:36 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000a9d37b061532774c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Thomas, Information like advertising: speed, pause, autonegotiation etc. and that same for link partner advertising. I try to mimic ethtool since it's a common, well known and widely used tool so adding an API which provides the same set of information in case the interface is passthrough to dpdk will be useful I think. I've 2 more patches dependent on the one we are discussing now, but I need patchwork id to add dependency information. I need moderator approval for the current patch. Regards, Marek On Wed, Apr 3, 2024 at 4:48=E2=80=AFPM Thomas Monjalon wrote: > 03/04/2024 15:59, Marek Pazdan: > > There are link settings parameters available from PMD drivers level > > which are currently not exposed to the user via consistent interface. > > When interface is available for system level those information can > > be acquired with 'ethtool DEVNAME' (ioctl: ETHTOOL_SLINKSETTINGS/ > > ETHTOOL_GLINKSETTINGS). There are use cases where > > physical interface is passthrough to dpdk driver and is not available > > from system level. Information provided by ioctl carries information > > useful for link auto negotiation settings among others. > > Which information is missing exactly? > Why are you trying to mimic ethtool API? > > Please let's add what is missing instead of adding a full new API. > > > --000000000000a9d37b061532774c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Thomas,

Information=C2=A0like a= dvertising: speed, pause, autonegotiation etc. and that same for link partn= er advertising.=C2=A0
I try to mimic ethtool since it's a com= mon, well known and widely used tool so adding an API which provides the sa= me set of information in case the interface is passthrough to dpdk will be = useful=C2=A0I think.=C2=A0
I've 2 more patches dependent on t= he one we are discussing now, but I need patchwork=C2=A0id to add dependenc= y information. I need moderator approval for the current patch.=C2=A0
=

Regards,
Marek=C2=A0

On Wed, Apr 3, 2024= at 4:48=E2=80=AFPM Thomas Monjalon <thomas@monjalon.net> wrote:
03/04/2024 15:59, Marek Pazdan: >=C2=A0 There are link settings parameters available from PMD drivers le= vel
>=C2=A0 which are currently not exposed to the user via consistent inter= face.
>=C2=A0 When interface is available for system level those information c= an
>=C2=A0 be acquired with 'ethtool DEVNAME' (ioctl: ETHTOOL_SLINK= SETTINGS/
>=C2=A0 ETHTOOL_GLINKSETTINGS). There are use cases where
>=C2=A0 physical interface is passthrough to dpdk driver and is not avai= lable
>=C2=A0 from system level. Information provided by ioctl carries informa= tion
>=C2=A0 useful for link auto negotiation settings among others.

Which information is missing exactly?
Why are you trying to mimic ethtool API?

Please let's add what is missing instead of adding a full new API.


--000000000000a9d37b061532774c--