From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A54BE41C32; Tue, 7 Feb 2023 19:18:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 891EB4021F; Tue, 7 Feb 2023 19:18:03 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7573A40151 for ; Tue, 7 Feb 2023 19:18:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675793882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZNQLw8bUXbmMCaSS2eui2Ixppb2TX1pdvrHbwdAJjkI=; b=I+DGIJOurGraoRdVPoRnLR1JxZBkQu34Rl5BICKR/GheHh45o7w/mzSHvzLIDd4IC5O0Ra w6qkIKzZFFvwK/Nr+TsgEooy90NqXdFNZIv84NAP0IOCPM9QoVnS89hpdbrGXTi/du5ulf 5Z+V2ZB1BCrk3sy/g61tK6K00HcBcNg= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-163-3jO-y5qDM9ynX_iTtUzE6w-1; Tue, 07 Feb 2023 13:17:59 -0500 X-MC-Unique: 3jO-y5qDM9ynX_iTtUzE6w-1 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-527a0ebf1f3so83172957b3.12 for ; Tue, 07 Feb 2023 10:17:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZNQLw8bUXbmMCaSS2eui2Ixppb2TX1pdvrHbwdAJjkI=; b=wa8Wlg1yqRbtbsJibJM2ZjvTKbfFwuCCZSbhFl8EO0pmXc8WyrhKasoSyjmdw/CoGi y3YZweFpBofmk/CkFOsgPwzLbh+4Vy20bWvS/sYtpaXSls3+/icqNsboWPtslPA+VQ8s QYp/sGAO92JdY9jD+UvfsusI88x0UQ5DFkPMyCg7ANbeQf73Flx7VzSeWJxk5osEIJpg 65MWD07pHURaiDtv8WVQvcgHnlQmhidwzhdU9fX0gyYnjx+VhI53Oo26s70MP+HJRl6Y WswgV5Nlzplldda1mCoBPAst2ymoA0iDd4jWSIXoe/bdZO6GMO3K2ZG1Kc2/eezTPemo Ygqg== X-Gm-Message-State: AO0yUKUQ6vCX2rFfdVZjBRYvJRfJU99RNVoTcuAlgvo0ZBiXZqISt9nT S9yZe/mMmkuF67nhlHhWKgsO+WcCHIW+Vbsp7plDriPGvtYXD0ZoMjoL8r/prqt5L4ZMsr8jwbG I0wLbloJCcdaRVHvuvgQ= X-Received: by 2002:a25:9187:0:b0:8b5:8870:87fe with SMTP id w7-20020a259187000000b008b5887087femr236991ybl.216.1675793879338; Tue, 07 Feb 2023 10:17:59 -0800 (PST) X-Google-Smtp-Source: AK7set8dGG2rHDoC9ugUzmUOoX7hpYqtajVZYu51VV1QlZ74oGlZAyMwDliwMfCZBYrcbTE/tIDAkTWsfmkwO/fM9Vg= X-Received: by 2002:a25:9187:0:b0:8b5:8870:87fe with SMTP id w7-20020a259187000000b008b5887087femr236986ybl.216.1675793879141; Tue, 07 Feb 2023 10:17:59 -0800 (PST) MIME-Version: 1.0 References: <20230207151747.245808-1-maxime.coquelin@redhat.com> <20230207151747.245808-21-maxime.coquelin@redhat.com> In-Reply-To: <20230207151747.245808-21-maxime.coquelin@redhat.com> From: Eugenio Perez Martin Date: Tue, 7 Feb 2023 19:17:23 +0100 Message-ID: Subject: Re: [PATCH v2 20/21] net/virtio-user: advertize control VQ support with vDPA To: Maxime Coquelin Cc: dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com, stephen@networkplumber.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 7, 2023 at 4:18 PM Maxime Coquelin wrote: > > This patch advertizes control virtqueue support by the vDPA > backend if it supports VIRTIO_NET_F_CTRL_VQ. > > Signed-off-by: Maxime Coquelin > Reviewed-by: Chenbo Xia Acked-by: Eugenio P=C3=A9rez > --- > drivers/net/virtio/virtio_user/vhost_vdpa.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/virtio/virtio_user/vhost_vdpa.c b/drivers/net/vi= rtio/virtio_user/vhost_vdpa.c > index 3fd13d9fac..7bb4995893 100644 > --- a/drivers/net/virtio/virtio_user/vhost_vdpa.c > +++ b/drivers/net/virtio/virtio_user/vhost_vdpa.c > @@ -135,8 +135,8 @@ vhost_vdpa_get_features(struct virtio_user_dev *dev, = uint64_t *features) > return -1; > } > > - /* Multiqueue not supported for now */ > - *features &=3D ~(1ULL << VIRTIO_NET_F_MQ); > + if (*features & 1ULL << VIRTIO_NET_F_CTRL_VQ) > + dev->hw_cvq =3D true; > > /* Negotiated vDPA backend features */ > ret =3D vhost_vdpa_get_protocol_features(dev, &data->protocol_fea= tures); > -- > 2.39.1 >