From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f174.google.com (mail-ig0-f174.google.com [209.85.213.174]) by dpdk.org (Postfix) with ESMTP id 6428B7F60 for ; Thu, 20 Nov 2014 13:27:18 +0100 (CET) Received: by mail-ig0-f174.google.com with SMTP id hn15so4655322igb.13 for ; Thu, 20 Nov 2014 04:37:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=vDN0XNq9dJ1GXY9395wHgu/4KdKrOZrQuWQkoxc6FCI=; b=DcmiUp2RIOddCKsolojmJ12q3lKBP+FcM0vmD7xV0KRiV7/OC+GGzHCNVwREiN8xFp 6ERhmPRz8qP6rbZYQDtYIgwlrxvgH9hYHC3KRo324VqGK5WChFXNIm8BCxYkE/CeBYb4 BI3NQgLyckDdk2wQMRfoM3f71u5vNXZomjKBQkok9BW3J9iEmFsp+7AirQFms2clGtyx s+Yljw698MifyKvlCeHZ6LVNsInSfFGEf+TW3wTH7HgGB3ls3Jcd/WnOgrXChFmdPREO QTqi8+3Tw7VdrgqXrHalGe4JO5C3BwQSyGfnJLTxhBAX90PhiexfVzMwAZVlnpd+Uq1m TfMQ== X-Received: by 10.107.129.101 with SMTP id c98mr6217611iod.35.1416487067810; Thu, 20 Nov 2014 04:37:47 -0800 (PST) MIME-Version: 1.0 Sender: tapiotallgren@gmail.com Received: by 10.50.240.133 with HTTP; Thu, 20 Nov 2014 04:37:27 -0800 (PST) In-Reply-To: <6470390.sH3U320kkz@xps13> References: <20141120111727.GA2609@hmsreliant.think-freely.org> <6470390.sH3U320kkz@xps13> From: Tapio Tallgren Date: Thu, 20 Nov 2014 14:37:27 +0200 X-Google-Sender-Auth: 31HMqFHOG1oOXQdWqPSFvjVq3Kk Message-ID: To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] Newbie question: compiling virtio-net-pmd v1.2 fails with dpdk 1.7 on a VM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Nov 2014 12:27:18 -0000 On Thu, Nov 20, 2014 at 1:33 PM, Thomas Monjalon wrote: > 2014-11-20 06:17, Neil Horman: > > On Thu, Nov 20, 2014 at 09:14:35AM +0200, Tapio Tallgren wrote: > > > Looks like a version conflict? Dpdk 1.7 should support virtio-pmd so > what > > > am I doing wrong? > > > > Nothing, its a bug. DPDK changed the API here with commit > > 9aaccf1abdb2894ec23870e1d2199a657f85850e but it never got changed in the > > virtio_user pmd. You need to modify the pmd like the other call sites > have been > > in the above commit. > > > > This is why those external pmds need to be merged into the dpdk tree. > > Yes, exactly. > We'll see during 2.0 cycle how to merge them. The ideal plan is to keep > only > 1 implementation. > > In the meantime, patches are welcome. > > -- > Thomas > This looks like a purely cosmetic change? So, if the code compiles, then it will also run correctly? -- -Tapio