DPDK patches and discussions
 help / color / mirror / Atom feed
From: Patrick Robb <probb@iol.unh.edu>
To: Andrew Bailey <abailey@iol.unh.edu>
Cc: dev@dpdk.org, dmarx@iol.unh.edu, luca.vizzarro@arm.com
Subject: Re: [PATCH v1] dts: automate VFIO-PCI modprobe
Date: Fri, 21 Nov 2025 16:08:22 -0500	[thread overview]
Message-ID: <CAJvnSUA-g8b8yWakMo4-WOwGncsk5FnO-5aw49va-1-VSg=xoA@mail.gmail.com> (raw)
In-Reply-To: <20251121210650.328804-1-abailey@iol.unh.edu>

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

I think there is a missing check for if ports is None (user is not
providing ports, trying to only run NO_LINKS tests).

On Fri, Nov 21, 2025 at 4:06 PM Andrew Bailey <abailey@iol.unh.edu> wrote:

> Currently, users must modprobe vfio-pci before running DTS when using a
> non-mellanox NIC. This patch automates the process on test run start up.
>
> Signed-off-by: Andrew Bailey <abailey@iol.unh.edu>
> ---
>  dts/framework/test_run.py | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/dts/framework/test_run.py b/dts/framework/test_run.py
> index ff0a12c9ce..38f9e6c07d 100644
> --- a/dts/framework/test_run.py
> +++ b/dts/framework/test_run.py
> @@ -347,6 +347,10 @@ def next(self) -> State | None:
>          test_run.ctx.dpdk.setup()
>          test_run.ctx.topology.setup()
>
> +        if test_run.ctx.sut_node.ports[0].config.os_driver_for_dpdk ==
> "vfio-pci":
> +            test_run.ctx.sut_node.main_session.send_command("modprobe
> vfio")
> +            test_run.ctx.sut_node.main_session.send_command("modprobe
> vfio-pci")
> +
>          if test_run.config.use_virtual_functions:
>              test_run.ctx.topology.instantiate_vf_ports()
>
> --
> 2.50.1
>
>

[-- Attachment #2: Type: text/html, Size: 1700 bytes --]

      reply	other threads:[~2025-11-21 21:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-21 21:06 Andrew Bailey
2025-11-21 21:08 ` Patrick Robb [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJvnSUA-g8b8yWakMo4-WOwGncsk5FnO-5aw49va-1-VSg=xoA@mail.gmail.com' \
    --to=probb@iol.unh.edu \
    --cc=abailey@iol.unh.edu \
    --cc=dev@dpdk.org \
    --cc=dmarx@iol.unh.edu \
    --cc=luca.vizzarro@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).