From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B81543E3C; Thu, 11 Apr 2024 07:01:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8410402A8; Thu, 11 Apr 2024 07:01:21 +0200 (CEST) Received: from mail-oo1-f43.google.com (mail-oo1-f43.google.com [209.85.161.43]) by mails.dpdk.org (Postfix) with ESMTP id F3C52402A7 for ; Thu, 11 Apr 2024 07:01:20 +0200 (CEST) Received: by mail-oo1-f43.google.com with SMTP id 006d021491bc7-5aa1b7a37b3so2690725eaf.0 for ; Wed, 10 Apr 2024 22:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1712811680; x=1713416480; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=73BwUlXk+dF9lbFuIDMJnxZ94TjWzmQXbiIBBxE6wDw=; b=JbSXdKCD5Y4zrKZMAQD5vC48BlERcbwB1EUIDfljgDbEgUptMhiXoBgj0vlde5Ic3p Iedkk/NPMKmuqLQm/X4OEduzveFgUf/wBjFBRXE6r3yvzwoc1zdq3aYRvNgxkHdJ4lJP dfoq8l+PRSl1APIJo56eh8rAdQEx4mvGG8WWY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712811680; x=1713416480; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=73BwUlXk+dF9lbFuIDMJnxZ94TjWzmQXbiIBBxE6wDw=; b=KA3+s2a3EmCeo+7FbshM+tGOr6CJvpnjuwA/cHxwHZZh5J9qvYfxUmCgYra0Mog6Cw 1mgUx3ZSpaEl1RvHpjiMq9YiSadiOd2UTHXobARl2Cy5LKl5Xe1JNUM429x26ahhcRYx CNrvPAaBCddSZvlIAYKbhQE7RZboBdqC2QCpzN+jQGG6AqmkNMTKk76Nm4kUwPtS3FJt ZVQ7CsooYEC6cjfV0SPc8zaovbfnZnhL+7QyvBkggh4rEKv3F4LmTWEtlHOI/Q2syAPC Bw1FPGHHmHw86F9xxnxy3Xg3AhfkXbnmgM0pEwmfFWGsXFyXPGJnw46hdDcma0IKdLa3 7aLw== X-Gm-Message-State: AOJu0Yxn7Nf+9UIYiYfwhPJaCUIwSDx7b7k8PKOR5a+FKe/l82K4XsBz DWb998yFj6ekv3c2eGOQsF7o4S1TlWOCVDMmAjJNApiB0PP5zzWoNGNxK2yVEaV28FMLdfClEfW gCFCIQ3OyL6mktqXUhM58rOp9B4fHHBV5yZkurw== X-Google-Smtp-Source: AGHT+IGumq/p3FVPCev7zlpiZFqCmz2avlvILelCSJhxl688K/wFTne5iN27lmY/ZIH2Nue2oFkUQur2Y11aEoKBJns= X-Received: by 2002:a05:6870:c6a7:b0:21e:e476:9170 with SMTP id cv39-20020a056870c6a700b0021ee4769170mr4736816oab.43.1712811680017; Wed, 10 Apr 2024 22:01:20 -0700 (PDT) MIME-Version: 1.0 References: <1712076948-25853-1-git-send-email-roretzla@linux.microsoft.com> <1712168600-17289-1-git-send-email-roretzla@linux.microsoft.com> <1712168600-17289-2-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1712168600-17289-2-git-send-email-roretzla@linux.microsoft.com> From: Patrick Robb Date: Thu, 11 Apr 2024 01:01:09 -0400 Message-ID: Subject: Re: [PATCH v2] build: exclude rather than include libs in MSVC build To: Tyler Retzlaff Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Andrew Rybchenko , Bruce Richardson , Chengwen Feng , Honnappa Nagarahalli , Kevin Laatz , Srikanth Yalavarthi , Vladimir Medvedkin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Recheck-request: iol-intel-Functional On Wed, Apr 3, 2024 at 2:23=E2=80=AFPM Tyler Retzlaff wrote: > > Some libraries that could be built with MSVC were not being built. > > Switch from explicit include to exclude of libs to get immediate CI > coverage of libraries that already work with MSVC Windows builds. > > Signed-off-by: Tyler Retzlaff > Acked-by: Stephen Hemminger > --- > lib/argparse/meson.build | 6 ++++++ > lib/dmadev/meson.build | 6 ++++++ > lib/fib/meson.build | 6 ++++++ > lib/lpm/meson.build | 6 ++++++ > lib/mbuf/meson.build | 6 ++++++ > lib/mempool/meson.build | 6 ++++++ > lib/meson.build | 10 ---------- > lib/mldev/meson.build | 6 ++++++ > lib/rcu/meson.build | 6 ++++++ > lib/stack/meson.build | 6 ++++++ > 10 files changed, 54 insertions(+), 10 deletions(-) > > diff --git a/lib/argparse/meson.build b/lib/argparse/meson.build > index b6a08ca..8ab4c40 100644 > --- a/lib/argparse/meson.build > +++ b/lib/argparse/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2024 HiSilicon Limited. > > +if is_ms_compiler > + build =3D false > + reason =3D 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources =3D files('rte_argparse.c') > headers =3D files('rte_argparse.h') > > diff --git a/lib/dmadev/meson.build b/lib/dmadev/meson.build > index 62b0650..e66dcb6 100644 > --- a/lib/dmadev/meson.build > +++ b/lib/dmadev/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2021 HiSilicon Limited. > > +if is_ms_compiler > + build =3D false > + reason =3D 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources =3D files('rte_dmadev.c', 'rte_dmadev_trace_points.c') > headers =3D files('rte_dmadev.h') > indirect_headers +=3D files('rte_dmadev_core.h', 'rte_dmadev_trace_fp.h'= ) > diff --git a/lib/fib/meson.build b/lib/fib/meson.build > index ddcae06..6795f41 100644 > --- a/lib/fib/meson.build > +++ b/lib/fib/meson.build > @@ -2,6 +2,12 @@ > # Copyright(c) 2018 Vladimir Medvedkin > # Copyright(c) 2019 Intel Corporation > > +if is_ms_compiler > + build =3D false > + reason =3D 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources =3D files('rte_fib.c', 'rte_fib6.c', 'dir24_8.c', 'trie.c') > headers =3D files('rte_fib.h', 'rte_fib6.h') > deps +=3D ['rib'] > diff --git a/lib/lpm/meson.build b/lib/lpm/meson.build > index 4cd4888..ae30f80 100644 > --- a/lib/lpm/meson.build > +++ b/lib/lpm/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > +if is_ms_compiler > + build =3D false > + reason =3D 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources =3D files('rte_lpm.c', 'rte_lpm6.c') > headers =3D files('rte_lpm.h', 'rte_lpm6.h') > # since header files have different names, we can install all vector hea= ders > diff --git a/lib/mbuf/meson.build b/lib/mbuf/meson.build > index 0435c5e..2cee905 100644 > --- a/lib/mbuf/meson.build > +++ b/lib/mbuf/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > +if is_ms_compiler > + build =3D false > + reason =3D 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources =3D files( > 'rte_mbuf.c', > 'rte_mbuf_ptype.c', > diff --git a/lib/mempool/meson.build b/lib/mempool/meson.build > index 8099a56..acce66c 100644 > --- a/lib/mempool/meson.build > +++ b/lib/mempool/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > +if is_ms_compiler > + build =3D false > + reason =3D 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > extra_flags =3D [] > > foreach flag: extra_flags > diff --git a/lib/meson.build b/lib/meson.build > index 179a272..94d2b72 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -68,16 +68,6 @@ libraries =3D [ > 'node', > ] > > -if is_ms_compiler > - libraries =3D [ > - 'log', > - 'kvargs', > - 'telemetry', > - 'eal', > - 'ring', > - ] > -endif > - > always_enable =3D [ > 'cmdline', > 'eal', > diff --git a/lib/mldev/meson.build b/lib/mldev/meson.build > index 0079ccd..2c933ba 100644 > --- a/lib/mldev/meson.build > +++ b/lib/mldev/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright (c) 2022 Marvell. > > +if is_ms_compiler > + build =3D false > + reason =3D 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources =3D files( > 'rte_mldev_pmd.c', > 'rte_mldev.c', > diff --git a/lib/rcu/meson.build b/lib/rcu/meson.build > index 09abc52..71143f5 100644 > --- a/lib/rcu/meson.build > +++ b/lib/rcu/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2018 Arm Limited > > +if is_ms_compiler > + build =3D false > + reason =3D 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources =3D files('rte_rcu_qsbr.c') > headers =3D files('rte_rcu_qsbr.h') > > diff --git a/lib/stack/meson.build b/lib/stack/meson.build > index 18177a7..7631a14 100644 > --- a/lib/stack/meson.build > +++ b/lib/stack/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2019 Intel Corporation > > +if is_ms_compiler > + build =3D false > + reason =3D 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources =3D files('rte_stack.c', 'rte_stack_std.c', 'rte_stack_lf.c') > headers =3D files('rte_stack.h') > # subheaders, not for direct inclusion by apps > -- > 1.8.3.1 >