From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1863146144; Thu, 30 Jan 2025 06:34:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A521A40156; Thu, 30 Jan 2025 06:34:42 +0100 (CET) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 4D75A400D6 for ; Thu, 30 Jan 2025 06:34:41 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2ef8c012913so463810a91.3 for ; Wed, 29 Jan 2025 21:34:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1738215280; x=1738820080; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=S+i3Ws2NG/DJo+90sBKamcMlZGF4xw8EHv7VwEpoYns=; b=S2Kr2GdkqZoAtVcx3jm7D3hv7SCNf+su7rouxxIS5jUHDUuMkLidmDntDEcjwrcbVH C5fVBv8r31MYuFZEdwxD3aswApCc8g+zXrEINhn5jC1QJWs7HT0Irfv9RR/D0OUbk9S1 gfxk5sJOcgrmRjgKMeS0rM77FcZiD1i6SASrE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738215280; x=1738820080; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=S+i3Ws2NG/DJo+90sBKamcMlZGF4xw8EHv7VwEpoYns=; b=nJOils9pn7ow6kz17fEBujXogjMWeMOmVqAyJuJsUGMxrtb1t5qOBPuBgYTqjquzx3 JRQpfhhR8+4IE7IkwmXDCzfKDcPy+GAb+CxZKGRgkC9z8DDqie6RQXrogCkOWhw9VyAW q2CCMo9xoWkjWCGCKnMr17OobdU7Mcv9Wzd2i8WSU53Zf3V9JnB331cOyNiC/4GK1bmT Tf2HYVuDyH++nh9NX1F8gS8FZtH/eGB9PMqr36YNdN76sLx2ChYmk7CVCJ91N29fhkVn iwvSHv2uh7CBmpDK+ytadZjywj+wxwHpqqWJyAkJujh8yATUqYkesXHfNiH/d5ZMggVe +tgw== X-Forwarded-Encrypted: i=1; AJvYcCVL/oXeVyRT2jfBO5UThZHNgFmBUmM+Btb9JRw5GFRrjLf9YU9jRuI1BhZEugjCmVjd0Sc=@dpdk.org X-Gm-Message-State: AOJu0YynnjP8Ow4SurU1r5wt8J86TcsTOwgYWn+EGPcZvKw/bjG222r/ EStH3Nsn+1H1f0UQvRsZy8bmF+miuInkzCij8Yl958s+PAgv5F/RImqVkRwAmYAAUXOm7vbxa3M nT1ZGi/SXAUXFwFCtebcbwf9jCADjrd7clDZQ4A== X-Gm-Gg: ASbGnctUfmiBoPeSDpevu10XzS9hIc6WI37vaYZOCXnZqO0YtGUkXtsPBZ7UCP6Ob2s xfQFQ0wTa5vSZE0tJM60bz0Sq0RiCDT5IrTSk5HHLAh4KGPuqntHpJSOi0pdwmYKWsPVKMQ0ECw f91yeuDrzwnXI20Icdzg0IRuUvHNH0MA== X-Google-Smtp-Source: AGHT+IHcjpcsj2YrFwPjjL2jSoXxqytYVY9a1VlzLPB/C+9jjaB/6lskfZKYbn8/xj6x1gX9ZMdE9yqWKp2MZrKDzDY= X-Received: by 2002:a17:90b:1f81:b0:2ee:bc1d:f98b with SMTP id 98e67ed59e1d1-2f83ac8ac3amr7743733a91.31.1738215280433; Wed, 29 Jan 2025 21:34:40 -0800 (PST) MIME-Version: 1.0 References: <20241209205902.18321-1-dmarx@iol.unh.edu> <20241209205902.18321-2-dmarx@iol.unh.edu> In-Reply-To: <20241209205902.18321-2-dmarx@iol.unh.edu> From: Patrick Robb Date: Thu, 30 Jan 2025 00:31:36 -0500 X-Gm-Features: AWEUYZmqNpS1XDC7iFNa1AqTcCokILGwoTq4NLpzmMiJzFpd2IGbc9rhYmjoFeU Message-ID: Subject: Re: [RFC PATCH 1/1] dts: add SUT cleanup to framework To: Dean Marx Cc: npratte@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="000000000000557172062ce5c8a2" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000557172062ce5c8a2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Dec 9, 2024 at 2:58=E2=80=AFPM Dean Marx wrote: > > - sut_node.tear_down_test_run() > + sut_node.tear_down_test_run(test_run_config.dpdk_config) > My first question was why is there a need to pass all of dpdk_config through from here all the way to cleanup_sut()? Is it sufficient to extract dpdk_location from dpdk_config at the beginning here, and pass along just dpdk_location? > tg_node.tear_down_test_run() > test_run_result.update_teardown(Result.PASS) > except Exception as e: > diff --git a/dts/framework/testbed_model/sut_node.py > b/dts/framework/testbed_model/sut_node.py > index 14d77c50a6..d39c1bd632 100644 > --- a/dts/framework/testbed_model/sut_node.py > +++ b/dts/framework/testbed_model/sut_node.py > @@ -175,6 +175,21 @@ def path_to_devbind_script(self) -> PurePath | str: > ) > return self._path_to_devbind_script > > + def cleanup_sut( > + self, dpdk_build_config: DPDKBuildConfiguration, remote_tree: st= r > | PurePath | None > I understand the need for str or PurePath, but can you explain why None is included in the union? > -- > 2.44.0 > > There was also discussion at the previous DTS meeting about appending the datetime to the dpdk artifacts when they're copied over to the SUT (a way to create artifact uniqueness). It's not really within the scope of this patchseries, but it wouldn't hurt for us to touch base - maybe you can do this next. Looks good to me overall. Once you submit the v2 I will leave a little time for other comments, otherwise I will merge. Thanks Dean. --000000000000557172062ce5c8a2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Dec 9, = 2024 at 2:58=E2=80=AFPM Dean Marx <= dmarx@iol.unh.edu> wrote:

-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 sut_node.tear_down= _test_run()
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 sut_node.tear_down= _test_run(test_run_config.dpdk_config)

= My first=C2=A0question was why is there a need to pass all of dpdk_config t= hrough from here all the=C2=A0way to cleanup_sut()? Is it sufficient to ext= ract dpdk_location from dpdk_config at the beginning=C2=A0here, and pass al= ong just dpdk_location?
=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0tg_node.tear_= down_test_run()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0test_run_resu= lt.update_teardown(Result.PASS)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0except Exception as e:
diff --git a/dts/framework/testbed_model/sut_node.py b/dts/framework/testbe= d_model/sut_node.py
index 14d77c50a6..d39c1bd632 100644
--- a/dts/framework/testbed_model/sut_node.py
+++ b/dts/framework/testbed_model/sut_node.py
@@ -175,6 +175,21 @@ def path_to_devbind_script(self) -> PurePath | str:=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return self._path_to_devbind_script

+=C2=A0 =C2=A0 def cleanup_sut(
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self, dpdk_build_config: DPDKBuildConfiguratio= n, remote_tree: str | PurePath | None

I= understand the need for str or PurePath, but can you explain why None is i= ncluded in the union?
=C2=A0
--
2.44.0


There was also discussion at the previ= ous DTS meeting about appending the datetime to the dpdk artifacts when the= y're copied over to the SUT (a way to create artifact uniqueness). It&#= 39;s not really within the scope of this patchseries, but it wouldn't h= urt for us to touch base - maybe you can do this next.=C2=A0

=
Looks good to me overall. Once you submit the v2 I will leave a = little time for other comments, otherwise I will merge.

Thanks Dean.
--000000000000557172062ce5c8a2--