Re: [PATCH v1 1/2] dts: add packet handling and test utilities to API

[Patrick Robb <probb@iol.unh.edu>]

[-- Attachment #1: Type: text/plain, Size: 1889 bytes --]

On Tue, Sep 23, 2025 at 6:38 AM Paul Szczepanek <paul.szczepanek@arm.com>
wrote:

> Split TestSuite methods between test run methods
> and packet related methods.
>
> Depends-on: series-36111 ("Split DTS framework and public API")
>
> Signed-off-by: Paul Szczepanek <paul.szczepanek@arm.com>
> Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
> ---
>  doc/api/dts/api.packet.rst  |   8 +
>  doc/api/dts/api.rst         |   4 +-
>  doc/api/dts/api.test.rst    |   8 +
>  doc/guides/tools/dts.rst    |   2 +-
>  dts/api/packet.py           | 311 ++++++++++++++++++++++++++++++++++++
>  dts/api/test.py             | 126 +++++++++++++++
>  dts/framework/test_suite.py | 305 +----------------------------------
>  7 files changed, 460 insertions(+), 304 deletions(-)
>  create mode 100644 doc/api/dts/api.packet.rst
>  create mode 100644 doc/api/dts/api.test.rst
>  create mode 100644 dts/api/packet.py
>  create mode 100644 dts/api/test.py
>
> diff --git a/dts/api/packet.py b/dts/api/packet.py
> new file mode 100644
> index 0000000000..bf6f3e1be8
> --- /dev/null
> +++ b/dts/api/packet.py
> @@ -0,0 +1,311 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2025 Arm Limited
> +
> +"""Features common to all test suites.
> +
> +The module defines the :class:`TestSuite` class which doesn't contain any
> test cases, and as such
> +must be extended by subclasses which add test cases. The
> :class:`TestSuite` contains the basics
> +needed by subclasses:
> +
> +    * Testbed (SUT, TG) configuration,
> +    * Packet sending and verification,
> +    * Test case verification.
> +"""
>

It looks like this docstring is taken directly from the old test_suite.py
and needs to be updated.


> +
>
>
Looks good overall, I think we can merge when the docstring update is sent.

Reviewed-by: Patrick Robb <probb@iol.unh.edu>

[-- Attachment #2: Type: text/html, Size: 2770 bytes --]