From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C38F645D44;
	Tue, 19 Nov 2024 17:13:37 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5EDF44029B;
	Tue, 19 Nov 2024 17:13:37 +0100 (CET)
Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com
 [209.85.210.176])
 by mails.dpdk.org (Postfix) with ESMTP id CFC724028A
 for <dev@dpdk.org>; Tue, 19 Nov 2024 17:13:35 +0100 (CET)
Received: by mail-pf1-f176.google.com with SMTP id
 d2e1a72fcca58-71ec997ad06so4155155b3a.3
 for <dev@dpdk.org>; Tue, 19 Nov 2024 08:13:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=iol.unh.edu; s=unh-iol; t=1732032815; x=1732637615; darn=dpdk.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=TwFa6VQUfn1ul5eBGrgUvjvjrE2lo3auMBsHWG/+Hpk=;
 b=asdHitM/pkrrzcyQ+pfwUua7WxW3tkcFHdzP862Wkrzllz61x3Jojj8iiU1XbvD7hA
 AuVVqHtBi/VS+3XPash3FxeB+DEjGbzhHqCshP1VVEMk2mO4wj01KAxc/NrfQWBeZ5UA
 l9Dr1UjeZe2FkJPE8tH86y7ZLQY+IQpP5j+uE=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1732032815; x=1732637615;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=TwFa6VQUfn1ul5eBGrgUvjvjrE2lo3auMBsHWG/+Hpk=;
 b=IsZeXPCql0A7dG4JQtA8IMOUeR36cjLI2uADSizs9hR32/zNIX5silQZlXIJd2OpAs
 dXPYA7OC93oj8enTMKbNQgVweWlIZf4qZR2clojSsvolYYxlLBefw02YbSQqujd3PRPI
 I/jo9WzDyOUe1/+YySJTwUYuQjgTswVPqhZGrcrgT2WyRF/qGgekEHD69/yCsAHRLGjx
 QpMO98AtoKQka1P+7iKefafQNAsxLb8t1X+kw9HR2GnlmQMUyqlFPj065zroJICjOVhS
 DNVvtX7s4XfU4ADFrb5diN70YoWsJGtAiKMuLGlwZYUlUIEclVdH/JgbbLH8a4ijBcup
 FK0w==
X-Forwarded-Encrypted: i=1;
 AJvYcCX78ROYOkh824sVwr3/BhD0Y2y6ThCpRdhpeK7ADDATc/F5WhfLzAqUwJB4mz/wXNyHH84=@dpdk.org
X-Gm-Message-State: AOJu0Ywf87Gg2p4vzH5MV2mfGnZ23B6cTLSzi+xvN+j8rF7VIn5bT4/d
 XZetWnq1+4WqeVO1mhONBbtAkMGLcC/tHaYSKEqgAFc3pn1yCz7O0nT2yGycH1VMoq85rsqGXAK
 Zuh/Qq81LSKLpMofr55fh9fVXkSrk0v2uxK5k6Q==
X-Google-Smtp-Source: AGHT+IG+FwiCiUIgDO7ziu8jeQB8egARRy0fM1nhcX6SmQn1S0zdowsp4H8pRu0nW+LTKupCeRyEYJiPr+RFOyn44Xw=
X-Received: by 2002:a05:6a00:238b:b0:71e:4ee1:6d78 with SMTP id
 d2e1a72fcca58-72476b72679mr22143628b3a.1.1732032815075; Tue, 19 Nov 2024
 08:13:35 -0800 (PST)
MIME-Version: 1.0
References: <20241014182320.31125-1-dmarx@iol.unh.edu>
 <20241015191333.12947-1-dmarx@iol.unh.edu>
 <20241015191333.12947-3-dmarx@iol.unh.edu>
In-Reply-To: <20241015191333.12947-3-dmarx@iol.unh.edu>
From: Patrick Robb <probb@iol.unh.edu>
Date: Tue, 19 Nov 2024 11:11:35 -0500
Message-ID: <CAJvnSUAVC322PYRNWq3bOa9npM28ftHd3CiPZX8E-9Y3Hu2qcQ@mail.gmail.com>
Subject: Re: [PATCH v5 2/2] dts: checksum offload test suite
To: Dean Marx <dmarx@iol.unh.edu>
Cc: npratte@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, 
 Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, dev@dpdk.org
Content-Type: multipart/alternative; boundary="000000000000aebc0e06274650d1"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

--000000000000aebc0e06274650d1
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 15, 2024 at 3:13=E2=80=AFPM Dean Marx <dmarx@iol.unh.edu> wrote=
:

>
> +
> +    This suite consists of 6 test cases:
> +    1. Insert checksum on transmit packet
> +    2. Do not insert checksum on transmit packet
> +    3. Hardware checksum check L4 Rx
> +    4. Hardware checksum check L3 Rx
> +    5. Validate Rx checksum valid flags
> +    6. Checksum offload with vlan
>

In your V5 you forgot to add the SCTP offload testcase to the list above. I
will update the commit before applying to next-dts.

Reviewed-by: Patrick Robb <probb@iol.unh.edu>

--000000000000aebc0e06274650d1
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, Oct 15, 2024 at 3:13=E2=80=AF=
PM Dean Marx &lt;<a href=3D"mailto:dmarx@iol.unh.edu">dmarx@iol.unh.edu</a>=
&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px =
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
+<br>
+=C2=A0 =C2=A0 This suite consists of 6 test cases:<br>
+=C2=A0 =C2=A0 1. Insert checksum on transmit packet<br>
+=C2=A0 =C2=A0 2. Do not insert checksum on transmit packet<br>
+=C2=A0 =C2=A0 3. Hardware checksum check L4 Rx<br>
+=C2=A0 =C2=A0 4. Hardware checksum check L3 Rx<br>
+=C2=A0 =C2=A0 5. Validate Rx checksum valid flags<br>
+=C2=A0 =C2=A0 6. Checksum offload with vlan<br></blockquote><div><br></div=
><div>In your V5 you forgot to add the SCTP offload testcase to the list ab=
ove. I will update the commit before applying to next-dts.</div><div><br></=
div><div>Reviewed-by: Patrick Robb &lt;<a href=3D"mailto:probb@iol.unh.edu"=
>probb@iol.unh.edu</a>&gt;</div><div>=C2=A0</div></div></div>

--000000000000aebc0e06274650d1--