From: Patrick Robb <probb@iol.unh.edu>
To: Luca Vizzarro <luca.vizzarro@arm.com>
Cc: Andrew Bailey <abailey@iol.unh.edu>,
dev@dpdk.org, dmarx@iol.unh.edu, ivan.malov@arknetworks.am
Subject: Re: [PATCH v2 1/3] dts: allow mbuf_fast_free to be set with testpmd shell
Date: Thu, 4 Sep 2025 17:18:52 -0400 [thread overview]
Message-ID: <CAJvnSUAZbF6JmGqMVo7dgOwxv=TOPKuZSix-9n4phHZ=vr9Chg@mail.gmail.com> (raw)
In-Reply-To: <175699757148.86363.18113785073209751856.luca.vizzarro@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]
On Thu, Sep 4, 2025 at 11:16 AM Luca Vizzarro <luca.vizzarro@arm.com> wrote:
> On Wed, Sep 03, 2025 at 02:04:12PM +0000, Andrew Bailey wrote:
> > diff --git a/dts/framework/remote_session/testpmd_shell.py
> b/dts/framework/remote_session/testpmd_shell.py
> > index ad8cb273dc..4d9caceb37 100644
> > --- a/dts/framework/remote_session/testpmd_shell.py
> > +++ b/dts/framework/remote_session/testpmd_shell.py
> > @@ -19,7 +19,7 @@
> > import time
> > from collections.abc import Callable, MutableSet
> > from dataclasses import dataclass, field
> > -from enum import Flag, auto
> > +from enum import Enum, Flag, auto
> > from os import environ
> > from pathlib import PurePath
> > from typing import TYPE_CHECKING, Any, ClassVar, Concatenate, Literal,
> ParamSpec, Tuple, TypeAlias
> > @@ -344,6 +344,13 @@ def make_parser(cls) -> ParserFn:
> > )
> >
> >
> > +class RxTxArgFlag(Enum):
>
> this could be StrEnum given the values used. Moreover, is it a
> flag? Looks like a regular enum to me.
>
I was wondering the same but no, by my understanding it's currently an enum
or StrEnum and I can't see us adding additional attributes in the future so
that won't be changing.
[-- Attachment #2: Type: text/html, Size: 1701 bytes --]
next prev parent reply other threads:[~2025-09-04 21:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 14:27 [PATCH v1 0/3] dts: add tx_offload support in dts Andrew Bailey
2025-09-02 14:27 ` [PATCH v1 1/3] dts: allow mbuf_fast_free to be set with testpmd shell Andrew Bailey
2025-09-02 19:37 ` Ivan Malov
2025-09-02 19:48 ` Ivan Malov
2025-09-02 14:27 ` [PATCH v1 2/3] dts: add TX offload capabilities to NIC capabilities Andrew Bailey
2025-09-04 14:43 ` Luca Vizzarro
2025-09-04 14:45 ` Luca Vizzarro
2025-09-02 14:27 ` [PATCH v1 3/3] dts: update tx_offload test from old dts Andrew Bailey
2025-09-03 18:04 ` [PATCH v2 0/3] dts: add tx_offlaod support in dts Andrew Bailey
2025-09-03 18:04 ` [PATCH v2 1/3] dts: allow mbuf_fast_free to be set with testpmd shell Andrew Bailey
2025-09-04 15:15 ` Luca Vizzarro
2025-09-04 21:18 ` Patrick Robb [this message]
2025-09-03 18:04 ` [PATCH v2 2/3] dts: add TX offload capabilities to NIC capabilities Andrew Bailey
2025-09-03 18:36 ` Patrick Robb
2025-09-04 14:47 ` Luca Vizzarro
2025-09-03 18:04 ` [PATCH v2 3/3] dts: update tx_offload test from old dts Andrew Bailey
2025-09-04 15:25 ` Luca Vizzarro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJvnSUAZbF6JmGqMVo7dgOwxv=TOPKuZSix-9n4phHZ=vr9Chg@mail.gmail.com' \
--to=probb@iol.unh.edu \
--cc=abailey@iol.unh.edu \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=ivan.malov@arknetworks.am \
--cc=luca.vizzarro@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).