From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C7A045CA8; Thu, 7 Nov 2024 01:53:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30F41402AC; Thu, 7 Nov 2024 01:53:56 +0100 (CET) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id 0EAAD40280 for ; Thu, 7 Nov 2024 01:53:55 +0100 (CET) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-723f37dd76cso351506b3a.0 for ; Wed, 06 Nov 2024 16:53:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1730940834; x=1731545634; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=srRzMDFygX3P419IG/hmoADXAEHZVn/HccLlTr3L0/A=; b=R4lpwX7Y9k1AA+ixUf80MGeytDPd5quxRQc+mqx+WtDpV68P9nGU0odZRtS9I3y5SN aWEa80EyLcuNFxPAQiP028OF5+ygFj9XVJxMzBj9uMcYdu343iWcvElePE4iZT1abycO jj3/ARlm1HO76Ct8YyzYk1GwkJCk1st6s/Evw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730940834; x=1731545634; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=srRzMDFygX3P419IG/hmoADXAEHZVn/HccLlTr3L0/A=; b=nNQnnCX+jsOFR+00eh8wkFV/D10V2kIJmEhSFraYvoUQTdybd/q1Wc4k36+49CBxeD d9il9ywhL+tYnSMU6kNhyb3pOycgTRwhJIX3S95VEBp8Iw8ef1cSWhaJUdxBNIp4V8hy 8za0sFVD7Ay5fHveyIJyNrIgh+ztkH/ZRK+9dwv1V1ZCIrsaZb6Np/eeV/ZJs8+kPKhA 3rrfAalVwaZGj2OWBSN6dh9E8FQRnAMS+woIRl+bhGNsq155SRCJ/nO+mXBZLx1c0apu F8M1EJ81B1bx1r9bkJQnDwEFM7Y8OFJiPuFgpqwR+ZnBxwoyRKw8ko2Sf963SFnLYhyP l0Dg== X-Forwarded-Encrypted: i=1; AJvYcCUjs8Cd3ZfZwq1lxj8PkEhl8V+DLhXDQlweAa0wJ8X5AgNRNf1jVL61l46FhTRCDWBLxJc=@dpdk.org X-Gm-Message-State: AOJu0Yz+PAcraJoz3JkX0/m6/TD2zdNziwdSosIPo22WUdhhNhGxeoy6 /MwmQdR2UjS9/kB18VMrpLcB0UNSD3tueVIS0N5q2vvAiYmClDVKKmXX6VX0slGciz2zd64G/Rk SYqwXTEfoDcvVN7LRv99Ua8taXViO6SK6Qa9z7g== X-Google-Smtp-Source: AGHT+IENlu7OIp6OYH13qfMAH+PIbJzCNkXH9eOq7DpYWRvXZ1wDbfBVdiZCLeJOPHbkvT087khaUQxVvWAa5zfs25U= X-Received: by 2002:a05:6a20:a114:b0:1db:ddba:8795 with SMTP id adf61e73a8af0-1dc1295768cmr485293637.36.1730940834136; Wed, 06 Nov 2024 16:53:54 -0800 (PST) MIME-Version: 1.0 References: <20240812142355.12532-1-dmarx@iol.unh.edu> <20241010184226.4088-1-dmarx@iol.unh.edu> In-Reply-To: <20241010184226.4088-1-dmarx@iol.unh.edu> From: Patrick Robb Date: Wed, 6 Nov 2024 19:52:06 -0500 Message-ID: Subject: Re: [PATCH v2] dts: fix verify argument in set forward mode To: Dean Marx Cc: npratte@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="0000000000008be86a0626481151" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000008be86a0626481151 Content-Type: text/plain; charset="UTF-8" Thanks Dean. I reworded the commit message to "Condition set_forward_mode verify code on the verify argument, which was originally omitted" because I think even with a tiny bugfix, we want to explain for the commit history what the commit is doing, instead of a vague "this is a bugfix" type message. Thanks, applied. --0000000000008be86a0626481151 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks Dean. I reworded the commit message to "Condit= ion set_forward_mode verify code on the verify argument, which was original= ly omitted" because I think even with a tiny bugfix, we want to explai= n for the commit history what the commit is doing, instead of a vague "= ;this is a bugfix" type message.

Thanks, applied.
--0000000000008be86a0626481151--