From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88E0541D9D; Tue, 28 Feb 2023 15:42:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1DD17410D4; Tue, 28 Feb 2023 15:42:25 +0100 (CET) Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) by mails.dpdk.org (Postfix) with ESMTP id B12674021F for ; Tue, 28 Feb 2023 15:42:23 +0100 (CET) Received: by mail-oi1-f175.google.com with SMTP id r40so7162825oiw.0 for ; Tue, 28 Feb 2023 06:42:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KmWpN8MYRV0i7beENkQ/Li0ZLzFl9TvBmNL8jM+qUsU=; b=RppkoX8ZUAKkheJO0kqmIfZHq+Ixz3UKsT2UzEIyl3BP8v4WRC7kLEgOumkTzMnqnl OURmjRy51edLXG16+BNsUmZVYO4jxgX9y9Z0Vs31yCHJHdaAU56+UoFsdgko2DbLBrdv 3aFRiR3UwZ235hL8iZ+rMOXZ1V+7H/wwsFDhM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KmWpN8MYRV0i7beENkQ/Li0ZLzFl9TvBmNL8jM+qUsU=; b=jquOm6rkZISD5HXfP+yf66WQDLNwSYdPovu0ORrKeSuSlrCStEgnW+HIeZ8Jy47nr9 FJKzrpLlMeKGtvxUmYoDI/Cs9nJtfkDK1m+sjMYebw7kVGpg0eCdNCLRImQ8M6AiuyeR uGIDq70pXqtwn3j3aAGwe0T9UF7/O/cNgDf9TdrUtGJuPHPv/GQ0hO+lBfuLOgGunaMy dQdK3SwgFyXPwvrXFGjkGoM5QJEjVGF1z0c7GTssZZ8XS5jmXRZ31jNGBySpexqqQiqx hbBHJ3uN73MzLHmL17wMmRBzIHmNX3TWDww4LhU8o6hmWWnqTEqgAzFqp48tb3ZRSoeb PJ+Q== X-Gm-Message-State: AO0yUKVspO2DP8d/df/44Iqcw2iJNNRvy3+rKVCHa0hLlvN68ey4DF6v TZMjW9Y6fqSFgLGuvtT/v5kO3o8X7Osn5v8gsHjDdA== X-Google-Smtp-Source: AK7set9v4caMRpSH4xG61AqIq53jK+/YvfnPUvX5KVjZPFie6WRlzzDE1Yf96BnRwb8DBBMU2zzLVmedhTyMg2nc5+k= X-Received: by 2002:a05:6808:646:b0:37f:a3b7:c877 with SMTP id z6-20020a056808064600b0037fa3b7c877mr1019372oih.8.1677595342823; Tue, 28 Feb 2023 06:42:22 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Patrick Robb Date: Tue, 28 Feb 2023 09:42:11 -0500 Message-ID: Subject: Re: [v1, 00/10] fips_validation application improvements To: Akhil Goyal Cc: "Dooley, Brian" , Gowrishankar Muthukrishnan , "dev@dpdk.org" , Anoob Joseph , Jerin Jacob Kollanukkaran , Jeremy Spewock , Lincoln Lavoie Content-Type: multipart/alternative; boundary="0000000000007c7f7405f5c39af1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000007c7f7405f5c39af1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Akhil and Gowrishankar, We saw the same issue with running the fips sample app under CI testing here at the UNH Community Lab: http://mails.dpdk.org/archives/test-report/2023-February/350635.html. We reported a warn because it failed on the compilation stage (as opposed to a failure of the actual sample app run). On the other hand, we are excited to see this patch again with the compilation part resolved. I sent an email to the dev mailing list a few weeks ago for our fips sample app CI testing regarding where we could and could not provide test vector coverage, and it appears this patch series may resolve our ciphertext issue with AES-GCM test vector and more issues with the sample app. So - looking forward to seeing a patch like this being merged when stable! Best, Patrick Robb On Tue, Feb 28, 2023 at 2:39=E2=80=AFAM Akhil Goyal wr= ote: > Hi Gowrishankar, > > > > > > > Subject: [v1, 00/10] fips_validation application improvements > > > > > > > > This patch series adds support for SHA3, SHAKE, AES-CCM JSON test > vectors > > > > and fixes existing algorithms to support NIST test vectors. > > > > > > > > Gowrishankar Muthukrishnan (10): > > > > examples/fips_validation: fix MCT output for SHA > > > > examples/fips_validation: add SHA3 validation > > > > examples/fips_validation: fix integer parse in test case > > > > examples/fips_validation: add SHAKE validation > > > > examples/fips_validation: add CCM JSON validation > > > > examples/fips_validation: add ECDSA keygen support > > > > examples/fips_validation: add SHA3 algorithms in ECDSA test > > > > examples/fips_validation: fix AES GCM validation tests > > > > examples/fips_validation: fix AES XTS to read seq number > > > > examples/fips_validation: add extra space in JSON buffer > > > > > > > > doc/guides/sample_app_ug/fips_validation.rst | 7 +- > > > > examples/fips_validation/fips_validation.c | 31 ++- > > > > examples/fips_validation/fips_validation.h | 10 +- > > > > .../fips_validation/fips_validation_ccm.c | 132 ++++++++++++ > > > > .../fips_validation/fips_validation_ecdsa.c | 56 +++++ > > > > .../fips_validation/fips_validation_gcm.c | 12 +- > > > > .../fips_validation/fips_validation_hmac.c | 8 + > > > > .../fips_validation/fips_validation_sha.c | 91 ++++++-- > > > > .../fips_validation/fips_validation_xts.c | 13 +- > > > > examples/fips_validation/main.c | 196 > +++++++++++++----- > > > > 10 files changed, 467 insertions(+), 89 deletions(-) > > > > > > > > -- > > > > 2.25.1 > > > > > > Series-acked-by: Brian Dooley > > > > Series Applied to dpdk-next-crypto > The series is showing compilation issues, please fix it. The series is > removed from the tree. > > > --=20 Patrick Robb Technical Service Manager UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 03824 www.iol.unh.edu --0000000000007c7f7405f5c39af1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Akhil and Gowrishankar,

We saw th= e same issue with running the fips sample app under CI testing here at the = UNH Community Lab:=C2=A0http://mails.dpdk.org/archi= ves/test-report/2023-February/350635.html. We reported a warn because i= t failed on the compilation stage (as opposed to a failure of the actual sa= mple app run).

On the other hand, we are excited to see = this patch again with the compilation part resolved. I sent an email to the= dev mailing list a few weeks ago for our fips sample app CI testing regard= ing where we could and could not provide test vector coverage, and it appea= rs this patch series may resolve our ciphertext issue with AES-GCM test vec= tor and more issues with the sample app. So - looking forward to seeing a p= atch like this being merged when stable!=C2=A0

Bes= t,
Patrick Robb




<= br>

On Tue, Feb 28, 2023 at 2:39=E2=80=AFAM Akhil Goyal <gakhil@marvell.com= > wrote:
Hi G= owrishankar,
> >
> > > Subject: [v1, 00/10] fips_validation application improvement= s
> > >
> > > This patch series adds support for SHA3, SHAKE, AES-CCM JSON= test vectors
> > > and fixes existing algorithms to support NIST test vectors.<= br> > > >
> > > Gowrishankar Muthukrishnan (10):
> > >=C2=A0 =C2=A0examples/fips_validation: fix MCT output for SHA=
> > >=C2=A0 =C2=A0examples/fips_validation: add SHA3 validation > > >=C2=A0 =C2=A0examples/fips_validation: fix integer parse in t= est case
> > >=C2=A0 =C2=A0examples/fips_validation: add SHAKE validation > > >=C2=A0 =C2=A0examples/fips_validation: add CCM JSON validatio= n
> > >=C2=A0 =C2=A0examples/fips_validation: add ECDSA keygen suppo= rt
> > >=C2=A0 =C2=A0examples/fips_validation: add SHA3 algorithms in= ECDSA test
> > >=C2=A0 =C2=A0examples/fips_validation: fix AES GCM validation= tests
> > >=C2=A0 =C2=A0examples/fips_validation: fix AES XTS to read se= q number
> > >=C2=A0 =C2=A0examples/fips_validation: add extra space in JSO= N buffer
> > >
> > >=C2=A0 doc/guides/sample_app_ug/fips_validation.rst=C2=A0 |= =C2=A0 =C2=A07 +-
> > >=C2=A0 examples/fips_validation/fips_validation.c=C2=A0 =C2= =A0 |=C2=A0 31 ++-
> > >=C2=A0 examples/fips_validation/fips_validation.h=C2=A0 =C2= =A0 |=C2=A0 10 +-
> > >=C2=A0 .../fips_validation/fips_validation_ccm.c=C2=A0 =C2=A0= =C2=A0| 132 ++++++++++++
> > >=C2=A0 .../fips_validation/fips_validation_ecdsa.c=C2=A0 =C2= =A0|=C2=A0 56 +++++
> > >=C2=A0 .../fips_validation/fips_validation_gcm.c=C2=A0 =C2=A0= =C2=A0|=C2=A0 12 +-
> > >=C2=A0 .../fips_validation/fips_validation_hmac.c=C2=A0 =C2= =A0 |=C2=A0 =C2=A08 +
> > >=C2=A0 .../fips_validation/fips_validation_sha.c=C2=A0 =C2=A0= =C2=A0|=C2=A0 91 ++++++--
> > >=C2=A0 .../fips_validation/fips_validation_xts.c=C2=A0 =C2=A0= =C2=A0|=C2=A0 13 +-
> > >=C2=A0 examples/fips_validation/main.c=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 196 +++++++++++++-----
> > >=C2=A0 10 files changed, 467 insertions(+), 89 deletions(-) > > >
> > > --
> > > 2.25.1
> >
> > Series-acked-by: Brian Dooley <brian.dooley@intel.com>
>
> Series Applied to dpdk-next-crypto
The series is showing compilation issues, please fix it. The series is remo= ved from the tree.




--

Patrick Robb

= Technical = Service Manager

UNH InterOperability Laboratory

21 Madbury Rd, Suite 100, Durham, NH 03824

www.iol.unh.edu


--0000000000007c7f7405f5c39af1--