From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id E8EDF456BD;
Fri, 26 Jul 2024 18:34:38 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id A3CF6410F6;
Fri, 26 Jul 2024 18:34:38 +0200 (CEST)
Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com
[209.85.160.50]) by mails.dpdk.org (Postfix) with ESMTP id EF6AA4064F
for <dev@dpdk.org>; Fri, 26 Jul 2024 18:34:36 +0200 (CEST)
Received: by mail-oa1-f50.google.com with SMTP id
586e51a60fabf-260e3e295a7so830327fac.3
for <dev@dpdk.org>; Fri, 26 Jul 2024 09:34:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=iol.unh.edu; s=unh-iol; t=1722011676; x=1722616476; darn=dpdk.org;
h=content-transfer-encoding:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:from:to:cc:subject:date
:message-id:reply-to;
bh=GDerSRiRTlWF9qsyeI3NfkWSvsGNM3NLq0nRgRE5ytA=;
b=ZwkqsYMFZ1SzpZY5KGjJcRpLsCUE61XxJoc52WcH7oDdUSYwAHXtRZnC5XWalo8PsX
itv7IkUOCoA40d7ms2IZJQI6GqN75W+CvlSJNakd1E1KTGcBykyn/FJSR5griFpHsuqM
RsD9HyJDLqAryVezlIBCKCsY4Mv6GbK0utUiU=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1722011676; x=1722616476;
h=content-transfer-encoding:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=GDerSRiRTlWF9qsyeI3NfkWSvsGNM3NLq0nRgRE5ytA=;
b=df72S8neaynpye7DkqtvSoC0oeCJHJLnPAdXBMoSTTBVeQiQFYXk2Kyc6a0TP9uny3
LGtJ1QfLqG2SQH93nQtNACiiGJRiiHDJOSSEPIVhH0HQ/O4CK+wIreqx65GbCWe6/7gE
xksLqX5pXXx2aHuQ5yeBvzb/Aedg5IO4iC4XC74F7rgawakunkLhCd10EtyFofU0iUND
Gt039/e3bRZp3CEGpKw5jWbP3rwNyn+PKcdd6aXkf9LZSqfMXrRCMm5YHnAwLdukE0QB
71lfFR3B31/M0GVtii+DdtOgHAdWJshlWKiL+m7ugmO6YAGeHs9SqiYMlRGTQmSmPSEV
Z7/w==
X-Gm-Message-State: AOJu0Yzux6D617e4Nf/79SsAkIFvccuZtJHs+0Tz6FNFqv1M96jN0gOQ
71h6cMl5zvHNEFXsqkx0uZLBl5g/cNbwxssmaKDArv5ckObCsl9TnG9KaRjLpNbMJNickhdEbDg
q6BRKu9ZA5dGV3Kpy2vGCWmYRikSG1R5XBv3Osw==
X-Google-Smtp-Source: AGHT+IErN8cohRiWZxso6/Z24Z8f5HC6qe/7MeV5whS6/+FYUtpv1XWJhqGlQAbKracKeKvyjoppIbhN5lH4NrpF0hY=
X-Received: by 2002:a05:6870:4209:b0:260:e453:5368 with SMTP id
586e51a60fabf-267d4f3b530mr409438fac.46.1722011675835; Fri, 26 Jul 2024
09:34:35 -0700 (PDT)
MIME-Version: 1.0
References: <20240725075506.207aad84@hermes.local>
<CAJvnSUBns79hAz9Kxpb1s996Rf7k=e=AGgNq2e3GcgFj4EkZBQ@mail.gmail.com>
In-Reply-To: <CAJvnSUBns79hAz9Kxpb1s996Rf7k=e=AGgNq2e3GcgFj4EkZBQ@mail.gmail.com>
From: Patrick Robb <probb@iol.unh.edu>
Date: Fri, 26 Jul 2024 12:34:25 -0400
Message-ID: <CAJvnSUB+rh=8-j5QWFB1OLFQ_iD_vng+9ZjDqpg-8uhWEi1exg@mail.gmail.com>
Subject: Re: How does CI system get updated?
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Okay I understand better now how we ended up with an older mingw64
version. The DPDK Docs for windows compile direct folks over to
(https://sourceforge.net/projects/mingw-w64/files/) to get the
prebuilt binaries, but the latest toolchain published there is Mingw64
v8.*, whereas the current version is v11.*. So, when we upgraded to
the "latest" published version, we upgraded to that v8.* from years
ago. If you look at the mingw64 website downloads page
(https://www.mingw-w64.org/downloads/), it directs people over to
winlibs.com to download the prebuilt binaries for v11.
I have replaced the Windows Server 2019 CI VM's old mingw64 binaries
with the new (v11.*) ones downloaded from winlibs.com, and I see that
Stephen's patch now passes the compile test. I can issue a retest for
your series once I am all done making the update for the server 2022
machine too.
I guess this also raises the question of whether the DPDK docs for the
windows mingw64 compile process should be updated to point to
winlibs.com instead of sourceforge.net (only has the source code).
https://doc.dpdk.org/guides/windows_gsg/build_dpdk.html#option-2-mingw-w64-=
toolchain
On Thu, Jul 25, 2024 at 3:06=E2=80=AFPM Patrick Robb <probb@iol.unh.edu> wr=
ote:
>
> Hi Stephen,
>
> This is a UNH Lab system.
>
> We review our systems for updates once every 4 months. The idea is we
> do it early in each DPDK release's development cycle. So, we update
> Dockerfiles (for container environments), we apply updates where
> needed to persistent systems (for VMs, or baremetal servers).
> Obviously the Mingw version for the windows system was a check we have
> not been doing. Thank you for spotting this and letting us know.
>
> We will apply the update and let you know when it's ready.
>
>
> On Thu, Jul 25, 2024 at 11:03=E2=80=AFAM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> >
> >
> > This warning is due to a very old version of Mingw installed in CI syst=
em.
> >
> > =3D=3D=3D=3D 20 line log output for Windows Server 2019 (dpdk_mingw64_c=
ompile): =3D=3D=3D=3D
> > In file included from ..\lib\net/rte_ip.h:21,
> > from ../lib/net/rte_dissect.c:20:
> > C:/mingw64/mingw64/x86_64-w64-mingw32/include/ws2tcpip.h:447:63: note: =
expected 'PVOID' {aka 'void *'} but argument is of type 'const uint8_t *' {=
aka 'const unsigned char *'}
> > WINSOCK_API_LINKAGE LPCSTR WSAAPI InetNtopA(INT Family, PVOID pAddr, LP=
STR pStringBuf, size_t StringBufSize);
> > ~~~~~~^~~~~
> > ../lib/net/rte_dissect.c:292:29: error: passing argument 2 of 'inet_nto=
p' discards 'const' qualifier from pointer target type [-Werror=3Ddiscarded=
-qualifiers]
> > inet_ntop(AF_INET6, ip6_hdr->dst_addr, dbuf, sizeof(dbuf));
> > ~~~~~~~^~~~~~~~~~
> > In file included from ..\lib\net/rte_ip.h:21,
> > from ../lib/net/rte_dissect.c:20:
> > C:/mingw64/mingw64/x86_64-w64-mingw32/include/ws2tcpip.h:447:63: note: =
expected 'PVOID' {aka 'void *'} but argument is of type 'const uint8_t *' {=
aka 'const unsigned char *'}
> > WINSOCK_API_LINKAGE LPCSTR WSAAPI InetNtopA(INT Family, PVOID pAddr, LP=
STR pStringBuf, size_t StringBufSize);
> > ~~~~~~^~~~~
> >
> > It was fixed upstream in Mingw 4 years ago.