From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E45245C0C; Tue, 29 Oct 2024 21:01:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8844442EE8; Tue, 29 Oct 2024 21:01:39 +0100 (CET) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id 44CDD4060F for ; Tue, 29 Oct 2024 21:01:38 +0100 (CET) Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2e30db524c2so4469569a91.1 for ; Tue, 29 Oct 2024 13:01:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1730232097; x=1730836897; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0ZdhtTuKjMuQA80f+37pZaw9Gy3xWAa41wwvlRJTi1U=; b=HhmezrHANsh0KBmurCvyHz3VuHjzBT4oNJcYh+q2mwZU/xliI2pP3pohq6PPAQr3/l AaqCq06sH0g5r4tRRwyo0wLJHA6CAzB8vl4vIAjHb5WTCbED5Th86e1T++wAEPOYtrRm flpuBGluldxCmraX69PlkSrVSwV+/tgPZdjk8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730232097; x=1730836897; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0ZdhtTuKjMuQA80f+37pZaw9Gy3xWAa41wwvlRJTi1U=; b=JPL6bi8II3/0cqNMap9Oi4l9sIBePFEYD/HK/AaTZYmQcYVjMIpPIbHCCuiBHSYQ7B WqFkVUhcrDw8Eg6Q/rbhxVOUytn8RCQlTqnKRDyLGVZNVnQ5jAqE1NZjx1cUt2HB51Ym /DMXgcK3SMaln94gfLNgE/4jQMcGcF3Mjg2wpaoYZVObEYHHJEtUlsUFJsh0bto80ZGj XkJ5PBYl1i7roN+M4mlm6nvCI5GGDkIU3+8gUJAciJAqX3B07kMYyYFAmI3Gpfmm/EG3 X9pglNi8dXujOSkaei+TFTlguxTQiv53VvNFcdmkEE/Y2CUcLxsl7kZcdqtCPShit3rW Ai0g== X-Gm-Message-State: AOJu0Yy//cXg1S9+DbvinAkZkMPUikH9rM5KDqH2rSUyT8bKhyjpHsCY JgfT7P5wlqiVbTwnUCWOOwnolViYRMRtDxNeQU7ZLWMjp8U7jGaMNWYDXWdzBlyIgWI30hOWLwL QQmvYV3OpG5y0LZW4zymIin9335ppeIW7hjiUqw== X-Google-Smtp-Source: AGHT+IF+LPNBkgD0VGOscTpQnMqt49l4VXhDg7/9qjMWlHtBo5XVYy0lAfBBWh3a+kNkiA3TsP0hovrdAgktAVm08vo= X-Received: by 2002:a17:90a:1c16:b0:2e2:e937:7141 with SMTP id 98e67ed59e1d1-2e8f107d831mr14026614a91.20.1730232097002; Tue, 29 Oct 2024 13:01:37 -0700 (PDT) MIME-Version: 1.0 References: <20240930160204.19582-1-tomas.durovec@pantheon.tech> <20241021134935.1210500-1-luca.vizzarro@arm.com> <20241021134935.1210500-6-luca.vizzarro@arm.com> <4cffb8f1-322e-41b9-9803-d3fcbda043db@arm.com> In-Reply-To: <4cffb8f1-322e-41b9-9803-d3fcbda043db@arm.com> From: Patrick Robb Date: Tue, 29 Oct 2024 15:59:57 -0400 Message-ID: Subject: Re: [PATCH v2 5/7] dts: add support for externally compiled DPDK To: Luca Vizzarro Cc: dev@dpdk.org, Paul Szczepanek , =?UTF-8?B?VG9tw6HFoSDEjnVyb3ZlYw==?= Content-Type: multipart/alternative; boundary="000000000000859bae0625a30d52" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000859bae0625a30d52 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Oct 29, 2024 at 7:48=E2=80=AFAM Luca Vizzarro wrote: > Hi Patrick, > > On 29/10/2024 01:19, Patrick Robb wrote: > > diff --git a/dts/conf.yaml b/dts/conf.yaml > > index 814744a1fc..8a65a481d6 100644 > > --- a/dts/conf.yaml > > +++ b/dts/conf.yaml > > @@ -5,12 +5,24 @@ > > test_runs: > > # define one test run environment > > - dpdk_build: > > - arch: x86_64 > > - os: linux > > - cpu: native > > - # the combination of the following two makes CC=3D"ccache gc= c" > > - compiler: gcc > > - compiler_wrapper: ccache > > + # dpdk_tree: Commented out because `tarball` is defined. > > > > > > Should this key name be extended to clarify the desired value is a path= , > > and whether it is absolute or relative? > > We could amend the key name to something more suitable if we wished. The > path could be either absolute or relative, so it doesn't matter. I > assume you are referring to change `dpdk_tree` to `dpdk_tree_path` and > `tarball` to `tarball_path` or something similar? > Yes, that was my thinking. Up to you on whether it's better or just overly wordy. > > > +1 to Dean's concerns about using the tarball without --tarball flag if > > dpdk_tree is commented out and tarball is defined. > > As replied to Dean, this scenario currently works, and I have also just > re-tested it for completeness. I need some more details to figure out > what's happening. > Okay, so I guess this is fine. I chatted with Dean about this today and it sounds like the workflows he was worried about do actually work (namely, copying a tarball from DTS engine to SUT) but that there is an added requirement that a flag be added (i.e. you can't just run main.py alone anymore) and it's unclear to him (and me) why this might be the case. I can try and take another look tonight, but I'm basically happy now that I know the workflows Dean was concerned about are tested and work. > Best, > Luca > --000000000000859bae0625a30d52 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Oct 29, 2024 at 7:48=E2=80=AF= AM Luca Vizzarro <Luca.Vizzarro= @arm.com> wrote:
Hi Patrick,

On 29/10/2024 01:19, Patrick Robb wrote:
>=C2=A0 =C2=A0 =C2=A0diff --git a/dts/conf.yaml b/dts/conf.yaml
>=C2=A0 =C2=A0 =C2=A0index 814744a1fc..8a65a481d6 100644
>=C2=A0 =C2=A0 =C2=A0--- a/dts/conf.yaml
>=C2=A0 =C2=A0 =C2=A0+++ b/dts/conf.yaml
>=C2=A0 =C2=A0 =C2=A0@@ -5,12 +5,24 @@
>=C2=A0 =C2=A0 =C2=A0 =C2=A0test_runs:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0# define one test run environment
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0- dpdk_build:
>=C2=A0 =C2=A0 =C2=A0-=C2=A0 =C2=A0 =C2=A0 arch: x86_64
>=C2=A0 =C2=A0 =C2=A0-=C2=A0 =C2=A0 =C2=A0 os: linux
>=C2=A0 =C2=A0 =C2=A0-=C2=A0 =C2=A0 =C2=A0 cpu: native
>=C2=A0 =C2=A0 =C2=A0-=C2=A0 =C2=A0 =C2=A0 # the combination of the foll= owing two makes CC=3D"ccache gcc"
>=C2=A0 =C2=A0 =C2=A0-=C2=A0 =C2=A0 =C2=A0 compiler: gcc
>=C2=A0 =C2=A0 =C2=A0-=C2=A0 =C2=A0 =C2=A0 compiler_wrapper: ccache
>=C2=A0 =C2=A0 =C2=A0+=C2=A0 =C2=A0 =C2=A0 # dpdk_tree: Commented out be= cause `tarball` is defined.
>
>
> Should this key name be extended to clarify the desired value is a pat= h,
> and whether it is absolute or relative?

We could amend the key name to something more suitable if we wished. The path could be either absolute or relative, so it doesn't matter. I
assume you are referring to change `dpdk_tree` to `dpdk_tree_path` and
`tarball` to `tarball_path` or something similar?

=
Yes, that was my thinking. Up to you on whether it's better = or just overly wordy.
=C2=A0

> +1 to Dean's concerns about using the tarball without --tarball fl= ag if
> dpdk_tree is commented out and tarball is defined.

As replied to Dean, this scenario currently works, and I have also just re-tested it for completeness. I need some more details to figure out
what's happening.

Okay, so I guess = this is fine. I chatted with Dean about this today and it sounds like the w= orkflows he was worried about do actually work (namely, copying a tarball f= rom DTS engine to SUT) but that there is an added requirement that a flag b= e added (i.e. you can't just run main.py alone anymore) and it's un= clear to him (and me) why this might be the case. I can try and take anothe= r look tonight, but I'm basically happy now that I know the workflows D= ean was concerned about are tested and work.


Best,
Luca
--000000000000859bae0625a30d52--