Re: [PATCH v2 0/7] dts: shell improvements

[Patrick Robb <probb@iol.unh.edu>]

[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]

Thanks for this series Luca. Dean did a review earlier and I have just done
one so we're almost good to proceed. I should probably apply it and do a
testrun before merging, which should be possible tomorrow (Friday).

I will flag that when I tried to apply the series, git complained of a sha1
issue:

Applying: dts: escape single quotes
Applying: dts: add blocking dpdk app class
Applying: dts: add shells pool
Applying: dts: revert back to a single InteractiveShell
error: sha1 information is lacking or useless
(dts/framework/remote_session/testpmd_shell.py).
error: could not build fake ancestor
Patch failed at 0004 dts: revert back to a single InteractiveShell

From a quick google, it sounds like this can happen when sharing
commits/patches across related repos, when one of the repos has rewritten
history. Maybe this is because sometimes dpdk mainline rewords commits and
then we hard reset off of that... or some other reason - not sure right
now. But in any case it sounds like it's benign and there are some
tricks/workarounds to apply it so it probably won't be an issue. If it is
I'll let you know. :)

Thanks.

[-- Attachment #2: Type: text/html, Size: 1289 bytes --]