Thanks Nick this looks (almost) ready to be applied to next-dts. Other than a little disconnect between your series and Dean's Patch-145500 ("dts: add VLAN methods to testpmd shell") series which I will flag below, I think this looks good.
The mac address filter test suite, whose test cases are based on old
DTS's test cases, has been refactored to interface with the new DTS
framework.
In porting over this test suite into the new framework, some
adjustments were made, namely in the EAL and TestPMD parameter provided
before executing the application. While the original test plan was
referenced, by and large, only for the individual test cases, I'll leave
the parameters the original test plan was asking for below for the sake
of discussion:
--burst=1 --rxpt=0 --rxht=0 --rxwt=0 --txpt=36 --txht=0 --txwt=0
--txfreet=32 --rxfreet=64 --mbcache=250 --portmask=0x3
I think including the params was good for discussion, but should be dropped for the final commit message which should be clean, and explain what the commit is adding.
+ @func_test
+ def test_add_remove_mac_addresses(self) -> None:
+ """Assess basic mac addressing filtering functionalities.
+
+ This test case validates for proper behavior of mac address filtering with both
+ a port's default, burned-in mac address, as well as additional mac addresses
+ added to the PMD. Packets should either be received or not received depending on
+ the properties applied to the PMD at any given time.
+
+ Test:
+ Start TestPMD with promiscuous mode.
Should this be "without?"
+ Send a packet with the port's default mac address. (Should receive)
+ Send a packet with fake mac address. (Should not receive)
+ Add fake mac address to the PMD's address pool.
+ Send a packet with the fake mac address to the PMD. (Should receive)
+ Remove the fake mac address from the PMD's address pool.
+ Send a packet with the fake mac address to the PMD. (Should not receive)
+ """
+ with TestPmdShell(self.sut_node) as testpmd:
+ testpmd.set_promisc(0, on=False)
The parameter is no longer named "on," it is named "enable" in Dean's vlan methods series which you listed a dependency on. So unless I'm misunderstanding, there is a disconnect between your series. I changed the param to enable and then the testsuite runs.
Please make sure you do a test run before you submit a new version, even if the changes seem trivial. :)
+ Test:
+ Start TestPMD with promiscuous mode.
same as above
+ Add a fake multicast address to the PMD's multicast address pool.
+ Send a packet with the fake multicast address to the PMD. (Should receive)
+ Set vlan filtering on the PMD, and add vlan ID to the PMD.
+ Send a packet with the fake multicast address and vlan ID to the PMD. (Should receive)
+ Send a packet with the fake multicast address and a different vlan ID to the PMD.
+ (Should not receive)
+ Remove the vlan tag from the PMD, and turn vlan filtering off on the PMD.
+ Send a packet with the fake multicast address and no vlan tag to the PMD.
+ (Should receive)
+ Remove the fake multicast address from the PMDs multicast address filter.
+ Send a packet with the fake multicast address to the PMD. (Should not receive)
+ """
+ with TestPmdShell(self.sut_node) as testpmd:
+ testpmd.start()
+ testpmd.set_promisc(0, on=False)
same as above.
--
2.44.0
Thanks looks good overall.