From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCB9045AFB; Thu, 10 Oct 2024 00:45:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52DA340156; Thu, 10 Oct 2024 00:45:04 +0200 (CEST) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id 9C98A400D6 for ; Thu, 10 Oct 2024 00:45:02 +0200 (CEST) Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2e2a0a7c035so294012a91.0 for ; Wed, 09 Oct 2024 15:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1728513902; x=1729118702; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YSgQfuS1zlQzySZKXCBu4oGDXOKAyBYlXR0BdS5QnVc=; b=TEOAjDNSgrDnMX+lMM2x5PQy2xcjzAHLzRqb+IuustYc74sSwZSUDQYV+tipezlUWT iv7mr+XrDrKH6/Cngq1t5a8Ane/1+YCrVtemyC59X5x8YN4f6OkA4iErsVjorHvJWz3b SdgfoBrrgodB3Jg8iYot8u1SIv5CprsqeixgY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728513902; x=1729118702; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YSgQfuS1zlQzySZKXCBu4oGDXOKAyBYlXR0BdS5QnVc=; b=CqZvC1FbRa/X4e52olLrqb3BvzYiBVkLkPB4+POK6cYbY25PRSuHU5fMp6Ow+hEyJe u+yneBnpBoEMK9dFBoJ8QgM38se5Kmec57Ez2SJzNJ1R3ZAeGfaMkT9vapDoOpkbFTMU keg2S0NtaSDYOdN2LanOf67MpVVZod9jkxd2oBN7eGcnvB8+quiwH9taaM4Gxa7JozWs wdBU34WIO56c503xUVOdQMA0bH2tB1YsSlw2lHHZj4vGyGEWiQbsa2/u3Pmnvb/OsJab 1Lt+d1E21vrHfioKO1tZcbPsR+hU1xz83/bR7nBMDVDYx62v5ydLhd1tz4/5Rw4uZc95 dbiw== X-Forwarded-Encrypted: i=1; AJvYcCWBtAEZu20PVxCR/4arWEEUJJkJgpXModM4J7FRcXRyqBo+S9/2HWRfvpBpZyfXW8ilg0k=@dpdk.org X-Gm-Message-State: AOJu0YxTb6WN69zKeLdOYNrVvgByTrarKInn2zJsMdkq+q8nvWFFLB0g kadVyXRWpg+QnMN1dwmULP9CWHhL19GIRQHr9pslcWZOXMpIrzejeRDHW24ArWeqIS1LVloBeVH vf2rE93GH9nQeYno5Q0fDcfKEPObjxsiPV9fizg== X-Google-Smtp-Source: AGHT+IFUrlQJ6kSPauZkFerBoTiAB3nwGoXUzx1FqxJyW2vagJ5oeTiDCflmvsfrIzllvE7S11EGBBkayCQ2/4qECPQ= X-Received: by 2002:a17:90a:d446:b0:2e0:8028:3f37 with SMTP id 98e67ed59e1d1-2e2a2339e7dmr4595486a91.11.1728513901764; Wed, 09 Oct 2024 15:45:01 -0700 (PDT) MIME-Version: 1.0 References: <20240702192422.2480-2-npratte@iol.unh.edu> <20241008204520.17275-1-npratte@iol.unh.edu> <20241008204520.17275-3-npratte@iol.unh.edu> In-Reply-To: <20241008204520.17275-3-npratte@iol.unh.edu> From: Patrick Robb Date: Wed, 9 Oct 2024 18:43:42 -0400 Message-ID: Subject: Re: [PATCH v6 2/2] dts: mac filter test suite refactored for new dts To: Nicholas Pratte Cc: Honnappa.Nagarahalli@arm.com, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, jspewock@iol.unh.edu, juraj.linkes@pantheon.tech, paul.szczepanek@arm.com, dmarx@iol.unh.edu, dev@dpdk.org Content-Type: multipart/alternative; boundary="0000000000001ac091062413013e" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000001ac091062413013e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks Nick this looks (almost) ready to be applied to next-dts. Other than a little disconnect between your series and Dean's Patch-145500 ("dts: add VLAN methods to testpmd shell") series which I will flag below, I think this looks good. On Tue, Oct 8, 2024 at 4:45=E2=80=AFPM Nicholas Pratte wrote: > The mac address filter test suite, whose test cases are based on old > DTS's test cases, has been refactored to interface with the new DTS > framework. > > In porting over this test suite into the new framework, some > adjustments were made, namely in the EAL and TestPMD parameter provided > before executing the application. While the original test plan was > referenced, by and large, only for the individual test cases, I'll leave > the parameters the original test plan was asking for below for the sake > of discussion: > > --burst=3D1 --rxpt=3D0 --rxht=3D0 --rxwt=3D0 --txpt=3D36 --txht=3D0 --txw= t=3D0 > --txfreet=3D32 --rxfreet=3D64 --mbcache=3D250 --portmask=3D0x3 > I think including the params was good for discussion, but should be dropped for the final commit message which should be clean, and explain what the commit is adding. > + @func_test > + def test_add_remove_mac_addresses(self) -> None: > + """Assess basic mac addressing filtering functionalities. > + > + This test case validates for proper behavior of mac address > filtering with both > + a port's default, burned-in mac address, as well as additional > mac addresses > + added to the PMD. Packets should either be received or not > received depending on > + the properties applied to the PMD at any given time. > + > + Test: > + Start TestPMD with promiscuous mode. > Should this be "without?" > + Send a packet with the port's default mac address. (Should > receive) > + Send a packet with fake mac address. (Should not receive) > + Add fake mac address to the PMD's address pool. > + Send a packet with the fake mac address to the PMD. (Should > receive) > + Remove the fake mac address from the PMD's address pool. > + Send a packet with the fake mac address to the PMD. (Should > not receive) > + """ > + with TestPmdShell(self.sut_node) as testpmd: > + testpmd.set_promisc(0, on=3DFalse) > The parameter is no longer named "on," it is named "enable" in Dean's vlan methods series which you listed a dependency on. So unless I'm misunderstanding, there is a disconnect between your series. I changed the param to enable and then the testsuite runs. Please make sure you do a test run before you submit a new version, even if the changes seem trivial. :) > > + Test: > + Start TestPMD with promiscuous mode. > same as above > + Add a fake multicast address to the PMD's multicast address > pool. > + Send a packet with the fake multicast address to the PMD. > (Should receive) > + Set vlan filtering on the PMD, and add vlan ID to the PMD. > + Send a packet with the fake multicast address and vlan ID to > the PMD. (Should receive) > + Send a packet with the fake multicast address and a differen= t > vlan ID to the PMD. > + (Should not receive) > + Remove the vlan tag from the PMD, and turn vlan filtering of= f > on the PMD. > + Send a packet with the fake multicast address and no vlan ta= g > to the PMD. > + (Should receive) > + Remove the fake multicast address from the PMDs multicast > address filter. > + Send a packet with the fake multicast address to the PMD. > (Should not receive) > + """ > + with TestPmdShell(self.sut_node) as testpmd: > + testpmd.start() > + testpmd.set_promisc(0, on=3DFalse) > same as above. > > -- > 2.44.0 > > Thanks looks good overall. Reviewed-by: Patrick Robb --0000000000001ac091062413013e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks Nick this looks (almost) ready to = be applied to next-dts. Other than a little disconnect between your series = and Dean's=C2=A0Patch-145500 ("dts: add VLAN methods to testpmd sh= ell") series which I will flag below, I think this looks good.
On Tue, = Oct 8, 2024 at 4:45=E2=80=AFPM Nicholas Pratte <npratte@iol.unh.edu> wrote:
The mac address filter test suite, whose = test cases are based on old
DTS's test cases, has been refactored to interface with the new DTS
framework.

In porting over this test suite into the new framework, some
adjustments were made, namely in the EAL and TestPMD parameter provided
before executing the application. While the original test plan was
referenced, by and large, only for the individual test cases, I'll leav= e
the parameters the original test plan was asking for below for the sake
of discussion:

--burst=3D1 --rxpt=3D0 --rxht=3D0 --rxwt=3D0 --txpt=3D36 --txht=3D0 --txwt= =3D0
--txfreet=3D32 --rxfreet=3D64 --mbcache=3D250 --portmask=3D0x3

I think including=C2=A0the params was good for disc= ussion, but should be dropped for the final commit message which should be = clean, and explain what the commit is adding.


+=C2=A0 =C2=A0 @func_test
+=C2=A0 =C2=A0 def test_add_remove_mac_addresses(self) -> None:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 """Assess basic mac addressing = filtering functionalities.
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 This test case validates for proper behavior o= f mac address filtering with both
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 a port's default, burned-in mac address, a= s well as additional mac addresses
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 added to the PMD. Packets should either be rec= eived or not received depending on
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 the properties applied to the PMD at any given= time.
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Test:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Start TestPMD with promiscuous m= ode.

Should this be "without?"= ;=C2=A0
=C2=A0
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Send a packet with the port'= s default mac address. (Should receive)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Send a packet with fake mac addr= ess. (Should not receive)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Add fake mac address to the PMD&= #39;s address pool.
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Send a packet with the fake mac = address to the PMD. (Should receive)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Remove the fake mac address from= the PMD's address pool.
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Send a packet with the fake mac = address to the PMD. (Should not receive)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 """
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 with TestPmdShell(self.sut_node) as testpmd: +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 testpmd.set_promisc(0, on=3DFals= e)

The parameter is no longer named &qu= ot;on," it is named "enable" in Dean's vlan methods seri= es which you listed a dependency on. So unless I'm misunderstanding, th= ere is a disconnect between your series. I changed the param to enable and = then the testsuite runs.

Please make sure you do a= test run before you submit a new version, even if the changes seem trivial= . :)
=C2=A0
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Add a fake multicast address to = the PMD's multicast address pool.
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Send a packet with the fake mult= icast address to the PMD. (Should receive)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Set vlan filtering on the PMD, a= nd add vlan ID to the PMD.
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Send a packet with the fake mult= icast address and vlan ID to the PMD. (Should receive)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Send a packet with the fake mult= icast address and a different vlan ID to the PMD.
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (Should not receiv= e)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Remove the vlan tag from the PMD= , and turn vlan filtering off on the PMD.
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Send a packet with the fake mult= icast address and no vlan tag to the PMD.
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (Should receive) +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Remove the fake multicast addres= s from the PMDs multicast address filter.
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Send a packet with the fake mult= icast address to the PMD. (Should not receive)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 """
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 with TestPmdShell(self.sut_node) as testpmd: +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 testpmd.start()
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 testpmd.set_promisc(0, on=3DFals= e)

same as above.
=C2=A0

--
2.44.0


Thanks looks good overall.
<= br>
Reviewed-by: Patrick Robb <probb@iol.unh.edu>=C2=A0
--0000000000001ac091062413013e--