From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9F5343E0E; Fri, 5 Apr 2024 22:33:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF63F402CE; Fri, 5 Apr 2024 22:33:12 +0200 (CEST) Received: from mail-oo1-f43.google.com (mail-oo1-f43.google.com [209.85.161.43]) by mails.dpdk.org (Postfix) with ESMTP id CBCB94028A for ; Fri, 5 Apr 2024 22:33:11 +0200 (CEST) Received: by mail-oo1-f43.google.com with SMTP id 006d021491bc7-5a5272035d3so1359826eaf.1 for ; Fri, 05 Apr 2024 13:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1712349191; x=1712953991; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JJGsCuJCYaypXNeLx3H3QQ9hNHRaLl0F5MjbtKjsYfk=; b=VEN30jtDCORYQwGP0RZCm5N2OkmaAa/gsjjsA/30miOeNxuNFnYrBzHuEN2PjUyZC7 IvaQiHUTQ7RgDSxCMzqIMymjS8D8dsVpSCDiAncGpDuTaAkZEvn1EYiIBMbOVufvKPhQ pLsegOhTrylD194JAinNXXC3y+uU247NStJMU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712349191; x=1712953991; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JJGsCuJCYaypXNeLx3H3QQ9hNHRaLl0F5MjbtKjsYfk=; b=u2q/Wc5K9b7Iw9qITD48qY3VR59C5U+lftc8G865ydjF6hHmZiCccUTN8GrbYzcrd+ MKsipSNOkSm94W8scbeASpE5NDVZLoGUDSZ8EAYJRpD3kxNPfxq/NgYwa52aVfKRBtjK j6Dtj5bpNn6LNyauKTfeGi0wD8LCnyyPzumWwydR0/zJxKsctIeD/MotiBB0lrLcIBo5 qUPOBnsxSI/FfiADAYJSw6MbfRTHdrbPtuq+7GBSx6IiHO/OcaaZH8oPCFV4OIR7NqLW dSPdasoVoLYvUXBf0FpK+CNMII74qAtAQeHDY9S3bCr/3e0/qbf1pNcVy4J9pBAf7sLE cHIA== X-Gm-Message-State: AOJu0Yw+ZE3DXp9lHzxFDbUUSyAEKLLn5j09KbO68IRZXVbSYwNA2tXY vrC5AhWSZXfInBF7nnqbLdh6AnIPhcdRPto6jN8McTnYhg4NUtZk4MrSiIuO9q8b7oKBk8beREh a97ha0iygagvsm4p0APeBzFm/8ZUc2b5rPkZCnA== X-Google-Smtp-Source: AGHT+IEIHfVmrei273Pdz537x4/e43b/fLbpaW1csOL3ACDigw3oi/1N7aE/Uzuk6weTI2J4F6KZFdGCkcJq+jpsc7w= X-Received: by 2002:a05:6820:2686:b0:5a4:93b6:9a5 with SMTP id cz6-20020a056820268600b005a493b609a5mr2659258oob.4.1712349191091; Fri, 05 Apr 2024 13:33:11 -0700 (PDT) MIME-Version: 1.0 References: <1712076948-25853-1-git-send-email-roretzla@linux.microsoft.com> <1712076948-25853-2-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1712076948-25853-2-git-send-email-roretzla@linux.microsoft.com> From: Patrick Robb Date: Fri, 5 Apr 2024 16:33:00 -0400 Message-ID: Subject: Re: [PATCH] build: exclude rather than include libs in MSVC build To: Tyler Retzlaff Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Andrew Rybchenko , Bruce Richardson , Chengwen Feng , Honnappa Nagarahalli , Kevin Laatz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Recheck-request: iol-intel-Functional Sorry about the spam! On Tue, Apr 2, 2024 at 12:55=E2=80=AFPM Tyler Retzlaff wrote: > > Some libraries that could be built with MSVC were not being built. > > Switch from explicit include to exclude of libs to get immediate CI > coverage of libraries that already work with MSVC Windows builds. > > Signed-off-by: Tyler Retzlaff > --- > lib/argparse/meson.build | 6 ++++++ > lib/dmadev/meson.build | 6 ++++++ > lib/mbuf/meson.build | 6 ++++++ > lib/mempool/meson.build | 6 ++++++ > lib/meson.build | 10 ---------- > lib/rcu/meson.build | 6 ++++++ > lib/stack/meson.build | 6 ++++++ > 7 files changed, 36 insertions(+), 10 deletions(-) > > diff --git a/lib/argparse/meson.build b/lib/argparse/meson.build > index b6a08ca..8ab4c40 100644 > --- a/lib/argparse/meson.build > +++ b/lib/argparse/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2024 HiSilicon Limited. > > +if is_ms_compiler > + build =3D false > + reason =3D 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources =3D files('rte_argparse.c') > headers =3D files('rte_argparse.h') > > diff --git a/lib/dmadev/meson.build b/lib/dmadev/meson.build > index 62b0650..e66dcb6 100644 > --- a/lib/dmadev/meson.build > +++ b/lib/dmadev/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2021 HiSilicon Limited. > > +if is_ms_compiler > + build =3D false > + reason =3D 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources =3D files('rte_dmadev.c', 'rte_dmadev_trace_points.c') > headers =3D files('rte_dmadev.h') > indirect_headers +=3D files('rte_dmadev_core.h', 'rte_dmadev_trace_fp.h'= ) > diff --git a/lib/mbuf/meson.build b/lib/mbuf/meson.build > index 0435c5e..2cee905 100644 > --- a/lib/mbuf/meson.build > +++ b/lib/mbuf/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > +if is_ms_compiler > + build =3D false > + reason =3D 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources =3D files( > 'rte_mbuf.c', > 'rte_mbuf_ptype.c', > diff --git a/lib/mempool/meson.build b/lib/mempool/meson.build > index 8099a56..acce66c 100644 > --- a/lib/mempool/meson.build > +++ b/lib/mempool/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > +if is_ms_compiler > + build =3D false > + reason =3D 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > extra_flags =3D [] > > foreach flag: extra_flags > diff --git a/lib/meson.build b/lib/meson.build > index 179a272..94d2b72 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -68,16 +68,6 @@ libraries =3D [ > 'node', > ] > > -if is_ms_compiler > - libraries =3D [ > - 'log', > - 'kvargs', > - 'telemetry', > - 'eal', > - 'ring', > - ] > -endif > - > always_enable =3D [ > 'cmdline', > 'eal', > diff --git a/lib/rcu/meson.build b/lib/rcu/meson.build > index 09abc52..71143f5 100644 > --- a/lib/rcu/meson.build > +++ b/lib/rcu/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2018 Arm Limited > > +if is_ms_compiler > + build =3D false > + reason =3D 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources =3D files('rte_rcu_qsbr.c') > headers =3D files('rte_rcu_qsbr.h') > > diff --git a/lib/stack/meson.build b/lib/stack/meson.build > index 18177a7..7631a14 100644 > --- a/lib/stack/meson.build > +++ b/lib/stack/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2019 Intel Corporation > > +if is_ms_compiler > + build =3D false > + reason =3D 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources =3D files('rte_stack.c', 'rte_stack_std.c', 'rte_stack_lf.c') > headers =3D files('rte_stack.h') > # subheaders, not for direct inclusion by apps > -- > 1.8.3.1 >