From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F4D7430C4; Mon, 21 Aug 2023 16:33:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E1AD43067; Mon, 21 Aug 2023 16:33:01 +0200 (CEST) Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) by mails.dpdk.org (Postfix) with ESMTP id 5302042BC9 for ; Mon, 21 Aug 2023 16:33:00 +0200 (CEST) Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-570e388d328so331517eaf.0 for ; Mon, 21 Aug 2023 07:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1692628379; x=1693233179; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vx611JxTUkK+0y68KyJny0CydewzsUeM10S7RIdBkEE=; b=I1r/9i+ELIOHw6COkqa91JpDJKC82AIN1+GjNmeltu9N/hLAybhCOgseQkj5311mCH npyV51tcLEsi7uwfsJxTtPuXPxK+uPTGRv6cIgJ/nqhHnTCGnlwkz39+JjwKyhHvylcY mIbfYNjZbRG6ooL+OuF1sOLXvB+oOu5wsnh1E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692628379; x=1693233179; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vx611JxTUkK+0y68KyJny0CydewzsUeM10S7RIdBkEE=; b=cmlqo01x8UVVwq3T7B5AgterMA/QQXQTlF4fXqRpZxNyDqaVKnvefsSigyFwmVEeQW BR08o/rgoiqc/CoMYhExT81Q4HaPEdcyiUOzpTf0tOwKsO7GviqR3IgsnIb9Q/xL/YOL LAd9VP5sVbdGH8gh/OktECd8hc3FdbDFPSyEqF8+J88oCtSFDuAdP6Q4yiAO8C3VGG2h CeBsraNcrw5crD+yPKf4UKM/ywZIpgRSgY3UIaA48gClGnPrC4mbPZRtIH3qDxxJQ/bS tWvgSdsyGFyScU+yxxqS9dYn2i4o7Pzp5VlMKVlEx4QmCEoTldE+ZVij9OijY40pk0zx Bcdw== X-Gm-Message-State: AOJu0Yy84luuANKiWSeA7/zloR1idVUxlBMt+Hjq6K7yzQ1I1jZ4QLZm rf6z5vMaY6FoQk+H8bW3Yr23QVB66NqXC/bpCUa4pA== X-Google-Smtp-Source: AGHT+IFYw8yjRenHhA4kGOZyfRcv+ZKN5rqyyF520amUmBx1/aNQVaGvqufAQH9OtrrIhbjhblD1XejvWXnINhcuz9w= X-Received: by 2002:a4a:245a:0:b0:56e:4ee2:9183 with SMTP id v26-20020a4a245a000000b0056e4ee29183mr7542962oov.1.1692628379641; Mon, 21 Aug 2023 07:32:59 -0700 (PDT) MIME-Version: 1.0 References: <20230721115125.55137-1-bruce.richardson@intel.com> <20230815151053.996469-1-bruce.richardson@intel.com> <20230815151053.996469-5-bruce.richardson@intel.com> In-Reply-To: From: Patrick Robb Date: Mon, 21 Aug 2023 10:32:48 -0400 Message-ID: Subject: Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix To: David Marchand Cc: Bruce Richardson , dev@dpdk.org, ci@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Honnappa Nagarahalli , "Ruifeng Wang (Arm Technology China)" , Thomas Monjalon , Aaron Conole , Ferruh Yigit Content-Type: multipart/alternative; boundary="0000000000004e42bf06036fc1f4" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000004e42bf06036fc1f4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi David, Responding to your Slack request about merging Bruce's patch ahead of yours here so there is more visibility. That is fine, but as you point out it will mean a temporary loss of test coverage, as it will disable arm unit testing until either 1. your patch fixing the flags test hits mainline and we can re-enable testing without failing everyone's patchseries or 2. Bruce's RFC ([RFC PATCH] app/test: add support for skipping tests) is implemented and made a part of mainline. I agree with you this is the best thing to do so as to not hold up Bruce and his series. On Mon, Aug 21, 2023 at 3:13=E2=80=AFAM David Marchand wrote: > On Sat, Aug 19, 2023 at 1:26=E2=80=AFAM Patrick Robb = wrote: > > On Fri, Aug 18, 2023 at 6:33=E2=80=AFPM Patrick Robb wrote: > >> > >> > >> For your patch, it looks like there are actually more eal flags test > failures: > http://mails.dpdk.org/archives/test-report/2023-August/444170.html. In > any case, for debugging purposes, I will do a run with the > eal_flags_file_prefix_autotest also included and send you the meson test > detail log on slack. > >> > > Quick follow up - I see with your patch it does pass on > eal_flags_file_prefix_autotest, but as stated fails some others now. The > detailed slack logs are DM'ed to you on slack. Thanks! > > Thanks for the report. > Interestingly those failures pointed out that I broke secondary > processes when no port gets initialised in the primary process. > > I'll send a v3. > > > -- > David Marchand > > --=20 Patrick Robb Technical Service Manager UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 03824 www.iol.unh.edu --0000000000004e42bf06036fc1f4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi David,=C2=A0

Responding to your Slac= k request about merging Bruce's patch ahead of yours here so there is m= ore visibility.=C2=A0

That is fine, but as you poi= nt out it will mean a temporary loss of test coverage, as it will disable a= rm unit testing until either 1. your patch fixing the flags test hits mainl= ine and we can re-enable testing without failing everyone's patchseries= or 2. Bruce's RFC ([RFC PATCH] app/test: add support for skipping test= s) is implemented and made a part of mainline. I agree with you this is the= best thing to do so as to not hold up Bruce and his series.
On Mon, A= ug 21, 2023 at 3:13=E2=80=AFAM David Marchand <david.marchand@redhat.com> wrote:
On Sat, Aug 19, 2023 at 1:26= =E2=80=AFAM Patrick Robb <probb@iol.unh.edu> wrote:
> On Fri, Aug 18, 2023 at 6:33=E2=80=AFPM Patrick Robb <probb@iol.unh.edu> wrote:<= br> >>
>>
>> For your patch, it looks like there are actually more eal flags te= st failures: http://mails.dpdk.org= /archives/test-report/2023-August/444170.html. In any case, for debuggi= ng purposes, I will do a run with the eal_flags_file_prefix_autotest also i= ncluded and send you the meson test detail log on slack.
>>
> Quick follow up - I see with your patch it does pass on eal_flags_file= _prefix_autotest, but as stated fails some others now. The detailed slack l= ogs are DM'ed to you on slack. Thanks!

Thanks for the report.
Interestingly those failures pointed out that I broke secondary
processes when no port gets initialised in the primary process.

I'll send a v3.


--
David Marchand



--

Patrick Robb

<= span style=3D"font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-= color:transparent;vertical-align:baseline;white-space:pre-wrap">Technical S= ervice Manager

UNH InterOperability Laboratory

21 Madbury Rd, Suite 100, Durham, NH 03824

www.iol.unh.edu


--0000000000004e42bf06036fc1f4--