From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39E6943E06; Fri, 5 Apr 2024 16:33:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27906402CE; Fri, 5 Apr 2024 16:33:47 +0200 (CEST) Received: from mail-oo1-f43.google.com (mail-oo1-f43.google.com [209.85.161.43]) by mails.dpdk.org (Postfix) with ESMTP id E9AAC4028B for ; Fri, 5 Apr 2024 16:33:45 +0200 (CEST) Received: by mail-oo1-f43.google.com with SMTP id 006d021491bc7-5a529a1f69aso1181215eaf.3 for ; Fri, 05 Apr 2024 07:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1712327625; x=1712932425; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=R972gMxrsk+HZPbUEvU/f06tHwxjx6s1lDFkfKlHSEs=; b=PpChj3zOTBBLqmX7G4PWp6/CmPgJij5uOPfW+HarWtsTE4P5zygAfsTyiPEpH7c5y9 pDZOp9Wdo3yhpJDZcR0HoS2l1/G+ro1k3xRabaMr3dT5/wfAXMJcK3ebFziGaK6SQFMO vzL1gCLYXvlOovVlQ3+PnrhoOAU8rBDZOFVCY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712327625; x=1712932425; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R972gMxrsk+HZPbUEvU/f06tHwxjx6s1lDFkfKlHSEs=; b=OlXE5oVPCusrs2ZEPiTpvEwcneJgKv+ylNgBZMCGqYiDxXgXGXDW+xTZnB6c4vezTZ wDaswRMzFmV+oAcnBFFm8Cs7E2eit3+lo3TGtaOiw+BSt2HJY2SG/aAJENXegMLxnUUx 3hZijAEY29d+0o6OtXcfQBnNDoAQFi1ZlL9hJbFwAzb08tuagwsqRuAskuFeqvBAxceJ pE/n5iUwea4+FnxFbCkf9XijETdQuij3x4md/AU7H90r7st41ECFB0fqMmFJGAPIqLHX bvrSSWyvMYPzdNFjbr2YJKsRGnzVxE5Zkef6Yq0qwEjGRixBUtDqfk3Il7XaqOq4Zd7m folg== X-Gm-Message-State: AOJu0YysH1zoapwhov9bgqMyMIns8gCu57tNdTe2+NaAzlUwzeIAR0NJ RSGEYaNgs6+WQ6/WvTynk1lKYQsUqpoe8J6187uz/e/DVLU1oLqvNK3s7kT0U8izYYdIFuh+ki4 Hah/IULOBtTHgF3T9Ygm4DVobmIHsKyWc83xeeg== X-Google-Smtp-Source: AGHT+IF+fFsjS2JVDAmlaCMMYgY0PrAGL9181fOMqdlHdGhKhjPoMwDXVxuF0pnj6iQkpMIf8igx6/1WK+399Quwy0A= X-Received: by 2002:a05:6820:2110:b0:5a5:1f92:ba31 with SMTP id cd16-20020a056820211000b005a51f92ba31mr1910282oob.1.1712327625273; Fri, 05 Apr 2024 07:33:45 -0700 (PDT) MIME-Version: 1.0 References: <20240403101624.2771140-1-haijie1@huawei.com> <20240403101624.2771140-2-haijie1@huawei.com> In-Reply-To: <20240403101624.2771140-2-haijie1@huawei.com> From: Patrick Robb Date: Fri, 5 Apr 2024 10:33:34 -0400 Message-ID: Subject: Re: [PATCH 1/5] net/hns3: fix offload flag of IEEE 1588 To: Jie Hai Cc: dev@dpdk.org, Yisen Zhuang , "Min Hu (Connor)" , lihuisong@huawei.com, fengchengwen@huawei.com, liuyonglong@huawei.com, huangdengdui@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Recheck-request: iol-intel-Functional, iol-intel-Performance On Wed, Apr 3, 2024 at 6:21=E2=80=AFAM Jie Hai wrote: > > From: Dengdui Huang > > Currently, the RTE_MBUF_F_RX_IEEE1588_TMST offload flag will > not be set when the scatter algorithm is used. > This patch fixes it. > > Fixes: 4801f0403b58 ("net/hns3: fix IEEE 1588 PTP for scalar scattered Rx= ") > Cc: stable@dpdk.org > > Signed-off-by: Dengdui Huang > Signed-off-by: Jie Hai > --- > drivers/net/hns3/hns3_rxtx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c > index 7e636a0a2e99..3e7dd1057940 100644 > --- a/drivers/net/hns3/hns3_rxtx.c > +++ b/drivers/net/hns3/hns3_rxtx.c > @@ -2669,6 +2669,7 @@ hns3_recv_scattered_pkts(void *rx_queue, > continue; > } > > + first_seg->ol_flags =3D 0; > if (unlikely(bd_base_info & BIT(HNS3_RXD_TS_VLD_B))) > hns3_rx_ptp_timestamp_handle(rxq, first_seg, time= stamp); > > @@ -2698,7 +2699,7 @@ hns3_recv_scattered_pkts(void *rx_queue, > > first_seg->port =3D rxq->port_id; > first_seg->hash.rss =3D rte_le_to_cpu_32(rxd.rx.rss_hash)= ; > - first_seg->ol_flags =3D RTE_MBUF_F_RX_RSS_HASH; > + first_seg->ol_flags |=3D RTE_MBUF_F_RX_RSS_HASH; > if (unlikely(bd_base_info & BIT(HNS3_RXD_LUM_B))) { > first_seg->hash.fdir.hi =3D > rte_le_to_cpu_16(rxd.rx.fd_id); > -- > 2.30.0 >