From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AA1D45B57; Thu, 17 Oct 2024 07:27:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B53E74021F; Thu, 17 Oct 2024 07:27:35 +0200 (CEST) Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by mails.dpdk.org (Postfix) with ESMTP id 67C0D4021F for ; Thu, 17 Oct 2024 07:27:34 +0200 (CEST) Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-7180cc146d8so275870a34.0 for ; Wed, 16 Oct 2024 22:27:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1729142853; x=1729747653; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uayG4pgAQzpM0218gQHkYuNxZrHLxP5JHYFl5l0tKy4=; b=D5eY7l+JzaXZGgIBvMXpz9RdyeFJLoLiyxXTHz3fF22ZIqIJTvL/L6UWqB9de2PDkN wZ4oxGwlf7ZUt9SUwjVvRnVKF3JwPv1nszIch8IK4VUbxol9ay9+Nh7ZrPxZUo9kUwpr cxDxrXRXKMjeSASgYrIb6Km/CmQcFP+TS4bVk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729142853; x=1729747653; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uayG4pgAQzpM0218gQHkYuNxZrHLxP5JHYFl5l0tKy4=; b=USMtZicNowNKn3fPHIeNwDi05fMPgJ0BGGI4BatUqPbRcvMUfE0s9wZONJnIHjo82e JNl+OjLOHkkaDxm0STA3MCQOYcx++qNWbBwYFqsKsuD2PnpJXKUQKzFtA7JLpHInuDpT lJRukpDHhVQIQ+xaoVptOWXShXGpduKFqrCStNayuAuIEcTS/wsuK5nKHe1YvzLIkcoY r9hPQ8mpGeceFMgWAEXa3xDPIrfBsxIA6HXr6M1OQSYQ5bLD82KVGrpDmw7+XjDq36rs Vc9nxy6jKvSBDBlROa5SdVXjiD4FhS44GlYU1BYgmlc4/HVqIlDHm1n0ffN92Vv6a+1S Wa3g== X-Forwarded-Encrypted: i=1; AJvYcCWdx6sccN9MeJOExvWLgi6Xd88V3SZSHz0JkLjiONSfjs0vxZ559zf4Y3Lq8DVU+9QQNT0=@dpdk.org X-Gm-Message-State: AOJu0Yzz42urD8EIYZFKVSNlb8mWMYZiXI/JzRzhIRDX2fTC/Gq2Sg7D MlVX7IcIkbWtg+IK9Vi1O1D3xkWQhz3C8SfRJ/PtZZgmtuhbgd3Raj/t2Sg9eubg3H1FQj86h+J jPhwGTj+k4Y+bJqYqqQEv0E8vy3Y+0t2wgcQCqA== X-Google-Smtp-Source: AGHT+IFkJZbnucv6gULxxkEt2krsqOau7AP6X2XGB7vbXAQvOVfNupNuCeyRneeHTafDg4Pj1HZX5Lyxr311DK02dmw= X-Received: by 2002:a05:6358:d1a:b0:1b8:37c3:9a00 with SMTP id e5c5f4694b2df-1c32ba6129emr1600641755d.4.1729142853427; Wed, 16 Oct 2024 22:27:33 -0700 (PDT) MIME-Version: 1.0 References: <20240920125737.1197969-1-bruce.richardson@intel.com> <9a6c43e9-b2a1-15fe-9b7c-4178419f1e35@loongson.cn> <12eae603-d75d-ee3f-3822-670e8e4bbbeb@loongson.cn> In-Reply-To: From: Patrick Robb Date: Thu, 17 Oct 2024 01:26:06 -0400 Message-ID: Subject: Re: [PATCH 0/5] Increase minimum meson version To: David Marchand Cc: dpdklab , dev@dpdk.org, mb@smartsharesystems.com, thomas@monjalon.net, ci@dpdk.org, Bruce Richardson , zhoumin Content-Type: multipart/alternative; boundary="0000000000008b873e0624a5712b" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000008b873e0624a5712b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable UNH CI testing is ready for this change. On Wed, Oct 16, 2024 at 9:08=E2=80=AFAM Patrick Robb wr= ote: > UNH will be updated to be running from the linux setup script by the end > of the day today, and I'll send another response here. > > On Sun, Oct 13, 2024 at 9:26=E2=80=AFPM zhoumin wro= te: > >> Hi Patrick Robb, >> >> Thank you for your reminding. I have set the meson version to 0.57.0 in >> Loongson lab. >> On Wed, Oct 9, 2024 at 2:31PM, Patrick Robb wrote: >> >> Hi Min Zhou, >> >> I think it makes sense for you to set your meson version to the minimum >> version supported for DPDK (so, .57 now I suppose) instead of .63. The >> principle that David described above regarding LTS is also true for main= . >> So, for the main and next-* branch testing that Loongson lab does, we wa= nt >> our CI testing to verify that no change relying on post .57 meson featur= es >> get merged into main. >> >> On Tue, Oct 8, 2024 at 9:07=E2=80=AFPM zhoumin wro= te: >> >>> Hi David, >>> >>> On Tues, Oct 8, 2024 at 8:28AM, David Marchand wrote: >>> > Hello CI guys, >>> > >>> > On Fri, Sep 20, 2024 at 2:57=E2=80=AFPM Bruce Richardson >>> > wrote: >>> >> This patchset proposed increasing the minimum meson version to 0.57 >>> >> and makes changes to update our build files appropriately for that >>> >> change: replacing deprecated functions, removing unnecessary version >>> >> checks and taking advantage of some new capabilities. >>> >> >>> >> Why 0.57? No one particular reason; it's mainly a conservative versi= on >>> >> bump that doesn't have many impacts, but still gives us the minimum >>> >> updates we need to replace the deprecated get_cross_properties fn >>> >> and have a few extra features guaranteed available. >>> >> >>> >> Bruce Richardson (5): >>> >> build: increase minimum meson version to 0.57 >>> >> build: remove version check on compiler links function >>> >> build: remove unnecessary version checks >>> >> build: use version file support from meson >>> >> build: replace deprecated meson function >>> >> >>> >> .ci/linux-setup.sh | 2 +- >>> >> config/arm/meson.build | 4 ++-- >>> >> config/meson.build | 8 ++++---- >>> >> config/riscv/meson.build | 4 ++-- >>> >> doc/api/meson.build | 2 +- >>> >> doc/guides/linux_gsg/sys_reqs.rst | 2 +- >>> >> doc/guides/prog_guide/build-sdk-meson.rst | 2 +- >>> >> drivers/common/qat/meson.build | 2 +- >>> >> drivers/crypto/ipsec_mb/meson.build | 2 +- >>> >> drivers/event/cnxk/meson.build | 2 +- >>> >> drivers/meson.build | 7 ++----- >>> >> drivers/net/cnxk/meson.build | 2 +- >>> >> lib/meson.build | 6 ------ >>> >> meson.build | 7 ++----- >>> >> 14 files changed, 20 insertions(+), 32 deletions(-) >>> > This series can't be merged until the (UNH and LoongArch) CI are read= y >>> > for such a change. >>> > >>> > TL;DR: the meson minimum version is being changed from 0.53.2 to 0.57 >>> > in the current release. >>> > >>> > @UNH @Min Zhou >>> > How long would it take for all CI to be ready for this change? >>> It's OK for Loongson lab. The meson version for DPDK CI in Loongson lab >>> is 0.63.0. >>> > Important note: if relevant to your CI, testing against LTS branches >>> > must still be done with the 0.53.2 version, so no change relying on >>> > post 0.53.2 meson feature gets backported. >>> > >>> > >>> >>> --0000000000008b873e0624a5712b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
UNH CI testing is ready for this change.

On Wed, Oct 16, 20= 24 at 9:08=E2=80=AFAM Patrick Robb <probb@iol.unh.edu> wrote:
UNH will be updated to be running from t= he linux setup script by the end of the day today, and I'll send anothe= r response here.

On Sun, Oct 13, 2024 at 9:26=E2=80=AFPM zhoumin <zhoumin@loongson.cn&g= t; wrote:
=20 =20 =20

Hi Patrick Robb,

Thank you for your reminding. I have set the meson version to 0.57.0 in Loongson lab.

On Wed, Oct 9, 2024 at 2:31PM, Patrick Robb wrote:
=20
Hi Min Zhou,

I think it makes sense for you to set your meson version to the minimum version supported for DPDK (so, .57 now I suppose) instead of .63. The principle that David described above regarding LTS is also true for main. So, for the main and next-* branch testing that Loongson lab does, we want our CI testing to verify that no change relying on post .57 meson features get merged into main.=C2=A0

On Tue, Oct 8, 2024 at 9:07= =E2=80=AFPM zhoumin <zhoumin@loongson.cn> wrote:
Hi David,

On Tues, Oct 8, 2024 at 8:28AM, David Marchand wrote:
> Hello CI guys,
>
> On Fri, Sep 20, 2024 at 2:57=E2=80=AFPM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
>> This patchset proposed increasing the minimum meson version to 0.57
>> and makes changes to update our build files appropriately for that
>> change: replacing deprecated functions, removing unnecessary version
>> checks and taking advantage of some new capabilities. >>
>> Why 0.57? No one particular reason; it's mainly a conservative version
>> bump that doesn't have many impacts, but still gives us the minimum
>> updates we need to replace the deprecated get_cross_properties fn
>> and have a few extra features guaranteed available.
>>
>> Bruce Richardson (5):
>>=C2=A0 =C2=A0 build: increase minimum meson version to 0.= 57
>>=C2=A0 =C2=A0 build: remove version check on compiler lin= ks function
>>=C2=A0 =C2=A0 build: remove unnecessary version checks >>=C2=A0 =C2=A0 build: use version file support from meson<= br> >>=C2=A0 =C2=A0 build: replace deprecated meson function >>
>>=C2=A0 =C2=A0.ci/linux-setup.sh=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 2 +-
>>=C2=A0 =C2=A0config/arm/meson.build=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 4 ++--
>>=C2=A0 =C2=A0config/meson.build=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 8 ++++----
>>=C2=A0 =C2=A0config/riscv/meson.build=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 4 ++--
>>=C2=A0 =C2=A0doc/api/meson.build=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 2 +-
>>=C2=A0 =C2=A0doc/guides/linux_gsg/sys_reqs.rst=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0| 2 +-
>>=C2=A0 =C2=A0doc/guides/prog_guide/build-sdk-meson.rst | = 2 +-
>>=C2=A0 =C2=A0drivers/common/qat/meson.build=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 2 +-
>>=C2=A0 =C2=A0drivers/crypto/ipsec_mb/meson.build=C2=A0 = =C2=A0 =C2=A0 =C2=A0| 2 +-
>>=C2=A0 =C2=A0drivers/event/cnxk/meson.build=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 2 +-
>>=C2=A0 =C2=A0drivers/meson.build=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 7 ++-----
>>=C2=A0 =C2=A0drivers/net/cnxk/meson.build=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 2 +-
>>=C2=A0 =C2=A0lib/meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 6 ------
>>=C2=A0 =C2=A0meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0| 7 ++-----
>>=C2=A0 =C2=A014 files changed, 20 insertions(+), 32 delet= ions(-)
> This series can't be merged until the (UNH and LoongArch= ) CI are ready
> for such a change.
>
> TL;DR: the meson minimum version is being changed from 0.53.2 to 0.57
> in the current release.
>
> @UNH @Min Zhou
> How long would it take for all CI to be ready for this change?
It's OK for Loongson lab. The meson version for DPDK CI in Loongson lab
is 0.63.0.
> Important note: if relevant to your CI, testing against LTS branches
> must still be done with the 0.53.2 version, so no change relying on
> post 0.53.2 meson feature gets backported.
>
>

--0000000000008b873e0624a5712b--