From: Patrick Robb <probb@iol.unh.edu>
To: Luca Vizzarro <Luca.Vizzarro@arm.com>
Cc: dmarx@iol.unh.edu, Paul.Szczepanek@arm.com, abailey@iol.unh.edu,
mmahajan@iol.unh.edu, thomas.wilks@arm.com, dev@dpdk.org
Subject: Re: [PATCH] dts: call hugepages configure at testrun setup
Date: Mon, 28 Jul 2025 10:19:18 -0400 [thread overview]
Message-ID: <CAJvnSUBmpgOXD=5Z-8OCFfzrDJrRDnNrLWoJZ7Pb6hHve3q3zQ@mail.gmail.com> (raw)
In-Reply-To: <b46a313b-048f-4a16-a274-3db9342d48fb@arm.com>
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
On Mon, Jul 28, 2025 at 7:31 AM Luca Vizzarro <Luca.Vizzarro@arm.com> wrote:
> Really good catch Patrick! Thank you for this!
>
> Would it make more sense to place setup_hugepages under Node.setup()?
> In that case the method can also remain private, involving a single line
> change.
>
Yes, that makes more sense. I'll send a new version, thanks.
>
> Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
>
[-- Attachment #2: Type: text/html, Size: 999 bytes --]
next prev parent reply other threads:[~2025-07-28 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 20:05 Patrick Robb
2025-07-28 11:31 ` Luca Vizzarro
2025-07-28 14:19 ` Patrick Robb [this message]
2025-07-28 21:32 ` [PATCH v2] dts: call hugepages configure at node setup Patrick Robb
2025-07-29 9:50 ` Luca Vizzarro
2025-07-29 13:20 ` Patrick Robb
2025-07-29 15:28 ` Patrick Robb
2025-07-29 16:29 ` Luca Vizzarro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJvnSUBmpgOXD=5Z-8OCFfzrDJrRDnNrLWoJZ7Pb6hHve3q3zQ@mail.gmail.com' \
--to=probb@iol.unh.edu \
--cc=Luca.Vizzarro@arm.com \
--cc=Paul.Szczepanek@arm.com \
--cc=abailey@iol.unh.edu \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=mmahajan@iol.unh.edu \
--cc=thomas.wilks@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).